[PATCH resend] omap: Fix linker error in drivers/video/omap/lcd_2430sdp.c

[PATCH resend] omap: Fix linker error in drivers/video/omap/lcd_2430sdp.c

[Jarkko Nikula]

There is a linker error from lcd_2430sdp.c if CONFIG_TWL4030_CORE is not
set. This can be triggered on OMAP2 builds where OMAP3 or OMAP4 are not set.

drivers/built-in.o: In function `sdp2430_panel_disable':
drivers/video/omap/lcd_2430sdp.c:123: undefined reference to `twl_i2c_write_u8'
drivers/video/omap/lcd_2430sdp.c:124: undefined reference to `twl_i2c_write_u8'
drivers/built-in.o: In function `sdp2430_panel_enable':
drivers/video/omap/lcd_2430sdp.c:110: undefined reference to `twl_i2c_write_u8'
drivers/video/omap/lcd_2430sdp.c:112: undefined reference to `twl_i2c_write_u8'

Fix this by adding TWL4030_CORE dependency to CONFIG_MACH_OMAP_2430SDP as
there is no own entry in drivers/video/omap/Kconfig.

Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
Resend = forgot to cc LAKML.
Quite old issue most probably. Can be triggered in mainline anyway.
---
 arch/arm/mach-omap2/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
index b9d8a7b..bfdf240 100644
--- a/arch/arm/mach-omap2/Kconfig
+++ b/arch/arm/mach-omap2/Kconfig
@@ -132,6 +132,7 @@ config MACH_OMAP_2430SDP
 	depends on SOC_OMAP2430
 	default y
 	select OMAP_PACKAGE_ZAC
+	select TWL4030_CORE
 
 config MACH_OMAP3_BEAGLE
 	bool "OMAP3 BEAGLE board"
-- 
1.7.0.4

[PATCH resend] omap: Fix linker error in drivers/video/omap/lcd_2430sdp.c

[Tony Lindgren]

Hi,

* Jarkko Nikula <jhnikula@gmail.com> [110220 12:13]:
> There is a linker error from lcd_2430sdp.c if CONFIG_TWL4030_CORE is not
> set. This can be triggered on OMAP2 builds where OMAP3 or OMAP4 are not set.
> 
> drivers/built-in.o: In function `sdp2430_panel_disable':
> drivers/video/omap/lcd_2430sdp.c:123: undefined reference to `twl_i2c_write_u8'
> drivers/video/omap/lcd_2430sdp.c:124: undefined reference to `twl_i2c_write_u8'
> drivers/built-in.o: In function `sdp2430_panel_enable':
> drivers/video/omap/lcd_2430sdp.c:110: undefined reference to `twl_i2c_write_u8'
> drivers/video/omap/lcd_2430sdp.c:112: undefined reference to `twl_i2c_write_u8'
> 
> Fix this by adding TWL4030_CORE dependency to CONFIG_MACH_OMAP_2430SDP as
> there is no own entry in drivers/video/omap/Kconfig.
> 
> Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
> Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
> Resend = forgot to cc LAKML.
> Quite old issue most probably. Can be triggered in mainline anyway.
> ---
>  arch/arm/mach-omap2/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index b9d8a7b..bfdf240 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -132,6 +132,7 @@ config MACH_OMAP_2430SDP
>  	depends on SOC_OMAP2430
>  	default y
>  	select OMAP_PACKAGE_ZAC
> +	select TWL4030_CORE
>  
>  config MACH_OMAP3_BEAGLE
>  	bool "OMAP3 BEAGLE board"

We should avoid selecting driver related things, otherwise we can never
build a tiny kernel with initramfs with everything as modules.

Can you see if adding depends to the LCD panel option does the trick
instead?

Thanks,

Tony

[PATCH resend] omap: Fix linker error in drivers/video/omap/lcd_2430sdp.c

[Jarkko Nikula]

On Thu, 24 Feb 2011 13:26:44 -0800
Tony Lindgren <tony@atomide.com> wrote:

> We should avoid selecting driver related things, otherwise we can never
> build a tiny kernel with initramfs with everything as modules.
> 
> Can you see if adding depends to the LCD panel option does the trick
> instead?
> 
True and as lcd_2430sdp.c is not compiled without CONFIG_FB_OMAP a hack
below should work a bit better.

What would you think Tomi?

diff --git a/drivers/video/omap/Kconfig b/drivers/video/omap/Kconfig
index 083c8fe..c981249 100644
--- a/drivers/video/omap/Kconfig
+++ b/drivers/video/omap/Kconfig
@@ -5,6 +5,7 @@ config FB_OMAP
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT
+	select TWL4030_CORE if MACH_OMAP_2430SDP
 	help
           Frame buffer driver for OMAP based boards.

-- 
Jarkko

[PATCH resend] omap: Fix linker error in drivers/video/omap/lcd_2430sdp.c

[Tomi Valkeinen]

On Mon, 2011-02-28 at 08:47 -0600, Jarkko Nikula wrote:
> On Thu, 24 Feb 2011 13:26:44 -0800
> Tony Lindgren <tony@atomide.com> wrote:
> 
> > We should avoid selecting driver related things, otherwise we can never
> > build a tiny kernel with initramfs with everything as modules.
> > 
> > Can you see if adding depends to the LCD panel option does the trick
> > instead?
> > 
> True and as lcd_2430sdp.c is not compiled without CONFIG_FB_OMAP a hack
> below should work a bit better.
> 
> What would you think Tomi?
> 
> diff --git a/drivers/video/omap/Kconfig b/drivers/video/omap/Kconfig
> index 083c8fe..c981249 100644
> --- a/drivers/video/omap/Kconfig
> +++ b/drivers/video/omap/Kconfig
> @@ -5,6 +5,7 @@ config FB_OMAP
>  	select FB_CFB_FILLRECT
>  	select FB_CFB_COPYAREA
>  	select FB_CFB_IMAGEBLIT
> +	select TWL4030_CORE if MACH_OMAP_2430SDP
>  	help
>            Frame buffer driver for OMAP based boards.
> 

Well, it's a bit ugly, but I'm fine with it. It's for the old omapfb,
which hopefully nobody uses anymore (right =), and there's no simple way
to make it modular and neat.

The old omapfb compiles lcd_2430sdp always into the kernel if
MACH_OMAP_2430SDP is defined, so this looks like a correct fix to me.

Heh, interestingly, the old omapfb Makefile says: "Makefile for the new
OMAP framebuffer device driver". Things are relative =).

 Tomi

[PATCH resend] omap: Fix linker error in drivers/video/omap/lcd_2430sdp.c

[Tony Lindgren]

* Tomi Valkeinen <tomi.valkeinen@ti.com> [110228 07:07]:
> 
> Well, it's a bit ugly, but I'm fine with it. It's for the old omapfb,
> which hopefully nobody uses anymore (right =), and there's no simple way
> to make it modular and neat.

How about let's make mach-omap2 boards all use the new code?
That way the old code can be omap1 only.

Regards,

Tony

[PATCH resend] omap: Fix linker error in drivers/video/omap/lcd_2430sdp.c

[Tomi Valkeinen]

On Mon, 2011-02-28 at 19:39 -0600, Tony Lindgren wrote:
> * Tomi Valkeinen <tomi.valkeinen@ti.com> [110228 07:07]:
> > 
> > Well, it's a bit ugly, but I'm fine with it. It's for the old omapfb,
> > which hopefully nobody uses anymore (right =), and there's no simple way
> > to make it modular and neat.
> 
> How about let's make mach-omap2 boards all use the new code?
> That way the old code can be omap1 only.

That has been my long term plan, but I've never had time to start
working on it. Some (many?) of the old panel drivers are trivial to
port, needs just copying the panel timings. 

Some are much more complex, and porting them without having the hardware
may be a bit of a guesswork. But perhaps we can find testers for those
after the code has been ported.

 Tomi

[PATCH resend] omap: Fix linker error in drivers/video/omap/lcd_2430sdp.c

[Tony Lindgren]

* Tomi Valkeinen <tomi.valkeinen@ti.com> [110228 22:27]:
> On Mon, 2011-02-28 at 19:39 -0600, Tony Lindgren wrote:
> > * Tomi Valkeinen <tomi.valkeinen@ti.com> [110228 07:07]:
> > > 
> > > Well, it's a bit ugly, but I'm fine with it. It's for the old omapfb,
> > > which hopefully nobody uses anymore (right =), and there's no simple way
> > > to make it modular and neat.
> > 
> > How about let's make mach-omap2 boards all use the new code?
> > That way the old code can be omap1 only.
> 
> That has been my long term plan, but I've never had time to start
> working on it. Some (many?) of the old panel drivers are trivial to
> port, needs just copying the panel timings. 

OK, that will probably make things a lot easier in the long run.
 
> Some are much more complex, and porting them without having the hardware
> may be a bit of a guesswork. But perhaps we can find testers for those
> after the code has been ported.

Sure, once we get one working others should be easy..

Tony