From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM imx53: add pwm devices support
Date: Tue, 1 Mar 2011 20:04:20 +0100 [thread overview]
Message-ID: <20110301190420.GW22310@pengutronix.de> (raw)
In-Reply-To: <AANLkTimCxkN1HKvhoMS7kHBngYxk6jNbz5qTssH4Fz-B@mail.gmail.com>
Hi Fabio,
On Tue, Mar 01, 2011 at 10:47:23AM -0300, Fabio Estevam wrote:
> On Tue, Mar 1, 2011 at 6:38 AM, Jason Chen <b02280@freescale.com> wrote:
> ...
> > - ? ? ? if (cpu_is_mx27() || cpu_is_mx3() || cpu_is_mx25() || cpu_is_mx51()) {
> > + ? ? ? if (cpu_is_mx27() || cpu_is_mx3() || cpu_is_mx25() || cpu_is_mx51() ||
> > + ? ? ? ? ? ? ? cpu_is_mx53()) {
>
> Wouldn?t "if (!cpu_is_mx1() && !cpu_is_mx21())" work here and make
> the if statement simpler?
Yes, but less future proof. (Assume the next generation SoC is
different ...)
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2011-03-01 19:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 9:38 [PATCH 1/2] ARM imx53: add pwm devices support Jason Chen
2011-03-01 9:38 ` [PATCH 2/2] ARM MX53_LOCO: add pwm backlight device Jason Chen
2011-03-02 8:46 ` Sascha Hauer
2011-03-01 13:47 ` [PATCH 1/2] ARM imx53: add pwm devices support Fabio Estevam
2011-03-01 19:04 ` Uwe Kleine-König [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-08-30 7:52 jason.chen at freescale.com
2011-08-30 9:14 ` Eric Miao
2011-03-04 2:48 Jason Chen
2011-04-04 14:58 ` Uwe Kleine-König
2011-03-01 6:30 Jason Chen
2011-03-01 7:35 ` Eric Miao
2011-03-01 8:10 ` Uwe Kleine-König
2011-03-01 8:21 ` Eric Miao
2011-03-01 9:04 ` Uwe Kleine-König
2011-03-01 9:08 ` Jason Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110301190420.GW22310@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).