From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] ARM: mx35_3ds: Add I2C support
Date: Tue, 1 Mar 2011 21:17:03 +0100 [thread overview]
Message-ID: <20110301201703.GX22310@pengutronix.de> (raw)
In-Reply-To: <1299009588-8783-1-git-send-email-fabio.estevam@freescale.com>
Hello,
On Tue, Mar 01, 2011 at 04:59:44PM -0300, Fabio Estevam wrote:
> + imx35_add_imx_i2c0(&mx35_3ds_i2c0_data);
I'd slightly prefer using
imx35_add_imx_i2c(0, ...)
because I intend to remove the imx35_add_imx_i2c0-like macros soon. But
if nothing else pops up there is no need to respin the series because of
that.
Other than that all 5 patches look good;
Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2011-03-01 20:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 19:59 [PATCH 1/5] ARM: mx35_3ds: Add I2C support Fabio Estevam
2011-03-01 19:59 ` [PATCH 2/5] ARM: mx31_3ds: " Fabio Estevam
2011-03-01 19:59 ` [PATCH 3/5] ARM: mx27_3ds: " Fabio Estevam
2011-03-01 19:59 ` [PATCH 4/5] ARM: mx25_3ds: " Fabio Estevam
2011-03-01 19:59 ` [PATCH 5/5] ARM: mx53_smd: " Fabio Estevam
2011-03-01 20:17 ` Uwe Kleine-König [this message]
2011-03-02 7:14 ` [PATCH 1/5] ARM: mx35_3ds: " Jason Liu
2011-03-02 8:37 ` Sascha Hauer
2011-03-02 8:54 ` Jason Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110301201703.GX22310@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).