From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 1/1] PRUSS UIO driver support
Date: Wed, 2 Mar 2011 14:22:26 +0100 [thread overview]
Message-ID: <201103021422.27094.arnd@arndb.de> (raw)
In-Reply-To: <1299065886-30099-2-git-send-email-pratheesh@ti.com>
On Wednesday 02 March 2011, Pratheesh Gangadhar wrote:
> +
> +static struct clk *pruss_clk;
> +static struct uio_info *info;
> +static dma_addr_t sram_paddr, ddr_paddr;
> +static void *prussio_vaddr, *sram_vaddr, *ddr_vaddr;
> +
To my initial comment about these being single-instance
variables, you said you'd change that, which has not happened
yet.
Also, I now noticed that the types are wrong, you are
missing __iomem annotations for MMIO ranges. Please make
sure that the code builds fine with sparse and "make C=1",
which will tell you about these problems.
Arnd
next prev parent reply other threads:[~2011-03-02 13:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-02 11:38 [PATCH v8 0/1] Add PRUSS UIO driver support Pratheesh Gangadhar
2011-03-02 11:38 ` [PATCH v8 1/1] " Pratheesh Gangadhar
2011-03-02 13:22 ` Arnd Bergmann [this message]
2011-03-03 9:24 ` TK, Pratheesh Gangadhar
2011-03-02 13:23 ` Thomas Gleixner
2011-03-02 20:09 ` Hans J. Koch
2011-03-02 20:23 ` Arnd Bergmann
2011-03-02 20:56 ` Thomas Gleixner
2011-03-03 9:29 ` TK, Pratheesh Gangadhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103021422.27094.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox