From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: S5PC210: add support for i2c PMICs on Universal_C210 board
Date: Sat, 5 Mar 2011 11:21:38 +0000 [thread overview]
Message-ID: <20110305112138.GB27468@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <AANLkTimHPzbWpqFMXr2D46VXxLeHaAVTtpeCSaByweu8@mail.gmail.com>
On Thu, Mar 03, 2011 at 11:40:26AM +0900, Kyungmin Park wrote:
> On Tue, Feb 15, 2011 at 8:35 PM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> > On Tue, Feb 15, 2011 at 11:59:15AM +0100, Marek Szyprowski wrote:
> >> ?#include <mach/map.h>
> >> +#include <mach/gpio.h>
> >
> > Need I say anything about this?
>
> Hi Russell,
>
> How about to prevent it as compiler error? It's frequent mistake.
>
> At each mach/gpio.h
>
> #ifndef __LINUX_GPIO_H
> #error "You should include <linux/gpio.h> instead of <mach/gpio.h>."
> #endif
It doesn't stop people including linux/gpio.h and then mach/gpio.h,
which is also a common mistake. Besides, it's easy to catch when you
have a regexp setup in your mail reader to find them...
prev parent reply other threads:[~2011-03-05 11:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 10:59 [PATCH] ARM: S5PC210: add support for i2c PMICs on Universal_C210 board Marek Szyprowski
2011-02-15 11:35 ` Russell King - ARM Linux
2011-02-15 12:50 ` [PATCH v2] " Marek Szyprowski
2011-03-03 2:21 ` Kukjin Kim
2011-03-03 14:59 ` [PATCH v3] ARM: EXYNOS4: " Marek Szyprowski
2011-03-04 1:53 ` Kukjin Kim
2011-03-03 2:40 ` [PATCH] ARM: S5PC210: " Kyungmin Park
2011-03-05 11:21 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110305112138.GB27468@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).