From: jhnikula@gmail.com (Jarkko Nikula)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] OMAP1: McBSP: fix build break for non-multi-OMAP1 configs
Date: Mon, 7 Mar 2011 16:30:47 +0200 [thread overview]
Message-ID: <20110307163047.a65c51d2.jhnikula@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1103041535150.10981@utopia.booyaka.com>
On Fri, 4 Mar 2011 15:36:46 -0700 (MST)
Paul Walmsley <paul@pwsan.com> wrote:
>
> Commit 3cf32bba8ca0e0052ca41d74d455a5805b7fea85 ("OMAP: McBSP: Convert
> McBSP to platform device model") in the current omap-for-linus branch
> breaks compilation with non-multi-OMAP1 configs:
>
> CC arch/arm/mach-omap1/mcbsp.o
> arch/arm/mach-omap1/mcbsp.c: In function 'omap1_mcbsp_init':
> arch/arm/mach-omap1/mcbsp.c:384: warning: dereferencing 'void *' pointer
> arch/arm/mach-omap1/mcbsp.c:387: error: invalid use of void expression
> arch/arm/mach-omap1/mcbsp.c:390: warning: dereferencing 'void *' pointer
> arch/arm/mach-omap1/mcbsp.c:393: error: invalid use of void expression
>
> +#define omap7xx_mcbsp_res_0 omap7xx_mcbsp_res[0]
> +
...
> if (cpu_is_omap7xx())
> - omap_mcbsp_register_board_cfg(omap7xx_mcbsp_res[0],
> + omap_mcbsp_register_board_cfg(omap7xx_mcbsp_res_0,
> OMAP7XX_MCBSP_RES_SZ,
> omap7xx_mcbsp_pdata,
> OMAP7XX_MCBSP_COUNT);
omapxxx_mcbsp_res_0 doesn't look the best here in readability point of
view but provides the smallest fix as no need to rename array and
modify the _RES_SZ and _COUNT macros. So this fix is needed here and a
small readability update can be done later.
Acked-by: Jarkko Nikula <jhnikula@gmail.com>
next prev parent reply other threads:[~2011-03-07 14:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 22:36 [PATCH] OMAP1: McBSP: fix build break for non-multi-OMAP1 configs Paul Walmsley
2011-03-07 14:30 ` Jarkko Nikula [this message]
2011-03-08 2:34 ` Paul Walmsley
2011-03-08 23:11 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110307163047.a65c51d2.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).