From: paul@pwsan.com (Paul Walmsley)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/5] OMAP2+: hwmod: Fix what _init_clock returns
Date: Mon, 07 Mar 2011 22:44:31 -0700 [thread overview]
Message-ID: <20110308054429.1309.36007.stgit@twilight.localdomain> (raw)
In-Reply-To: <20110308054315.1309.10538.stgit@twilight.localdomain>
From: Rajendra Nayak <rnayak@ti.com>
_init_clock always returns 0 and does
not propogate the error (in case of failure)
back to the caller, causing _init_clocks to
fail silently.
Signed-off-by: Rajendra Nayak <rnayak@ti.com>
Acked-by: Beno?t Cousson <b-cousson@ti.com>
Signed-off-by: Paul Walmsley <paul@pwsan.com>
---
arch/arm/mach-omap2/omap_hwmod.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod.c b/arch/arm/mach-omap2/omap_hwmod.c
index 9b4f6cd..671f871 100644
--- a/arch/arm/mach-omap2/omap_hwmod.c
+++ b/arch/arm/mach-omap2/omap_hwmod.c
@@ -926,7 +926,7 @@ static int _init_clocks(struct omap_hwmod *oh, void *data)
if (!ret)
oh->_state = _HWMOD_STATE_CLKS_INITED;
- return 0;
+ return ret;
}
/**
next prev parent reply other threads:[~2011-03-08 5:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-08 5:44 [PATCH 0/5] OMAP2+: hwmod: miscellaneous fixes for 2.6.39 Paul Walmsley
2011-03-08 5:44 ` [PATCH 1/5] OMAP2+: hwmod: fix incorrect computation of autoidle_mask Paul Walmsley
2011-03-08 5:44 ` [PATCH 2/5] omap: hwmod: add syss reset done flags to omap2, omap3 hwmods Paul Walmsley
2011-03-08 5:44 ` Paul Walmsley [this message]
2011-03-08 5:44 ` [PATCH 4/5] OMAP2+: hwmod: fix a documentation bug with HWMOD_NO_OCP_AUTOIDLE Paul Walmsley
2011-03-08 5:44 ` [PATCH 5/5] OMAP2+: hwmod: use status bit info for reset line Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110308054429.1309.36007.stgit@twilight.localdomain \
--to=paul@pwsan.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).