* [PATCH] omap2+: mux: Remove the use of IDLE flag. [not found] ` <20110308164033.GC26463@atomide.com> @ 2011-03-09 7:49 ` Sricharan R 2011-03-09 11:49 ` Sricharan R 1 sibling, 0 replies; 6+ messages in thread From: Sricharan R @ 2011-03-09 7:49 UTC (permalink / raw) To: linux-arm-kernel Tony, >-----Original Message----- From: linux-omap-owner@vger.kernel.org [mailto:linux-omap- >owner at vger.kernel.org] On Behalf Of Tony Lindgren >Sent: Tuesday, March 08, 2011 10:11 PM >To: sricharan >Cc: linux-omap at vger.kernel.org; b-cousson at ti.com; santosh.shilimkar at ti.com; >paul at pswan.com >Subject: Re: [PATCH] omap2+: mux: Remove the use of IDLE flag. > >* sricharan <r.sricharan@ti.com> [110306 20:33]: >> Currently OMAP_DEVICE_PAD_IDLE flag is used to mux pins >> dynamically. This can be simplified by using the enabled >> state variable of each pad. This also fixes the issue of >> the static pads not getting muxed after idling and >> disable/enable state transitions. > >Looks good, can you please repost one more time with linux-arm-kernel >mailing list also Cc'd? > Ok sure. I have re posted this to the linux-arm-kernel list. >Thanks, > >Tony >-- >To unsubscribe from this list: send the line "unsubscribe linux-omap" in >the body of a message to majordomo at vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] omap2+: mux: Remove the use of IDLE flag. [not found] ` <20110308164033.GC26463@atomide.com> 2011-03-09 7:49 ` [PATCH] omap2+: mux: Remove the use of IDLE flag Sricharan R @ 2011-03-09 11:49 ` Sricharan R 2011-03-09 20:32 ` [PATCH] omap2+: mux: Add macro for configuring static with omap_hwmod_mux_init (Re: [PATCH] omap2+: mux: Remove the use of IDLE flag) Tony Lindgren 1 sibling, 1 reply; 6+ messages in thread From: Sricharan R @ 2011-03-09 11:49 UTC (permalink / raw) To: linux-arm-kernel Tony, >-----Original Message----- >From: Sricharan R [mailto:r.sricharan at ti.com] >Sent: Wednesday, March 09, 2011 1:19 PM >To: 'Tony Lindgren' >Cc: 'linux-omap at vger.kernel.org'; Benoit Cousson; Santosh Shilimkar; >'paul at pswan.com'; 'linux-arm-kernel at lists.infradead.org' >Subject: RE: [PATCH] omap2+: mux: Remove the use of IDLE flag. > [....] >>* sricharan <r.sricharan@ti.com> [110306 20:33]: >>> Currently OMAP_DEVICE_PAD_IDLE flag is used to mux pins >>> dynamically. This can be simplified by using the enabled >>> state variable of each pad. This also fixes the issue of >>> the static pads not getting muxed after idling and >>> disable/enable state transitions. >> >>Looks good, can you please repost one more time with linux-arm-kernel >>mailing list also Cc'd? >> >Ok sure. I have re posted this to the linux-arm-kernel list. Btw,I have fixed the comments on the below patches that I sent for configuring the serial pads. 4430sdp: http://marc.info/?l=linux-omap&m=129900334420003&w=2 omap4panda: http://marc.info/?l=linux-omap&m=129900338520082&w=2 3430sdp: http://marc.info/?l=linux-omap&m=129619117726479&w=2 Can you please check if they are ok? Thanks, Sricharan ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] omap2+: mux: Add macro for configuring static with omap_hwmod_mux_init (Re: [PATCH] omap2+: mux: Remove the use of IDLE flag) 2011-03-09 11:49 ` Sricharan R @ 2011-03-09 20:32 ` Tony Lindgren 2011-03-10 4:26 ` Sricharan R 2011-03-11 6:13 ` Sricharan R 0 siblings, 2 replies; 6+ messages in thread From: Tony Lindgren @ 2011-03-09 20:32 UTC (permalink / raw) To: linux-arm-kernel * Sricharan R <r.sricharan@ti.com> [110309 03:47]: > > Btw,I have fixed the comments on the below patches that > I sent for configuring the serial pads. > > 4430sdp: > http://marc.info/?l=linux-omap&m=129900334420003&w=2 > > omap4panda: > http://marc.info/?l=linux-omap&m=129900338520082&w=2 > > 3430sdp: > http://marc.info/?l=linux-omap&m=129619117726479&w=2 > > Can you please check if they are ok? Look OK to me, but let's make things a bit easier to read and maintain with the following patch. Can you please update your patches to use this macro? Each line then just becomes something like: OMAP_MUX_STATIC("uart3_tx_irtx.uart3_tx_irtx", OMAP_PIN_OUTPUT | OMAP_MUX_MODE0), Regards, Tony From: Tony Lindgren <tony@atomide.com> Date: Wed, 9 Mar 2011 12:14:04 -0800 Subject: [PATCH] omap2+: mux: Add macro for configuring static with omap_hwmod_mux_init Add macro for defining static pins in the board file. We can now start implementing pin multiplexing in the platform init code for devices that call omap_hwmod_mux_init. Currently that is only implemented for serial.c. Signed-off-by: Tony Lindgren <tony@atomide.com> --- a/arch/arm/mach-omap2/mux.h +++ b/arch/arm/mach-omap2/mux.h @@ -186,6 +186,12 @@ struct omap_device_pad { struct omap_hwmod_mux_info; +#define OMAP_MUX_STATIC(signal, mode) \ +{ \ + .name = (signal), \ + .enable = (mode), \ +} + #if defined(CONFIG_OMAP_MUX) /** ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] omap2+: mux: Add macro for configuring static with omap_hwmod_mux_init (Re: [PATCH] omap2+: mux: Remove the use of IDLE flag) 2011-03-09 20:32 ` [PATCH] omap2+: mux: Add macro for configuring static with omap_hwmod_mux_init (Re: [PATCH] omap2+: mux: Remove the use of IDLE flag) Tony Lindgren @ 2011-03-10 4:26 ` Sricharan R 2011-03-11 6:13 ` Sricharan R 1 sibling, 0 replies; 6+ messages in thread From: Sricharan R @ 2011-03-10 4:26 UTC (permalink / raw) To: linux-arm-kernel Tony, >-----Original Message----- >From: Tony Lindgren [mailto:tony at atomide.com] >Sent: Thursday, March 10, 2011 2:02 AM >To: Sricharan R >Cc: linux-omap at vger.kernel.org; Benoit Cousson; Santosh Shilimkar; >paul at pswan.com; linux-arm-kernel at lists.infradead.org >Subject: [PATCH] omap2+: mux: Add macro for configuring static with >omap_hwmod_mux_init (Re: [PATCH] omap2+: mux: Remove the use of IDLE flag) > >* Sricharan R <r.sricharan@ti.com> [110309 03:47]: >> >> Btw,I have fixed the comments on the below patches that >> I sent for configuring the serial pads. >> >> 4430sdp: >> http://marc.info/?l=linux-omap&m=129900334420003&w=2 >> >> omap4panda: >> http://marc.info/?l=linux-omap&m=129900338520082&w=2 >> >> 3430sdp: >> http://marc.info/?l=linux-omap&m=129619117726479&w=2 >> >> Can you please check if they are ok? > >Look OK to me, but let's make things a bit easier to read >and maintain with the following patch. Can you please >update your patches to use this macro? > >Each line then just becomes something like: > >OMAP_MUX_STATIC("uart3_tx_irtx.uart3_tx_irtx", > OMAP_PIN_OUTPUT | OMAP_MUX_MODE0), > Ok thanks. I will update and send again. >Regards, > >Tony > > >From: Tony Lindgren <tony@atomide.com> >Date: Wed, 9 Mar 2011 12:14:04 -0800 >Subject: [PATCH] omap2+: mux: Add macro for configuring static with >omap_hwmod_mux_init > >Add macro for defining static pins in the board file. > >We can now start implementing pin multiplexing in the platform init >code for devices that call omap_hwmod_mux_init. Currently that is >only implemented for serial.c. > >Signed-off-by: Tony Lindgren <tony@atomide.com> > >--- a/arch/arm/mach-omap2/mux.h >+++ b/arch/arm/mach-omap2/mux.h >@@ -186,6 +186,12 @@ struct omap_device_pad { > > struct omap_hwmod_mux_info; > >+#define OMAP_MUX_STATIC(signal, mode) \ >+{ \ >+ .name = (signal), \ >+ .enable = (mode), \ >+} >+ > #if defined(CONFIG_OMAP_MUX) > > /** ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] omap2+: mux: Add macro for configuring static with omap_hwmod_mux_init (Re: [PATCH] omap2+: mux: Remove the use of IDLE flag) 2011-03-09 20:32 ` [PATCH] omap2+: mux: Add macro for configuring static with omap_hwmod_mux_init (Re: [PATCH] omap2+: mux: Remove the use of IDLE flag) Tony Lindgren 2011-03-10 4:26 ` Sricharan R @ 2011-03-11 6:13 ` Sricharan R 2011-03-11 19:35 ` Tony Lindgren 1 sibling, 1 reply; 6+ messages in thread From: Sricharan R @ 2011-03-11 6:13 UTC (permalink / raw) To: linux-arm-kernel Tony, >>Look OK to me, but let's make things a bit easier to read >>and maintain with the following patch. Can you please >>update your patches to use this macro? >> >>Each line then just becomes something like: >> >>OMAP_MUX_STATIC("uart3_tx_irtx.uart3_tx_irtx", >> OMAP_PIN_OUTPUT | OMAP_MUX_MODE0), >> >Ok thanks. I will update and send again. 4430SDP: http://marc.info/?l=linux-omap&m=129982347622340&w=2 omap4panda: http://marc.info/?l=linux-omap&m=129982347722344&w=2 3430sdp: http://marc.info/?l=linux-omap&m=129982347822347&w=2 I have reworked the patches using your MACRO. I have applied on top of the omap-for-linus branch and tested them on 4430sdp, 3430sdp, omap4panda. Thanks, Sricharan' ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] omap2+: mux: Add macro for configuring static with omap_hwmod_mux_init (Re: [PATCH] omap2+: mux: Remove the use of IDLE flag) 2011-03-11 6:13 ` Sricharan R @ 2011-03-11 19:35 ` Tony Lindgren 0 siblings, 0 replies; 6+ messages in thread From: Tony Lindgren @ 2011-03-11 19:35 UTC (permalink / raw) To: linux-arm-kernel * Sricharan R <r.sricharan@ti.com> [110310 22:10]: > Tony, > >>Look OK to me, but let's make things a bit easier to read > >>and maintain with the following patch. Can you please > >>update your patches to use this macro? > >> > >>Each line then just becomes something like: > >> > >>OMAP_MUX_STATIC("uart3_tx_irtx.uart3_tx_irtx", > >> OMAP_PIN_OUTPUT | OMAP_MUX_MODE0), > >> > >Ok thanks. I will update and send again. > > 4430SDP: > http://marc.info/?l=linux-omap&m=129982347622340&w=2 > > omap4panda: > http://marc.info/?l=linux-omap&m=129982347722344&w=2 > > 3430sdp: > http://marc.info/?l=linux-omap&m=129982347822347&w=2 > > I have reworked the patches using your MACRO. > > I have applied on top of the omap-for-linus branch and > tested them on 4430sdp, 3430sdp, omap4panda. OK thanks, applying them. Tony ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-03-11 19:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1299472552-22017-1-git-send-email-r.sricharan@ti.com>
[not found] ` <20110308164033.GC26463@atomide.com>
2011-03-09 7:49 ` [PATCH] omap2+: mux: Remove the use of IDLE flag Sricharan R
2011-03-09 11:49 ` Sricharan R
2011-03-09 20:32 ` [PATCH] omap2+: mux: Add macro for configuring static with omap_hwmod_mux_init (Re: [PATCH] omap2+: mux: Remove the use of IDLE flag) Tony Lindgren
2011-03-10 4:26 ` Sricharan R
2011-03-11 6:13 ` Sricharan R
2011-03-11 19:35 ` Tony Lindgren
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).