From: jamie@jamieiles.com (Jamie Iles)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/3] ARM: S5P: Add s5p_timer support for HRT
Date: Thu, 10 Mar 2011 09:49:41 +0000 [thread overview]
Message-ID: <20110310094941.GA3289@pulham.picochip.com> (raw)
In-Reply-To: <002d01cbdede$65e19660$31a4c320$@com>
Hi,
On Thu, Mar 10, 2011 at 01:48:22PM +0900, Sangbeom Kim wrote:
> And Do you mean that Is needed error handling of clk_enable like
> below?
>
> clk_enable(timerclk);
>
> if (IS_ERR(timerclk)){
> clk_put(timerclk)
> panic("failed to enable timers clock");
> }
No, clk_enable() returns negative errno on failure, so something like.
if (clk_enable(timerclk))
panic("failed to enable timerclk");
> There is no another clk_enable for timerclk.
I didn't mean for just timerclk, there are several other clk_enable()'s
for other clks.
Jamie
next prev parent reply other threads:[~2011-03-10 9:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-09 2:13 [PATCH v4 0/3] ARM: S5P: Add HRT support for s5p series Sangbeom Kim
2011-03-09 2:13 ` [PATCH v4 1/3] ARM: S5P: Add s5p_timer support for HRT Sangbeom Kim
2011-03-09 14:10 ` Jamie Iles
2011-03-10 4:48 ` Sangbeom Kim
2011-03-10 9:49 ` Jamie Iles [this message]
2011-03-10 10:19 ` Kukjin Kim
2011-03-09 2:13 ` [PATCH v4 2/3] ARM: S5P: Update machine initialization " Sangbeom Kim
2011-03-09 2:13 ` [PATCH v4 3/3] ARM: S5P: Update defconfig for HRT support Sangbeom Kim
2011-03-11 23:08 ` [PATCH v4 0/3] ARM: S5P: Add HRT support for s5p series Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110310094941.GA3289@pulham.picochip.com \
--to=jamie@jamieiles.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).