linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/8] ARM: PXA: Z2: Add poweroff function
Date: Fri, 11 Mar 2011 22:39:03 +0100	[thread overview]
Message-ID: <201103112239.03751.marek.vasut@gmail.com> (raw)
In-Reply-To: <1299839023-16601-5-git-send-email-anarsoul@gmail.com>

On Friday 11 March 2011 11:23:40 Vasily Khoruzhick wrote:
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>

This looks bogus to me as you cannot power down the thing. Besides, where do you 
resume to from this so-called "powerdown" ? Since the bootloader will consider 
it as a legitimate deepsleep resume.

> ---
>  arch/arm/mach-pxa/z2.c |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-pxa/z2.c b/arch/arm/mach-pxa/z2.c
> index aec87f7..f1bb98a 100644
> --- a/arch/arm/mach-pxa/z2.c
> +++ b/arch/arm/mach-pxa/z2.c
> @@ -42,6 +42,7 @@
>  #include <plat/pxa27x_keypad.h>
>  #include <mach/pxa27x-udc.h>
>  #include <mach/ohci.h>
> +#include <mach/pm.h>
> 
>  #include "generic.h"
>  #include "devices.h"
> @@ -705,6 +706,16 @@ static struct pxaohci_platform_data
> z2_ohci_platform_data = { .power_budget	= 500,
>  };
> 
> +#ifdef CONFIG_PM
> +static void z2_power_off(void)
> +{
> +	local_irq_disable();
> +	pxa27x_cpu_suspend(PWRMODE_DEEPSLEEP);
> +}
> +#else
> +#define z2_power_off   NULL
> +#endif
> +
>  /*************************************************************************
> ***** * Machine init
>  
> **************************************************************************
> ****/ @@ -727,6 +738,8 @@ static void __init z2_init(void)
>  	z2_leds_init();
>  	z2_keys_init();
>  	z2_pmic_init();
> +
> +	pm_power_off = z2_power_off;
>  }
> 
>  MACHINE_START(ZIPIT2, "Zipit Z2")

  reply	other threads:[~2011-03-11 21:39 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-11 10:23 [PATCH 1/8] ARM: PXA: Z2: Use only power button as wake source Vasily Khoruzhick
2011-03-11 10:23 ` [PATCH 2/8] ARM: PXA: Z2: Enable OHCI on Zipit Z2 Vasily Khoruzhick
2011-03-11 14:56   ` [PATCH v2 " Vasily Khoruzhick
2011-03-11 21:42     ` Marek Vasut
2011-03-11 21:49       ` Vasily Khoruzhick
2011-03-11 21:50         ` Marek Vasut
2011-03-11 21:55           ` Vasily Khoruzhick
2011-03-11 22:13             ` Marek Vasut
2011-03-11 22:34               ` Vasily Khoruzhick
2011-03-12  0:07                 ` Marek Vasut
2011-03-12 11:32                   ` Vasily Khoruzhick
2011-03-12 13:28                     ` Marek Vasut
2011-03-13 10:18           ` Pavel Machek
2011-03-13 12:29             ` Marek Vasut
2011-03-13 17:10               ` Pavel Machek
2011-03-13 18:34                 ` Marek Vasut
2011-03-13 22:15                   ` Vasily Khoruzhick
2011-03-11 21:41   ` [PATCH " Marek Vasut
2011-03-11 10:23 ` [PATCH 3/8] ARM: PXA: Z2: Fix battery pdata Vasily Khoruzhick
2011-03-11 21:39   ` Marek Vasut
2011-03-11 10:23 ` [PATCH 4/8] ARM: PXA: Z2: Add mtd partition with logo Vasily Khoruzhick
2011-03-11 21:39   ` Marek Vasut
2011-03-11 22:31     ` Vasily Khoruzhick
2011-03-12  0:05       ` Marek Vasut
2011-03-15 14:39         ` Pavel Machek
2011-03-16 14:11           ` Marek Vasut
2011-03-16 16:51             ` Pavel Machek
2011-03-11 10:23 ` [PATCH 5/8] ARM: PXA: Z2: Add poweroff function Vasily Khoruzhick
2011-03-11 21:39   ` Marek Vasut [this message]
2011-03-11 21:53     ` Vasily Khoruzhick
2011-03-11 22:08       ` Marek Vasut
2011-03-11 22:12         ` Vasily Khoruzhick
2011-03-11 22:16           ` Marek Vasut
2011-03-11 22:30             ` Vasily Khoruzhick
2011-03-12  0:05               ` Marek Vasut
2011-03-12  2:29                 ` Eric Miao
2011-03-12  8:06                 ` Vasily Khoruzhick
2011-03-12 11:06                   ` Marek Vasut
2011-03-12 11:30                     ` Vasily Khoruzhick
2011-03-12 13:16                       ` Marek Vasut
2011-03-12 20:33                         ` Vasily Khoruzhick
2011-03-12 20:35                           ` Marek Vasut
2011-03-12 20:34                         ` Vasily Khoruzhick
2011-03-12 22:29                           ` Marek Vasut
2011-03-15 15:49                             ` Eric Miao
2011-03-15 15:57                               ` Vasily Khoruzhick
2011-03-15 16:42                                 ` Eric Miao
2011-03-15 20:11                                   ` [PATCH v2] " Vasily Khoruzhick
2011-07-05  6:58                                     ` Eric Miao
2011-03-15 14:41                         ` [PATCH 5/8] " Pavel Machek
2011-03-11 10:23 ` [PATCH 6/8] ARM: PXA: Z2: Fix libertas init/tear down sequences Vasily Khoruzhick
2011-03-11 21:37   ` Marek Vasut
2011-03-11 21:41     ` Vasily Khoruzhick
2011-03-11 21:51       ` Marek Vasut
2011-03-11 10:23 ` [PATCH 7/8] ARM: PXA: Z2: Keep kbd backlight disabled by default Vasily Khoruzhick
2011-03-11 21:36   ` Marek Vasut
2011-03-11 10:23 ` [PATCH 8/8] ARM: PXA: Z2: Add default triggers for LEDs Vasily Khoruzhick
2011-03-11 21:36   ` Marek Vasut
2011-03-11 21:43 ` [PATCH 1/8] ARM: PXA: Z2: Use only power button as wake source Marek Vasut
2011-03-13 10:15 ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201103112239.03751.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).