From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/10] ux500: Adding new board files for snowball.
Date: Sat, 12 Mar 2011 09:57:08 +0000 [thread overview]
Message-ID: <20110312095708.GA739@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <201103121050.00140.arnd@arndb.de>
On Sat, Mar 12, 2011 at 10:50:00AM +0100, Arnd Bergmann wrote:
> The patch looks good. One question though:
>
> > +
> > +static struct pl022_ssp_controller ssp0_platform_data = {
> > + .bus_id = 0,
> > +#ifdef CONFIG_STE_DMA40
> > + .enable_dma = 1,
> > + .dma_filter = stedma40_filter,
> > + .dma_rx_param = &ssp0_dma_cfg_rx,
> > + .dma_tx_param = &ssp0_dma_cfg_tx,
> > +#else
> > + .enable_dma = 0,
> > +#endif
> > + /* on this platform, gpio 31,142,144,214 &
> > + * 224 are connected as chip selects
> > + */
> > + .num_chipselect = 5,
> > +};
>
> You have a lot of #ifdef CONFIG_STE_DMA40. Is that something
> that realistically would be disabled for many users?
>
> If not, you could simply "select STE_DMA40" from the board
> Kconfig symbol and make all these unconditional.
Or have the PL022 driver treat failure to claim DMA as a soft failure and
fall back to PIO - and get rid of the .enable_dma thing - which is what
other primecell drivers do. That way you can keep the initializers there
and leave it to the driver to sort out whether it wants to use DMA or not
depending on whether all the bits are available.
next prev parent reply other threads:[~2011-03-12 9:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-11 23:08 [PATCH 00/10] ux500: support for snowball board mathieu.poirier at linaro.org
2011-03-11 23:08 ` [PATCH 01/10] ux500: Introducing foundation " mathieu.poirier at linaro.org
2011-03-12 9:45 ` Arnd Bergmann
2011-03-11 23:08 ` [PATCH 02/10] ux500: Adding new board files for snowball mathieu.poirier at linaro.org
2011-03-12 9:50 ` Arnd Bergmann
2011-03-12 9:57 ` Russell King - ARM Linux [this message]
2011-03-11 23:08 ` [PATCH 03/10] ux500: Adding custom pin configuration file for snowball. - Adding dependency in Makefile. - Adding init function call to board-snowball.c - New header file mathieu.poirier at linaro.org
2011-03-11 23:08 ` [PATCH 04/10] ux500: Adding sdi support on snowball mathieu.poirier at linaro.org
2011-03-12 9:53 ` Arnd Bergmann
2011-03-11 23:08 ` [PATCH 05/10] smsc911x: use shifted register access mathieu.poirier at linaro.org
2011-03-14 8:42 ` Linus Walleij
2011-03-11 23:08 ` [PATCH 06/10] ux500: added snowball-netev with latest fixes mathieu.poirier at linaro.org
2011-03-12 9:58 ` Arnd Bergmann
2011-03-14 9:04 ` Alessandro Rubini
2011-03-11 23:08 ` [PATCH 07/10] ux500: added snowball-digio.c mathieu.poirier at linaro.org
2011-03-12 9:59 ` Arnd Bergmann
2011-03-11 23:08 ` [PATCH 08/10] ux500: hooking up netdev and digio to compilation mathieu.poirier at linaro.org
2011-03-12 10:00 ` Arnd Bergmann
2011-03-11 23:08 ` [PATCH 09/10] ux500: Addressing irq header file dependency for snowball mathieu.poirier at linaro.org
2011-03-12 10:05 ` Arnd Bergmann
2011-03-14 8:49 ` Linus Walleij
2011-03-11 23:08 ` [PATCH 10/10] ux500: adding config file options for snowball board mathieu.poirier at linaro.org
2011-03-12 9:38 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110312095708.GA739@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).