From: rubini-list@gnudd.com (Alessandro Rubini)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/10] ux500: added snowball-netev with latest fixes
Date: Mon, 14 Mar 2011 10:04:44 +0100 [thread overview]
Message-ID: <20110314090444.GA25815@mail.gnudd.com> (raw)
In-Reply-To: <201103121058.05897.arnd@arndb.de>
Hello Arnd.
>> + volatile u32 *ptr = ioremap(0x80000000, 0x10000);
>
> I suppose you mean "u32 __iomem *" here, not "volatile u32 *ptr".
Yes, full ack. And also for the rest (as you note, the comment
says "horribly").
Actually, this patch was a quick fix to make things work and proceed
with the board. While other people were working on other devices, I
preferred to (temporarily) have a self-contained hack.
Then I forgot to make it clear to Mathieu that this was not, in my
opinion, ready to get submitted. Please wait for us to sort this out;
currently I think the patch set should be parked.
> Better use platform_device_register_simple() instead of
> the static device.
Thanks, I didn't know about this.
next prev parent reply other threads:[~2011-03-14 9:04 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-11 23:08 [PATCH 00/10] ux500: support for snowball board mathieu.poirier at linaro.org
2011-03-11 23:08 ` [PATCH 01/10] ux500: Introducing foundation " mathieu.poirier at linaro.org
2011-03-12 9:45 ` Arnd Bergmann
2011-03-11 23:08 ` [PATCH 02/10] ux500: Adding new board files for snowball mathieu.poirier at linaro.org
2011-03-12 9:50 ` Arnd Bergmann
2011-03-12 9:57 ` Russell King - ARM Linux
2011-03-11 23:08 ` [PATCH 03/10] ux500: Adding custom pin configuration file for snowball. - Adding dependency in Makefile. - Adding init function call to board-snowball.c - New header file mathieu.poirier at linaro.org
2011-03-11 23:08 ` [PATCH 04/10] ux500: Adding sdi support on snowball mathieu.poirier at linaro.org
2011-03-12 9:53 ` Arnd Bergmann
2011-03-11 23:08 ` [PATCH 05/10] smsc911x: use shifted register access mathieu.poirier at linaro.org
2011-03-14 8:42 ` Linus Walleij
2011-03-11 23:08 ` [PATCH 06/10] ux500: added snowball-netev with latest fixes mathieu.poirier at linaro.org
2011-03-12 9:58 ` Arnd Bergmann
2011-03-14 9:04 ` Alessandro Rubini [this message]
2011-03-11 23:08 ` [PATCH 07/10] ux500: added snowball-digio.c mathieu.poirier at linaro.org
2011-03-12 9:59 ` Arnd Bergmann
2011-03-11 23:08 ` [PATCH 08/10] ux500: hooking up netdev and digio to compilation mathieu.poirier at linaro.org
2011-03-12 10:00 ` Arnd Bergmann
2011-03-11 23:08 ` [PATCH 09/10] ux500: Addressing irq header file dependency for snowball mathieu.poirier at linaro.org
2011-03-12 10:05 ` Arnd Bergmann
2011-03-14 8:49 ` Linus Walleij
2011-03-11 23:08 ` [PATCH 10/10] ux500: adding config file options for snowball board mathieu.poirier at linaro.org
2011-03-12 9:38 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110314090444.GA25815@mail.gnudd.com \
--to=rubini-list@gnudd.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).