From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mx5: fix clk id for a few DEFINE_CLOCK
Date: Tue, 15 Mar 2011 09:43:20 +0100 [thread overview]
Message-ID: <20110315084319.GK29521@pengutronix.de> (raw)
In-Reply-To: <1300114343-3736-1-git-send-email-shawn.guo@freescale.com>
On Mon, Mar 14, 2011 at 10:52:23PM +0800, Shawn Guo wrote:
> Signed-off-by: Shawn Guo <shawn.guo@freescale.com>
> ---
> arch/arm/mach-mx5/clock-mx51-mx53.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
Wouldn't it make more sense to remove the id field completely? It is
unused. Additionally, I see fundamental changes in the i.MX clock
framework in the not-so-far future, so I wouldn't make cosmetic patches
now.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2011-03-15 8:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 14:52 [PATCH] ARM: mx5: fix clk id for a few DEFINE_CLOCK Shawn Guo
2011-03-15 8:43 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110315084319.GK29521@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).