From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: mx5/mx53_evk: Remove unneeded gpio_set_value call
Date: Tue, 15 Mar 2011 10:49:46 +0100 [thread overview]
Message-ID: <20110315094946.GD13316@pengutronix.de> (raw)
In-Reply-To: <Pine.LNX.4.64.1103151039030.11859@ask.diku.dk>
On Tue, Mar 15, 2011 at 10:41:37AM +0100, Julia Lawall wrote:
> I tried the following
>
> @@
> expression E1,E2;
> @@
>
> gpio_direction_output(E1,E2);
> ...
> - gpio_set_value(E1,E2);
>
> and found occurrences in 15 files. In some cases there seems to be some
> delay before the call to gpio_set_value. Does that have any impacton
> whether it is needed?
gpio_direction_output(E1,E2) implies gpio_set_value(E1,E2), so unless
there is a gpio_set_value(E1,!E2) before gpio_set_value(E1,E2) is a
noop.
I still don't know how to work with coccinelle, so if you point me to a
concrete location I can be more specific.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2011-03-15 9:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 18:21 [PATCH 1/2] ARM: mx5/babbage: Remove unneeded gpio_set_value call Fabio Estevam
2011-03-14 18:21 ` [PATCH 2/2] ARM: mx5/mx53_evk: " Fabio Estevam
2011-03-15 9:06 ` Uwe Kleine-König
2011-03-15 9:41 ` Julia Lawall
2011-03-15 9:49 ` Uwe Kleine-König [this message]
2011-03-15 10:19 ` Julia Lawall
2011-03-15 10:29 ` Wolfram Sang
2011-03-16 8:33 ` Uwe Kleine-König
2011-03-16 9:15 ` Julia Lawall
2011-03-16 14:19 ` Fabio Estevam
2011-03-20 17:56 ` Julia Lawall
2011-03-20 19:24 ` Wolfram Sang
2011-03-20 20:51 ` Julia Lawall
2011-03-20 21:30 ` Wolfram Sang
2011-03-20 21:42 ` Julia Lawall
2011-03-20 21:04 ` Julia Lawall
2011-03-21 7:43 ` Grant Likely
2011-03-21 7:59 ` Julia Lawall
2011-03-21 7:48 ` Grant Likely
2011-03-21 8:01 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110315094946.GD13316@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).