From mboxrd@z Thu Jan 1 00:00:00 1970 From: anarsoul@gmail.com (Vasily Khoruzhick) Date: Tue, 15 Mar 2011 17:57:08 +0200 Subject: [PATCH 5/8] ARM: PXA: Z2: Add poweroff function In-Reply-To: References: <1299839023-16601-1-git-send-email-anarsoul@gmail.com> <201103122329.51319.marek.vasut@gmail.com> Message-ID: <201103151757.13374.anarsoul@gmail.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday 15 March 2011 17:49:26 Eric Miao wrote: > 2011/3/13 Marek Vasut : > > On Saturday 12 March 2011 21:34:01 Vasily Khoruzhick wrote: > >> On Saturday 12 March 2011 15:16:19 Marek Vasut wrote: > >> > Besides, this is nonsense, you're doing a hack and you're trying to > >> > justify it. You cannot powerdown the device, period. You should rather > >> > patch the bootloader to implement this para-powerdown behaviour than > >> > bloat kernel with this workaround. > >> > >> And, btw, there's same code in mainline kernel for zeus machine. > > > > Doesn't mean it's correct. CCing maintainer. Eric, can you also please > > comment on it ? I really don't like the idea of abusing poweroff and > > making people misunderstand. > > I'm actually quite OK with the idea of using deep sleep as a way > for shutdown. As some of the device has no way for a "correct" > shutdown without pulling out the battery. A fake one is at least > better than none, provided it works as expected. So should I send updated version of this patch? (Need to clear PSPR before going to deepsleep) Regards Vasily