linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: mmci: Add ARM variant with extended FIFO
Date: Wed, 16 Mar 2011 16:34:48 +0000	[thread overview]
Message-ID: <20110316163448.GA16538@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <4D80E46C.3010103@canonical.com>

On Wed, Mar 16, 2011 at 10:25:16AM -0600, Matt Waddel wrote:
> On 03/11/2011 10:18 AM, Pawel Moll wrote:
> > New IO FPGA implementation for Versatile Express boards contain
> > MMCI (PL180) cell with FIFO extended to 128 words (512 bytes).
> > 
> > Signed-off-by: Pawel Moll <pawel.moll@arm.com>
> 
> Tested-by: Matt Waddel <matt.waddel@linaro.org>
> 
> This patch improves MMC performance on my vexpress system. Also
> fixes "mmcblk0: error -5 transferring data" errors.

You should use the patch I sent to do dynamic clocking if you're
concerned about performance.  That patch improves performance by
a factor of 8 compared to anything possible by increasing the FIFO
depth.

I am very much of the opinion that deepening the FIFOs is just a
sticky plaster over the problem - and I said as much when it was
first proposed, pointing out that there's other better solutions.

  reply	other threads:[~2011-03-16 16:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-11 17:18 [PATCH] arm: mmci: Add ARM variant with extended FIFO Pawel Moll
2011-03-16 16:25 ` Matt Waddel
2011-03-16 16:34   ` Russell King - ARM Linux [this message]
2011-03-16 16:53     ` Pawel Moll
2011-03-17  8:54 ` Linus Walleij
2011-03-17 10:07   ` Pawel Moll
2011-03-24 22:47 ` Chris Ball

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110316163448.GA16538@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).