* [PATCH 1/4] ARM: mx5/babbage: Use gpio_request_one in babbage_fec_reset
@ 2011-03-17 1:52 Fabio Estevam
2011-03-17 1:52 ` [PATCH 2/4] ARM: mx5/babbage: Use gpio_request_one in babbage_usbhub_reset Fabio Estevam
2011-03-17 7:57 ` [PATCH 1/4] ARM: mx5/babbage: Use gpio_request_one in babbage_fec_reset Uwe Kleine-König
0 siblings, 2 replies; 6+ messages in thread
From: Fabio Estevam @ 2011-03-17 1:52 UTC (permalink / raw)
To: linux-arm-kernel
Current code inside babbage_fec_reset uses gpio_direction_output with initial value of the GPIO and also sets
the GPIO value via gpio_set_value to the same level right after. This is not needed.
By using gpio_request_one it is possible to set the direction and initial value in one shot.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
arch/arm/mach-mx5/board-mx51_babbage.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-mx5/board-mx51_babbage.c b/arch/arm/mach-mx5/board-mx51_babbage.c
index b2ecd19..ff79395 100644
--- a/arch/arm/mach-mx5/board-mx51_babbage.c
+++ b/arch/arm/mach-mx5/board-mx51_babbage.c
@@ -228,13 +228,12 @@ static inline void babbage_fec_reset(void)
int ret;
/* reset FEC PHY */
- ret = gpio_request(BABBAGE_FEC_PHY_RESET, "fec-phy-reset");
+ ret = gpio_request_one(BABBAGE_FEC_PHY_RESET,
+ GPIOF_OUT_INIT_LOW, "fec-phy-reset");
if (ret) {
printk(KERN_ERR"failed to get GPIO_FEC_PHY_RESET: %d\n", ret);
return;
}
- gpio_direction_output(BABBAGE_FEC_PHY_RESET, 0);
- gpio_set_value(BABBAGE_FEC_PHY_RESET, 0);
msleep(1);
gpio_set_value(BABBAGE_FEC_PHY_RESET, 1);
}
--
1.6.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/4] ARM: mx5/babbage: Use gpio_request_one in babbage_usbhub_reset
2011-03-17 1:52 [PATCH 1/4] ARM: mx5/babbage: Use gpio_request_one in babbage_fec_reset Fabio Estevam
@ 2011-03-17 1:52 ` Fabio Estevam
2011-03-17 1:52 ` [PATCH 3/4] ARM: mx5/mx53_evk: Use gpio_request_one in mx53_evk_fec_reset Fabio Estevam
2011-03-17 7:55 ` [PATCH 2/4] ARM: mx5/babbage: Use gpio_request_one in babbage_usbhub_reset Uwe Kleine-König
2011-03-17 7:57 ` [PATCH 1/4] ARM: mx5/babbage: Use gpio_request_one in babbage_fec_reset Uwe Kleine-König
1 sibling, 2 replies; 6+ messages in thread
From: Fabio Estevam @ 2011-03-17 1:52 UTC (permalink / raw)
To: linux-arm-kernel
Current code inside babbage_usbhub_reset uses gpio_direction_output with initial value of the GPIO and also sets
the GPIO value via gpio_set_value to the same level right after. This is not needed.
By using gpio_request_one it is possible to set the direction and initial value in one shot.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
arch/arm/mach-mx5/board-mx51_babbage.c | 9 +++------
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/arch/arm/mach-mx5/board-mx51_babbage.c b/arch/arm/mach-mx5/board-mx51_babbage.c
index ff79395..cba8307 100644
--- a/arch/arm/mach-mx5/board-mx51_babbage.c
+++ b/arch/arm/mach-mx5/board-mx51_babbage.c
@@ -209,17 +209,14 @@ static inline void babbage_usbhub_reset(void)
int ret;
/* Bring USB hub out of reset */
- ret = gpio_request(BABBAGE_USB_HUB_RESET, "GPIO1_7");
+ ret = gpio_request_one(BABBAGE_USB_HUB_RESET,
+ GPIOF_OUT_INIT_LOW, "GPIO1_7");
if (ret) {
printk(KERN_ERR"failed to get GPIO_USB_HUB_RESET: %d\n", ret);
return;
}
- gpio_direction_output(BABBAGE_USB_HUB_RESET, 0);
- /* USB HUB RESET - De-assert USB HUB RESET_N */
- msleep(1);
- gpio_set_value(BABBAGE_USB_HUB_RESET, 0);
- msleep(1);
+ msleep(2);
gpio_set_value(BABBAGE_USB_HUB_RESET, 1);
}
--
1.6.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 3/4] ARM: mx5/mx53_evk: Use gpio_request_one in mx53_evk_fec_reset
2011-03-17 1:52 ` [PATCH 2/4] ARM: mx5/babbage: Use gpio_request_one in babbage_usbhub_reset Fabio Estevam
@ 2011-03-17 1:52 ` Fabio Estevam
2011-03-17 1:52 ` [PATCH 4/4] ARM: mx5/mx53_evk: Make the reset pin name more meaningful Fabio Estevam
2011-03-17 7:55 ` [PATCH 2/4] ARM: mx5/babbage: Use gpio_request_one in babbage_usbhub_reset Uwe Kleine-König
1 sibling, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2011-03-17 1:52 UTC (permalink / raw)
To: linux-arm-kernel
Current code inside mx53_evk_fec_reset uses gpio_direction_output with initial value of the GPIO and also sets
the GPIO value via gpio_set_value right after. This is not needed.
By using gpio_request_one it is possible to set the direction and initial value in one shot.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
arch/arm/mach-mx5/board-mx53_evk.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-mx5/board-mx53_evk.c b/arch/arm/mach-mx5/board-mx53_evk.c
index 7b5735c..8ca55c0 100644
--- a/arch/arm/mach-mx5/board-mx53_evk.c
+++ b/arch/arm/mach-mx5/board-mx53_evk.c
@@ -82,13 +82,12 @@ static inline void mx53_evk_fec_reset(void)
int ret;
/* reset FEC PHY */
- ret = gpio_request(SMD_FEC_PHY_RST, "fec-phy-reset");
+ ret = gpio_request_one(SMD_FEC_PHY_RST, GPIOF_OUT_INIT_LOW,
+ "fec-phy-reset");
if (ret) {
printk(KERN_ERR"failed to get GPIO_FEC_PHY_RESET: %d\n", ret);
return;
}
- gpio_direction_output(SMD_FEC_PHY_RST, 0);
- gpio_set_value(SMD_FEC_PHY_RST, 0);
msleep(1);
gpio_set_value(SMD_FEC_PHY_RST, 1);
}
--
1.6.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 4/4] ARM: mx5/mx53_evk: Make the reset pin name more meaningful
2011-03-17 1:52 ` [PATCH 3/4] ARM: mx5/mx53_evk: Use gpio_request_one in mx53_evk_fec_reset Fabio Estevam
@ 2011-03-17 1:52 ` Fabio Estevam
0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2011-03-17 1:52 UTC (permalink / raw)
To: linux-arm-kernel
As there is a mx53_smd board in the kernel, using SMD_FEC_PHY_RST as the pin name can be misleading when used
on a MX53_EVK board.
Change the pin name to reflect the board name.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
arch/arm/mach-mx5/board-mx53_evk.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-mx5/board-mx53_evk.c b/arch/arm/mach-mx5/board-mx53_evk.c
index d771999..2af3f43 100644
--- a/arch/arm/mach-mx5/board-mx53_evk.c
+++ b/arch/arm/mach-mx5/board-mx53_evk.c
@@ -34,7 +34,7 @@
#include <mach/imx-uart.h>
#include <mach/iomux-mx53.h>
-#define SMD_FEC_PHY_RST IMX_GPIO_NR(7, 6)
+#define MX53_EVK_FEC_PHY_RST IMX_GPIO_NR(7, 6)
#define EVK_ECSPI1_CS0 IMX_GPIO_NR(2, 30)
#define EVK_ECSPI1_CS1 IMX_GPIO_NR(3, 19)
@@ -82,14 +82,14 @@ static inline void mx53_evk_fec_reset(void)
int ret;
/* reset FEC PHY */
- ret = gpio_request_one(SMD_FEC_PHY_RST, GPIOF_OUT_INIT_LOW,
+ ret = gpio_request_one(MX53_EVK_FEC_PHY_RST, GPIOF_OUT_INIT_LOW,
"fec-phy-reset");
if (ret) {
printk(KERN_ERR"failed to get GPIO_FEC_PHY_RESET: %d\n", ret);
return;
}
msleep(1);
- gpio_set_value(SMD_FEC_PHY_RST, 1);
+ gpio_set_value(MX53_EVK_FEC_PHY_RST, 1);
}
static struct fec_platform_data mx53_evk_fec_pdata = {
--
1.6.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/4] ARM: mx5/babbage: Use gpio_request_one in babbage_usbhub_reset
2011-03-17 1:52 ` [PATCH 2/4] ARM: mx5/babbage: Use gpio_request_one in babbage_usbhub_reset Fabio Estevam
2011-03-17 1:52 ` [PATCH 3/4] ARM: mx5/mx53_evk: Use gpio_request_one in mx53_evk_fec_reset Fabio Estevam
@ 2011-03-17 7:55 ` Uwe Kleine-König
1 sibling, 0 replies; 6+ messages in thread
From: Uwe Kleine-König @ 2011-03-17 7:55 UTC (permalink / raw)
To: linux-arm-kernel
Hello Fabio,
On Wed, Mar 16, 2011 at 10:52:32PM -0300, Fabio Estevam wrote:
> Current code inside babbage_usbhub_reset uses gpio_direction_output with initial value of the GPIO and also sets
> the GPIO value via gpio_set_value to the same level right after. This is not needed.
>
> By using gpio_request_one it is possible to set the direction and initial value in one shot.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> arch/arm/mach-mx5/board-mx51_babbage.c | 9 +++------
> 1 files changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/mach-mx5/board-mx51_babbage.c b/arch/arm/mach-mx5/board-mx51_babbage.c
> index ff79395..cba8307 100644
> --- a/arch/arm/mach-mx5/board-mx51_babbage.c
> +++ b/arch/arm/mach-mx5/board-mx51_babbage.c
> @@ -209,17 +209,14 @@ static inline void babbage_usbhub_reset(void)
> int ret;
>
> /* Bring USB hub out of reset */
> - ret = gpio_request(BABBAGE_USB_HUB_RESET, "GPIO1_7");
> + ret = gpio_request_one(BABBAGE_USB_HUB_RESET,
> + GPIOF_OUT_INIT_LOW, "GPIO1_7");
> if (ret) {
> printk(KERN_ERR"failed to get GPIO_USB_HUB_RESET: %d\n", ret);
> return;
> }
> - gpio_direction_output(BABBAGE_USB_HUB_RESET, 0);
>
> - /* USB HUB RESET - De-assert USB HUB RESET_N */
> - msleep(1);
> - gpio_set_value(BABBAGE_USB_HUB_RESET, 0);
> - msleep(1);
> + msleep(2);
> gpio_set_value(BABBAGE_USB_HUB_RESET, 1);
> }
I think the first comment ("Bring USB hub out of reset") is wrong,
shouldn't it be:
/* reset USB hub */
ret = gpio_request_one(BABBAGE_USB_HUB_RESET, ...
if (ret)
...
msleep(2);
/* deassert reset */
gpio_set_value(BABBAGE_USB_HUB_RESET, 1);
because "bring out of reset" is only the set_value(.., 1);?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/4] ARM: mx5/babbage: Use gpio_request_one in babbage_fec_reset
2011-03-17 1:52 [PATCH 1/4] ARM: mx5/babbage: Use gpio_request_one in babbage_fec_reset Fabio Estevam
2011-03-17 1:52 ` [PATCH 2/4] ARM: mx5/babbage: Use gpio_request_one in babbage_usbhub_reset Fabio Estevam
@ 2011-03-17 7:57 ` Uwe Kleine-König
1 sibling, 0 replies; 6+ messages in thread
From: Uwe Kleine-König @ 2011-03-17 7:57 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Mar 16, 2011 at 10:52:31PM -0300, Fabio Estevam wrote:
> Current code inside babbage_fec_reset uses gpio_direction_output with initial value of the GPIO and also sets
> the GPIO value via gpio_set_value to the same level right after. This is not needed.
>
> By using gpio_request_one it is possible to set the direction and initial value in one shot.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de> for patches
1, 3 and 4 in this series.
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-03-17 7:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-17 1:52 [PATCH 1/4] ARM: mx5/babbage: Use gpio_request_one in babbage_fec_reset Fabio Estevam
2011-03-17 1:52 ` [PATCH 2/4] ARM: mx5/babbage: Use gpio_request_one in babbage_usbhub_reset Fabio Estevam
2011-03-17 1:52 ` [PATCH 3/4] ARM: mx5/mx53_evk: Use gpio_request_one in mx53_evk_fec_reset Fabio Estevam
2011-03-17 1:52 ` [PATCH 4/4] ARM: mx5/mx53_evk: Make the reset pin name more meaningful Fabio Estevam
2011-03-17 7:55 ` [PATCH 2/4] ARM: mx5/babbage: Use gpio_request_one in babbage_usbhub_reset Uwe Kleine-König
2011-03-17 7:57 ` [PATCH 1/4] ARM: mx5/babbage: Use gpio_request_one in babbage_fec_reset Uwe Kleine-König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).