From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ARM: mx5/babbage: Use gpio_request_one in babbage_fec_reset
Date: Thu, 17 Mar 2011 08:57:10 +0100 [thread overview]
Message-ID: <20110317075710.GK13316@pengutronix.de> (raw)
In-Reply-To: <1300326754-4629-1-git-send-email-festevam@gmail.com>
On Wed, Mar 16, 2011 at 10:52:31PM -0300, Fabio Estevam wrote:
> Current code inside babbage_fec_reset uses gpio_direction_output with initial value of the GPIO and also sets
> the GPIO value via gpio_set_value to the same level right after. This is not needed.
>
> By using gpio_request_one it is possible to set the direction and initial value in one shot.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de> for patches
1, 3 and 4 in this series.
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
prev parent reply other threads:[~2011-03-17 7:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 1:52 [PATCH 1/4] ARM: mx5/babbage: Use gpio_request_one in babbage_fec_reset Fabio Estevam
2011-03-17 1:52 ` [PATCH 2/4] ARM: mx5/babbage: Use gpio_request_one in babbage_usbhub_reset Fabio Estevam
2011-03-17 1:52 ` [PATCH 3/4] ARM: mx5/mx53_evk: Use gpio_request_one in mx53_evk_fec_reset Fabio Estevam
2011-03-17 1:52 ` [PATCH 4/4] ARM: mx5/mx53_evk: Make the reset pin name more meaningful Fabio Estevam
2011-03-17 7:55 ` [PATCH 2/4] ARM: mx5/babbage: Use gpio_request_one in babbage_usbhub_reset Uwe Kleine-König
2011-03-17 7:57 ` Uwe Kleine-König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110317075710.GK13316@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).