* [PATCH V1 1/3] ahci_platform: add two clk pointer member into ahci_platform_data struct
@ 2011-03-17 7:10 Richard Zhu
2011-03-17 7:10 ` [PATCH V1 2/3] AHCI Add the AHCI SATA feature on MX53 platforms Richard Zhu
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Richard Zhu @ 2011-03-17 7:10 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Richard Zhu <Hong-Xing.Zhu@freescale.com>
---
include/linux/ahci_platform.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/linux/ahci_platform.h b/include/linux/ahci_platform.h
index be3d9a7..86b5e24 100644
--- a/include/linux/ahci_platform.h
+++ b/include/linux/ahci_platform.h
@@ -26,6 +26,8 @@ struct ahci_platform_data {
const struct ata_port_info *ata_port_info;
unsigned int force_port_map;
unsigned int mask_port_map;
+ struct clk *sata_clk;
+ struct clk *sata_ref_clk;
};
#endif /* _AHCI_PLATFORM_H */
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH V1 2/3] AHCI Add the AHCI SATA feature on MX53 platforms
2011-03-17 7:10 [PATCH V1 1/3] ahci_platform: add two clk pointer member into ahci_platform_data struct Richard Zhu
@ 2011-03-17 7:10 ` Richard Zhu
2011-03-17 8:55 ` Sascha Hauer
2011-03-17 7:11 ` [PATCH V1 3/3] MX53 Enable the AHCI SATA on MX53 LOCO Richard Zhu
2011-03-17 8:37 ` [PATCH V1 1/3] ahci_platform: add two clk pointer member into ahci_platform_data struct Sascha Hauer
2 siblings, 1 reply; 6+ messages in thread
From: Richard Zhu @ 2011-03-17 7:10 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Richard Zhu <Hong-Xing.Zhu@freescale.com>
---
arch/arm/mach-mx5/clock-mx51-mx53.c | 11 +++
arch/arm/mach-mx5/devices-imx53.h | 4 +
arch/arm/plat-mxc/devices/Kconfig | 4 +
arch/arm/plat-mxc/devices/Makefile | 1 +
arch/arm/plat-mxc/devices/platform-ahci-imx.c | 109 +++++++++++++++++++++++
arch/arm/plat-mxc/include/mach/ahci_sata.h | 53 +++++++++++
arch/arm/plat-mxc/include/mach/devices-common.h | 10 ++
7 files changed, 192 insertions(+), 0 deletions(-)
create mode 100644 arch/arm/plat-mxc/devices/platform-ahci-imx.c
create mode 100644 arch/arm/plat-mxc/include/mach/ahci_sata.h
diff --git a/arch/arm/mach-mx5/clock-mx51-mx53.c b/arch/arm/mach-mx5/clock-mx51-mx53.c
index 652ace4..8bf2bab 100644
--- a/arch/arm/mach-mx5/clock-mx51-mx53.c
+++ b/arch/arm/mach-mx5/clock-mx51-mx53.c
@@ -1380,6 +1380,14 @@ static struct clk esdhc4_mx53_clk = {
.secondary = &esdhc4_ipg_clk,
};
+static struct clk sata_clk = {
+ .parent = &ipg_clk,
+ .enable = _clk_max_enable,
+ .enable_reg = MXC_CCM_CCGR4,
+ .enable_shift = MXC_CCM_CCGRx_CG1_OFFSET,
+ .disable = _clk_max_disable,
+};
+
DEFINE_CLOCK(mipi_esc_clk, 0, MXC_CCM_CCGR4, MXC_CCM_CCGRx_CG5_OFFSET, NULL, NULL, NULL, &pll2_sw_clk);
DEFINE_CLOCK(mipi_hsc2_clk, 0, MXC_CCM_CCGR4, MXC_CCM_CCGRx_CG4_OFFSET, NULL, NULL, &mipi_esc_clk, &pll2_sw_clk);
DEFINE_CLOCK(mipi_hsc1_clk, 0, MXC_CCM_CCGR4, MXC_CCM_CCGRx_CG3_OFFSET, NULL, NULL, &mipi_hsc2_clk, &pll2_sw_clk);
@@ -1468,6 +1476,9 @@ static struct clk_lookup mx53_lookups[] = {
_REGISTER_CLOCK("imx53-cspi.0", NULL, cspi_clk)
_REGISTER_CLOCK("imx2-wdt.0", NULL, dummy_clk)
_REGISTER_CLOCK("imx2-wdt.1", NULL, dummy_clk)
+ _REGISTER_CLOCK("ahci.0", NULL, sata_clk)
+ _REGISTER_CLOCK(NULL, "usb_phy1", usb_phy1_clk)
+ _REGISTER_CLOCK(NULL, "ahb", ahb_clk)
};
static void clk_tree_init(void)
diff --git a/arch/arm/mach-mx5/devices-imx53.h b/arch/arm/mach-mx5/devices-imx53.h
index 9251008..09ebb43 100644
--- a/arch/arm/mach-mx5/devices-imx53.h
+++ b/arch/arm/mach-mx5/devices-imx53.h
@@ -33,3 +33,7 @@ extern const struct imx_spi_imx_data imx53_ecspi_data[] __initconst;
extern const struct imx_imx2_wdt_data imx53_imx2_wdt_data[] __initconst;
#define imx53_add_imx2_wdt(id, pdata) \
imx_add_imx2_wdt(&imx53_imx2_wdt_data[id])
+
+extern const struct imx_ahci_imx_data imx53_ahci_imx_data[] __initconst;
+#define imx53_add_ahci_imx(id, pdata) \
+ imx_add_ahci_imx(&imx53_ahci_imx_data[id], pdata)
diff --git a/arch/arm/plat-mxc/devices/Kconfig b/arch/arm/plat-mxc/devices/Kconfig
index b9ab1d5..087595a 100644
--- a/arch/arm/plat-mxc/devices/Kconfig
+++ b/arch/arm/plat-mxc/devices/Kconfig
@@ -71,3 +71,7 @@ config IMX_HAVE_PLATFORM_SDHCI_ESDHC_IMX
config IMX_HAVE_PLATFORM_SPI_IMX
bool
+
+config IMX_HAVE_PLATFORM_SATA_AHCI
+ bool
+ default y if SOC_IMX53
diff --git a/arch/arm/plat-mxc/devices/Makefile b/arch/arm/plat-mxc/devices/Makefile
index 75cd2ec..e0b7fa3 100644
--- a/arch/arm/plat-mxc/devices/Makefile
+++ b/arch/arm/plat-mxc/devices/Makefile
@@ -22,3 +22,4 @@ obj-$(CONFIG_IMX_HAVE_PLATFORM_MXC_RNGA) += platform-mxc_rnga.o
obj-$(CONFIG_IMX_HAVE_PLATFORM_MXC_W1) += platform-mxc_w1.o
obj-$(CONFIG_IMX_HAVE_PLATFORM_SDHCI_ESDHC_IMX) += platform-sdhci-esdhc-imx.o
obj-$(CONFIG_IMX_HAVE_PLATFORM_SPI_IMX) += platform-spi_imx.o
+obj-$(CONFIG_IMX_HAVE_PLATFORM_SATA_AHCI) += platform-ahci-imx.o
diff --git a/arch/arm/plat-mxc/devices/platform-ahci-imx.c b/arch/arm/plat-mxc/devices/platform-ahci-imx.c
new file mode 100644
index 0000000..6ef3a91
--- /dev/null
+++ b/arch/arm/plat-mxc/devices/platform-ahci-imx.c
@@ -0,0 +1,109 @@
+/*
+ * Copyright (C) 2011 Freescale Semiconductor, Inc. All Rights Reserved.
+ */
+
+/*
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+
+ * You should have received a copy of the GNU General Public License along
+ * with this program; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+ */
+
+#include <asm/sizes.h>
+#include <mach/hardware.h>
+#include <mach/devices-common.h>
+
+#include <linux/clk.h>
+
+#define imx_ahci_data_entry_single(soc) \
+ { \
+ .iobase = soc ## _SATA_BASE_ADDR, \
+ .irq = soc ## _INT_SATA, \
+ }
+
+#ifdef CONFIG_SOC_IMX53
+const struct imx_ahci_imx_data imx53_ahci_imx_data __initconst =
+ imx_ahci_data_entry_single(MX53);
+#endif
+
+struct platform_device *__init imx_add_ahci_imx(
+ const struct imx_ahci_imx_data *data,
+ const struct ahci_platform_data *pdata)
+{
+ struct resource res[] = {
+ {
+ .start = data->iobase,
+ .end = data->iobase + SZ_4K - 1,
+ .flags = IORESOURCE_MEM,
+ }, {
+ .start = data->irq,
+ .end = data->irq,
+ .flags = IORESOURCE_IRQ,
+ },
+ };
+
+ return imx_add_platform_device_dmamask("ahci", 0,
+ res, ARRAY_SIZE(res),
+ pdata, sizeof(*pdata), DMA_BIT_MASK(32));
+}
+
+/*****************************************************************************\
+ * *
+ * FSL AHCI SATA low level functions *
+ * return value 0 success *
+ * *
+\*****************************************************************************/
+
+int internal_clk_initialization(struct device *dev)
+{
+ int ret = 0;
+ struct ahci_platform_data *pdata = dev->platform_data;
+
+ pdata->sata_ref_clk = clk_get(NULL, "usb_phy1");
+ if (IS_ERR(pdata->sata_ref_clk)) {
+ dev_err(dev, "IMX AHCI can't get SATA REF CLK.\n");
+ return PTR_ERR(pdata->sata_ref_clk);
+ }
+ ret = clk_enable(pdata->sata_ref_clk);
+ if (ret) {
+ dev_err(dev, "IMX AHCI Can't enable SATA REF CLK.\n");
+ clk_put(pdata->sata_ref_clk);
+ }
+
+ return ret;
+}
+
+void internal_clk_release(struct device *dev)
+{
+ struct ahci_platform_data *pdata = dev->platform_data;
+
+ clk_disable(pdata->sata_ref_clk);
+ clk_put(pdata->sata_ref_clk);
+}
+
+int external_clk_initialization(struct device *dev)
+{
+ /*
+ * Not initialized, should be implemented when external clk resource
+ * is used for IMX AHCI SATA.
+ */
+ return 0;
+}
+
+int external_clk_release(struct device *dev)
+{
+ /*
+ * Not initialized, should be implemented when external clk resource
+ * is used for IMX AHCI SATA.
+ */
+ return 0;
+}
diff --git a/arch/arm/plat-mxc/include/mach/ahci_sata.h b/arch/arm/plat-mxc/include/mach/ahci_sata.h
new file mode 100644
index 0000000..82a6618
--- /dev/null
+++ b/arch/arm/plat-mxc/include/mach/ahci_sata.h
@@ -0,0 +1,53 @@
+/*
+ * Copyright (C) 2011 Freescale Semiconductor, Inc. All Rights Reserved.
+ *
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License as published by the
+ * Free Software Foundation; either version 2 of the License, or (at your
+ * option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
+ * or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+ * for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ */
+
+#ifndef __PLAT_MXC_AHCI_SATA_H__
+#define __PLAT_MXC_AHCI_SATA_H__
+
+enum {
+ HOST_CAP = 0x00,
+ HOST_CAP_SSS = (1 << 27), /* Staggered Spin-up */
+ HOST_PORTS_IMPL = 0x0c,
+ HOST_TIMER1MS = 0xe0, /* Timer 1-ms */
+ /* Offest used to control the MPLL input clk */
+ PHY_CR_CLOCK_FREQ_OVRD = 0x12,
+ /* Port0 SATA Status */
+ PORT_SATA_SR = 0x128,
+ /* Port0 PHY Control */
+ PORT_PHY_CTL = 0x178,
+ /* PORT_PHY_CTL bits */
+ PORT_PHY_CTL_CAP_ADR_LOC = 0x10000,
+ PORT_PHY_CTL_CAP_DAT_LOC = 0x20000,
+ PORT_PHY_CTL_WRITE_LOC = 0x40000,
+ PORT_PHY_CTL_READ_LOC = 0x80000,
+ /* Port0 PHY Status */
+ PORT_PHY_SR = 0x17c,
+ /* PORT_PHY_SR */
+ PORT_PHY_STAT_DATA_LOC = 0,
+ PORT_PHY_STAT_ACK_LOC = 18,
+ /* SATA PHY Register */
+ SATA_PHY_CR_CLOCK_CRCMP_LT_LIMIT = 0x0001,
+ SATA_PHY_CR_CLOCK_DAC_CTL = 0x0008,
+ SATA_PHY_CR_CLOCK_RTUNE_CTL = 0x0009,
+ SATA_PHY_CR_CLOCK_ADC_OUT = 0x000A,
+ SATA_PHY_CR_CLOCK_MPLL_TST = 0x0017,
+};
+
+extern int internal_clk_initialization(struct device *dev);
+extern void internal_clk_release(struct device *dev);
+#endif /* __PLAT_MXC_AHCI_SATA_H__ */
diff --git a/arch/arm/plat-mxc/include/mach/devices-common.h b/arch/arm/plat-mxc/include/mach/devices-common.h
index 8658c9c..81baca6 100644
--- a/arch/arm/plat-mxc/include/mach/devices-common.h
+++ b/arch/arm/plat-mxc/include/mach/devices-common.h
@@ -264,3 +264,13 @@ struct imx_spi_imx_data {
struct platform_device *__init imx_add_spi_imx(
const struct imx_spi_imx_data *data,
const struct spi_imx_master *pdata);
+
+#include <linux/ahci_platform.h>
+struct imx_ahci_imx_data {
+ int id;
+ resource_size_t iobase;
+ resource_size_t irq;
+};
+struct platform_device *__init imx_add_ahci_imx(
+ const struct imx_ahci_imx_data *data,
+ const struct ahci_platform_data *pdata);
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH V1 3/3] MX53 Enable the AHCI SATA on MX53 LOCO
2011-03-17 7:10 [PATCH V1 1/3] ahci_platform: add two clk pointer member into ahci_platform_data struct Richard Zhu
2011-03-17 7:10 ` [PATCH V1 2/3] AHCI Add the AHCI SATA feature on MX53 platforms Richard Zhu
@ 2011-03-17 7:11 ` Richard Zhu
2011-03-17 8:37 ` [PATCH V1 1/3] ahci_platform: add two clk pointer member into ahci_platform_data struct Sascha Hauer
2 siblings, 0 replies; 6+ messages in thread
From: Richard Zhu @ 2011-03-17 7:11 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Richard Zhu <Hong-Xing.Zhu@freescale.com>
---
arch/arm/mach-mx5/board-mx53_loco.c | 78 +++++++++++++++++++++++++++++++++++
1 files changed, 78 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-mx5/board-mx53_loco.c b/arch/arm/mach-mx5/board-mx53_loco.c
index 0a18f8d..4c00033 100644
--- a/arch/arm/mach-mx5/board-mx53_loco.c
+++ b/arch/arm/mach-mx5/board-mx53_loco.c
@@ -23,11 +23,13 @@
#include <linux/fec.h>
#include <linux/delay.h>
#include <linux/gpio.h>
+#include <linux/ahci_platform.h>
#include <mach/common.h>
#include <mach/hardware.h>
#include <mach/imx-uart.h>
#include <mach/iomux-mx53.h>
+#include <mach/ahci_sata.h>
#include <asm/mach-types.h>
#include <asm/mach/arch.h>
@@ -203,6 +205,81 @@ static const struct imxi2c_platform_data mx53_loco_i2c_data __initconst = {
.bitrate = 100000,
};
+/* HW Initialization, if return 0, initialization is successful. */
+static int sata_init(struct device *dev, void __iomem *addr)
+{
+ int ret = 0;
+ u32 tmpdata;
+ struct clk *clk;
+ struct ahci_platform_data *pdata = dev->platform_data;
+
+ pdata->sata_clk = clk_get(dev, NULL);
+ if (IS_ERR(pdata->sata_clk)) {
+ dev_err(dev, "IMX AHCI can't get sata clock.\n");
+ return PTR_ERR(pdata->sata_clk);
+ }
+ ret = clk_enable(pdata->sata_clk);
+ if (ret) {
+ dev_err(dev, "IMX AHCI can't enable sata clock.\n");
+ clk_put(pdata->sata_clk);
+ return ret;
+ }
+
+ /* FSL IMX AHCI SATA uses the internal usb phy1 clk on loco */
+ if (internal_clk_initialization(dev))
+ goto release_sata_clk;
+
+ /* Get the AHB clock rate, and configure the TIMER1MS reg later */
+ clk = clk_get(NULL, "ahb");
+ if (IS_ERR(clk)) {
+ dev_err(dev, "IMX AHCI can't get AHB clock.\n");
+ ret = PTR_ERR(clk);
+ goto release_sata_ref_clk;
+ }
+
+ tmpdata = readl(addr + HOST_CAP);
+ if (!(tmpdata & HOST_CAP_SSS)) {
+ tmpdata |= HOST_CAP_SSS;
+ writel(tmpdata, addr + HOST_CAP);
+ }
+
+ if (!(readl(addr + HOST_PORTS_IMPL) & 0x1))
+ writel((readl(addr + HOST_PORTS_IMPL) | 0x1),
+ addr + HOST_PORTS_IMPL);
+
+ tmpdata = clk_get_rate(clk) / 1000;
+ clk_put(clk);
+ writel(tmpdata, addr + HOST_TIMER1MS);
+
+ clk = NULL;
+ return ret;
+
+release_sata_ref_clk:
+ internal_clk_release(dev);
+
+release_sata_clk:
+ clk_disable(pdata->sata_clk);
+ clk_put(pdata->sata_clk);
+
+ clk = NULL;
+ return ret;
+}
+
+static void sata_exit(struct device *dev)
+{
+ struct ahci_platform_data *pdata = dev->platform_data;
+
+ internal_clk_release(dev);
+
+ clk_disable(pdata->sata_clk);
+ clk_put(pdata->sata_clk);
+}
+
+static struct ahci_platform_data sata_data = {
+ .init = sata_init,
+ .exit = sata_exit,
+};
+
static void __init mx53_loco_board_init(void)
{
mxc_iomux_v3_setup_multiple_pads(mx53_loco_pads,
@@ -215,6 +292,7 @@ static void __init mx53_loco_board_init(void)
imx53_add_imx_i2c(1, &mx53_loco_i2c_data);
imx53_add_sdhci_esdhc_imx(0, NULL);
imx53_add_sdhci_esdhc_imx(2, NULL);
+ imx53_add_ahci_imx(0, &sata_data);
}
static void __init mx53_loco_timer_init(void)
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH V1 1/3] ahci_platform: add two clk pointer member into ahci_platform_data struct
2011-03-17 7:10 [PATCH V1 1/3] ahci_platform: add two clk pointer member into ahci_platform_data struct Richard Zhu
2011-03-17 7:10 ` [PATCH V1 2/3] AHCI Add the AHCI SATA feature on MX53 platforms Richard Zhu
2011-03-17 7:11 ` [PATCH V1 3/3] MX53 Enable the AHCI SATA on MX53 LOCO Richard Zhu
@ 2011-03-17 8:37 ` Sascha Hauer
2011-03-17 9:48 ` Zhu Richard-R65037
2 siblings, 1 reply; 6+ messages in thread
From: Sascha Hauer @ 2011-03-17 8:37 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Mar 17, 2011 at 03:10:58PM +0800, Richard Zhu wrote:
> Signed-off-by: Richard Zhu <Hong-Xing.Zhu@freescale.com>
> ---
> include/linux/ahci_platform.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/ahci_platform.h b/include/linux/ahci_platform.h
> index be3d9a7..86b5e24 100644
> --- a/include/linux/ahci_platform.h
> +++ b/include/linux/ahci_platform.h
> @@ -26,6 +26,8 @@ struct ahci_platform_data {
> const struct ata_port_info *ata_port_info;
> unsigned int force_port_map;
> unsigned int mask_port_map;
> + struct clk *sata_clk;
> + struct clk *sata_ref_clk;
No, ahci_platform_data shouldn't be the dump place for arbitrary board
data. Keep this to your board.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH V1 2/3] AHCI Add the AHCI SATA feature on MX53 platforms
2011-03-17 7:10 ` [PATCH V1 2/3] AHCI Add the AHCI SATA feature on MX53 platforms Richard Zhu
@ 2011-03-17 8:55 ` Sascha Hauer
0 siblings, 0 replies; 6+ messages in thread
From: Sascha Hauer @ 2011-03-17 8:55 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Mar 17, 2011 at 03:10:59PM +0800, Richard Zhu wrote:
> Signed-off-by: Richard Zhu <Hong-Xing.Zhu@freescale.com>
> ---
> arch/arm/mach-mx5/clock-mx51-mx53.c | 11 +++
> arch/arm/mach-mx5/devices-imx53.h | 4 +
> arch/arm/plat-mxc/devices/Kconfig | 4 +
> arch/arm/plat-mxc/devices/Makefile | 1 +
> arch/arm/plat-mxc/devices/platform-ahci-imx.c | 109 +++++++++++++++++++++++
> arch/arm/plat-mxc/include/mach/ahci_sata.h | 53 +++++++++++
> arch/arm/plat-mxc/include/mach/devices-common.h | 10 ++
> 7 files changed, 192 insertions(+), 0 deletions(-)
> create mode 100644 arch/arm/plat-mxc/devices/platform-ahci-imx.c
> create mode 100644 arch/arm/plat-mxc/include/mach/ahci_sata.h
>
> diff --git a/arch/arm/mach-mx5/clock-mx51-mx53.c b/arch/arm/mach-mx5/clock-mx51-mx53.c
> index 652ace4..8bf2bab 100644
> --- a/arch/arm/mach-mx5/clock-mx51-mx53.c
> +++ b/arch/arm/mach-mx5/clock-mx51-mx53.c
> @@ -1380,6 +1380,14 @@ static struct clk esdhc4_mx53_clk = {
> .secondary = &esdhc4_ipg_clk,
> };
>
> +static struct clk sata_clk = {
> + .parent = &ipg_clk,
> + .enable = _clk_max_enable,
> + .enable_reg = MXC_CCM_CCGR4,
> + .enable_shift = MXC_CCM_CCGRx_CG1_OFFSET,
> + .disable = _clk_max_disable,
> +};
> +
> DEFINE_CLOCK(mipi_esc_clk, 0, MXC_CCM_CCGR4, MXC_CCM_CCGRx_CG5_OFFSET, NULL, NULL, NULL, &pll2_sw_clk);
> DEFINE_CLOCK(mipi_hsc2_clk, 0, MXC_CCM_CCGR4, MXC_CCM_CCGRx_CG4_OFFSET, NULL, NULL, &mipi_esc_clk, &pll2_sw_clk);
> DEFINE_CLOCK(mipi_hsc1_clk, 0, MXC_CCM_CCGR4, MXC_CCM_CCGRx_CG3_OFFSET, NULL, NULL, &mipi_hsc2_clk, &pll2_sw_clk);
> @@ -1468,6 +1476,9 @@ static struct clk_lookup mx53_lookups[] = {
> _REGISTER_CLOCK("imx53-cspi.0", NULL, cspi_clk)
> _REGISTER_CLOCK("imx2-wdt.0", NULL, dummy_clk)
> _REGISTER_CLOCK("imx2-wdt.1", NULL, dummy_clk)
> + _REGISTER_CLOCK("ahci.0", NULL, sata_clk)
> + _REGISTER_CLOCK(NULL, "usb_phy1", usb_phy1_clk)
> + _REGISTER_CLOCK(NULL, "ahb", ahb_clk)
> };
>
> static void clk_tree_init(void)
> diff --git a/arch/arm/mach-mx5/devices-imx53.h b/arch/arm/mach-mx5/devices-imx53.h
> index 9251008..09ebb43 100644
> --- a/arch/arm/mach-mx5/devices-imx53.h
> +++ b/arch/arm/mach-mx5/devices-imx53.h
> @@ -33,3 +33,7 @@ extern const struct imx_spi_imx_data imx53_ecspi_data[] __initconst;
> extern const struct imx_imx2_wdt_data imx53_imx2_wdt_data[] __initconst;
> #define imx53_add_imx2_wdt(id, pdata) \
> imx_add_imx2_wdt(&imx53_imx2_wdt_data[id])
> +
> +extern const struct imx_ahci_imx_data imx53_ahci_imx_data[] __initconst;
> +#define imx53_add_ahci_imx(id, pdata) \
> + imx_add_ahci_imx(&imx53_ahci_imx_data[id], pdata)
> diff --git a/arch/arm/plat-mxc/devices/Kconfig b/arch/arm/plat-mxc/devices/Kconfig
> index b9ab1d5..087595a 100644
> --- a/arch/arm/plat-mxc/devices/Kconfig
> +++ b/arch/arm/plat-mxc/devices/Kconfig
> @@ -71,3 +71,7 @@ config IMX_HAVE_PLATFORM_SDHCI_ESDHC_IMX
>
> config IMX_HAVE_PLATFORM_SPI_IMX
> bool
> +
> +config IMX_HAVE_PLATFORM_SATA_AHCI
> + bool
> + default y if SOC_IMX53
> diff --git a/arch/arm/plat-mxc/devices/Makefile b/arch/arm/plat-mxc/devices/Makefile
> index 75cd2ec..e0b7fa3 100644
> --- a/arch/arm/plat-mxc/devices/Makefile
> +++ b/arch/arm/plat-mxc/devices/Makefile
> @@ -22,3 +22,4 @@ obj-$(CONFIG_IMX_HAVE_PLATFORM_MXC_RNGA) += platform-mxc_rnga.o
> obj-$(CONFIG_IMX_HAVE_PLATFORM_MXC_W1) += platform-mxc_w1.o
> obj-$(CONFIG_IMX_HAVE_PLATFORM_SDHCI_ESDHC_IMX) += platform-sdhci-esdhc-imx.o
> obj-$(CONFIG_IMX_HAVE_PLATFORM_SPI_IMX) += platform-spi_imx.o
> +obj-$(CONFIG_IMX_HAVE_PLATFORM_SATA_AHCI) += platform-ahci-imx.o
> diff --git a/arch/arm/plat-mxc/devices/platform-ahci-imx.c b/arch/arm/plat-mxc/devices/platform-ahci-imx.c
> new file mode 100644
> index 0000000..6ef3a91
> --- /dev/null
> +++ b/arch/arm/plat-mxc/devices/platform-ahci-imx.c
> @@ -0,0 +1,109 @@
> +/*
> + * Copyright (C) 2011 Freescale Semiconductor, Inc. All Rights Reserved.
> + */
> +
> +/*
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> +
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> +
> + * You should have received a copy of the GNU General Public License along
> + * with this program; if not, write to the Free Software Foundation, Inc.,
> + * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
> + */
> +
> +#include <asm/sizes.h>
> +#include <mach/hardware.h>
> +#include <mach/devices-common.h>
> +
> +#include <linux/clk.h>
> +
> +#define imx_ahci_data_entry_single(soc) \
> + { \
> + .iobase = soc ## _SATA_BASE_ADDR, \
> + .irq = soc ## _INT_SATA, \
> + }
> +
> +#ifdef CONFIG_SOC_IMX53
> +const struct imx_ahci_imx_data imx53_ahci_imx_data __initconst =
> + imx_ahci_data_entry_single(MX53);
> +#endif
> +
> +struct platform_device *__init imx_add_ahci_imx(
> + const struct imx_ahci_imx_data *data,
> + const struct ahci_platform_data *pdata)
> +{
> + struct resource res[] = {
> + {
> + .start = data->iobase,
> + .end = data->iobase + SZ_4K - 1,
> + .flags = IORESOURCE_MEM,
> + }, {
> + .start = data->irq,
> + .end = data->irq,
> + .flags = IORESOURCE_IRQ,
> + },
> + };
> +
> + return imx_add_platform_device_dmamask("ahci", 0,
> + res, ARRAY_SIZE(res),
> + pdata, sizeof(*pdata), DMA_BIT_MASK(32));
> +}
> +
> +/*****************************************************************************\
> + * *
> + * FSL AHCI SATA low level functions *
> + * return value 0 success *
> + * *
> +\*****************************************************************************/
> +
> +int internal_clk_initialization(struct device *dev)
Step back. Imagine you awake at morning and stumble upon a function with
this name. Would this name give you a hint what it's good for? You
should use your time to give functions a descriptive name rather than
doing ascii art in comments.
> +{
> + int ret = 0;
> + struct ahci_platform_data *pdata = dev->platform_data;
> +
> + pdata->sata_ref_clk = clk_get(NULL, "usb_phy1");
> + if (IS_ERR(pdata->sata_ref_clk)) {
> + dev_err(dev, "IMX AHCI can't get SATA REF CLK.\n");
The dev_* functions have been introduced to give printk a context. So
you don't need to repeat it in your string.
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH V1 1/3] ahci_platform: add two clk pointer member into ahci_platform_data struct
2011-03-17 8:37 ` [PATCH V1 1/3] ahci_platform: add two clk pointer member into ahci_platform_data struct Sascha Hauer
@ 2011-03-17 9:48 ` Zhu Richard-R65037
0 siblings, 0 replies; 6+ messages in thread
From: Zhu Richard-R65037 @ 2011-03-17 9:48 UTC (permalink / raw)
To: linux-arm-kernel
Hi Sascha:
Thanks for your comments.
Best Regards
Richard Zhu
> -----Original Message-----
> From: Sascha Hauer [mailto:s.hauer at pengutronix.de]
> Sent: Thursday, March 17, 2011 4:37 PM
> To: Zhu Richard-R65037
> Cc: linux-arm-kernel at lists.infradead.org; jgarzik at pobox.com;
> kernel at pengutronix.de; linux-ide at vger.kernel.org;
> avorontsov at ru.mvista.com; eric at eukrea.com; eric.miao at linaro.org
> Subject: Re: [PATCH V1 1/3] ahci_platform: add two clk pointer member
> into ahci_platform_data struct
>
> On Thu, Mar 17, 2011 at 03:10:58PM +0800, Richard Zhu wrote:
> > Signed-off-by: Richard Zhu <Hong-Xing.Zhu@freescale.com>
> > ---
> > include/linux/ahci_platform.h | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/include/linux/ahci_platform.h
> > b/include/linux/ahci_platform.h index be3d9a7..86b5e24 100644
> > --- a/include/linux/ahci_platform.h
> > +++ b/include/linux/ahci_platform.h
> > @@ -26,6 +26,8 @@ struct ahci_platform_data {
> > const struct ata_port_info *ata_port_info;
> > unsigned int force_port_map;
> > unsigned int mask_port_map;
> > + struct clk *sata_clk;
> > + struct clk *sata_ref_clk;
>
> No, ahci_platform_data shouldn't be the dump place for arbitrary board
> data. Keep this to your board.
Accepted, these modifications would be discarded.
>
> Sascha
>
> --
> Pengutronix e.K. |
> |
> Industrial Linux Solutions | http://www.pengutronix.de/
> |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0
> |
> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555
> |
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-03-17 9:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-17 7:10 [PATCH V1 1/3] ahci_platform: add two clk pointer member into ahci_platform_data struct Richard Zhu
2011-03-17 7:10 ` [PATCH V1 2/3] AHCI Add the AHCI SATA feature on MX53 platforms Richard Zhu
2011-03-17 8:55 ` Sascha Hauer
2011-03-17 7:11 ` [PATCH V1 3/3] MX53 Enable the AHCI SATA on MX53 LOCO Richard Zhu
2011-03-17 8:37 ` [PATCH V1 1/3] ahci_platform: add two clk pointer member into ahci_platform_data struct Sascha Hauer
2011-03-17 9:48 ` Zhu Richard-R65037
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).