From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: Why don't we have atomic_set_mask()?
Date: Thu, 17 Mar 2011 12:07:48 +0000 [thread overview]
Message-ID: <20110317120748.GH29758@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <AANLkTi=V5mHHibKftXZ1A+s6xiuqH5X0pqYPMjZod6EV@mail.gmail.com>
On Thu, Mar 17, 2011 at 08:36:15PM +0900, KyongHo Cho wrote:
> arch/arm/asm/atomic.h defines atomic_clear_mask() but its counterpart,
> atomic_set_mask() is not defined.
Nothing other than some s390 drivers seems to use it, so I'd say no.
I also feel that atomic_xxx() is over-used, many times in inappropriate
and buggy ways.
If you want to manipulate bitmasks or bitmaps, then imho you should be
using the bitops or bitmap support rather than atomic stuff.
next prev parent reply other threads:[~2011-03-17 12:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 11:36 Why don't we have atomic_set_mask()? KyongHo Cho
2011-03-17 12:07 ` Russell King - ARM Linux [this message]
2011-03-17 13:25 ` Detlef Vollmann
2011-03-17 12:09 ` Russell King - ARM Linux
2011-03-17 12:24 ` KyongHo Cho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110317120748.GH29758@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox