From mboxrd@z Thu Jan  1 00:00:00 1970
From: wim@iguana.be (Wim Van Sebroeck)
Date: Fri, 18 Mar 2011 09:11:40 +0100
Subject: [PATCH 1/2] drivers/watchdog/s3c2410_wdt.c: Convert
	release_resource to release_region/release_mem_region
In-Reply-To: <Pine.LNX.4.64.1102281110090.14560@pc-004.diku.dk>
References: <1298738079-28893-1-git-send-email-julia@diku.dk>
	<002e01cbd72f$448ac150$cda043f0$%kim@samsung.com>
	<Pine.LNX.4.64.1102281110090.14560@pc-004.diku.dk>
Message-ID: <20110318081140.GS1751@infomag.iguana.be>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

Hi Julia, Kukjin Kim,

> > Hmm...I think, 'res' is better for platform_get_resource().
> > Do we _really_ need to change the name?...
> 
> wdt_mem is a global variable.  Is res a good name for a global variable?  
> One could say wdt_mem = res, if that seems better.

If you look at the code then you have:
static struct resource  *wdt_mem;
static struct resource  *wdt_irq;

and in the probe function you have:
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
	...
	wdt_mem = request_mem_region(res->start, size, pdev->name);
	...
	wdt_irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);

So doing Julia's:
	wdt_mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
	...
	if (!request_mem_region(wdt_mem->start, size, pdev->name)) {
	...
	wdt_irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0)

seems the best solution to me (since you then have both resources being polulated via platform_get_resource(pdev,... ).

Kind regards,
Wim.