From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V7 4/4] mmc: sdhci-esdhc: enable esdhc on imx53
Date: Mon, 21 Mar 2011 14:08:44 +0100 [thread overview]
Message-ID: <20110321130844.GG9686@pengutronix.de> (raw)
In-Reply-To: <1300684936-8218-5-git-send-email-Hong-Xing.Zhu@freescale.com>
On Mon, Mar 21, 2011 at 01:22:16PM +0800, Richard Zhu wrote:
> Fix the NO INT in the Multi-BLK IO in SD/MMC, and Multi-BLK
> read in SDIO on imx53.
>
> The CMDTYPE of the CMD register (offset 0xE) should be set to
> "11" when the STOP CMD12 is issued on imx53 to abort one
> open ended multi-blk IO. Otherwise one the TC INT wouldn't
> be generated.
>
> In exact block transfer, the controller doesn't complete the
> operations automatically as required at the end of the
> transfer and remains on hold if the abort command is not sent on
> imx53.
> As a result, the TC flag is not asserted and SW received timeout
> exeception. set bit1 of Vendor Spec registor to fix it.
>
> Signed-off-by: Richard Zhu <Hong-Xing.Zhu@freescale.com>
> Signed-off-by: Richard Zhao <richard.zhao@freescale.com>
Reviewed-by: Wolfram Sang <w.sang@pengutronix.de>
I am still wondering if one of the fixes could be handled at core level,
but I don't have hardware to test. But I may be wrong, so this is good
enough for now to go in IMO.
Thanks,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110321/7accab93/attachment.sig>
next prev parent reply other threads:[~2011-03-21 13:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-21 5:22 [PATCH V7 0/4] mmc: one comment is missing addressed Richard Zhu
2011-03-21 5:22 ` [PATCH V7 1/4] mmc: sdhci-esdhc: remove SDHCI_QUIRK_NO_CARD_NO_RESET from ESDHC_DEFAULT_QUIRKS Richard Zhu
2011-03-21 5:22 ` [PATCH V7 2/4] mmc: add the abort CMDTYE bits definition Richard Zhu
2011-03-21 5:22 ` [PATCH V7 3/4] mmc: sdhci-esdhc: make the writel/readl as the general APIs Richard Zhu
2011-03-21 13:06 ` Wolfram Sang
2011-03-24 23:14 ` Chris Ball
2011-03-21 5:22 ` [PATCH V7 4/4] mmc: sdhci-esdhc: enable esdhc on imx53 Richard Zhu
2011-03-21 13:08 ` Wolfram Sang [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-03-21 3:32 [PATCH V7 0/4] mmc: one comment is missing addressed in the previous review Richard Zhu
2011-03-21 3:32 ` [PATCH V7 4/4] mmc: sdhci-esdhc: enable esdhc on imx53 Richard Zhu
2011-03-18 9:56 [PATCH V7 1/4] mmc: sdhci-esdhc: remove SDHCI_QUIRK_NO_CARD_NO_RESET from ESDHC_DEFAULT_QUIRKS Richard Zhu
2011-03-18 9:56 ` [PATCH V7 4/4] mmc: sdhci-esdhc: enable esdhc on imx53 Richard Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110321130844.GG9686@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).