linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: multiple definition of show_mem for pxa
Date: Wed, 23 Mar 2011 20:03:53 +0000	[thread overview]
Message-ID: <20110323200353.GA9844@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <4D89F000.1070509@cam.ac.uk>

On Wed, Mar 23, 2011 at 01:05:04PM +0000, Jonathan Cameron wrote:
> Hi all
> 
> Can't immediately track down what changed to cause this issue, but
> building with current mainline is giving me:
> 
> lib/lib.a(show_mem.o): In function `show_mem':
> show_mem.c:(.text+0x13c): multiple definition of `show_mem'
> arch/arm/mm/built-in.o:copypage-xscale.c:(.text+0xfcc): first defined here
> make: *** [vmlinux.o] Error 1
> 
> 
> Anyone know what caused this?
> 
> There are indeed two versions of mem_info, the generic one and one
> in arch/arm/mm/init.c but I think they have both been around for
> some time without issue.

The generic one doesn't work on ARM, and it's supposed to override the
generic one.  It seems that ddd588b5dd55f14320379961e47683db4e4c1d90
causes the generic one to be pulled in due to a reference to __show_mem()
which then causes show_mem() to be defined twice.

The change in lib/show_mem.c needs to also be ported to ARMs own version.

      reply	other threads:[~2011-03-23 20:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-23 13:05 multiple definition of show_mem for pxa Jonathan Cameron
2011-03-23 20:03 ` Russell King - ARM Linux [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110323200353.GA9844@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).