From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] leds: leds-regulator.c, fix handling already enabled regulators
Date: Wed, 23 Mar 2011 21:21:10 +0000 [thread overview]
Message-ID: <20110323212110.GA26862@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1300914002-17760-1-git-send-email-ospite@studenti.unina.it>
On Wed, Mar 23, 2011 at 10:00:02PM +0100, Antonio Ospite wrote:
> The leds-regulator driver was ignoring the initial status of the
> regulator; this resulted in rdev->use_count incremented up to 2 after
> calling regulator_led_set_value() in the .probe method when a regulator
> was already enabled at insmod time, and this made impossible to ever
> disable the regulator.
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> NOTE: initially I thought about CC-ing stable at kernel.org as well on
> this, as it is an actual fix, but then I checked that there are
> currently no users of the driver in mainline linux and I dropped it, is
> that how it should be?
Even if there's no users in mainline people could well be shipping out
of tree boards using it and could benefit from the code. OTOH it's not
the most urgent thing ever.
prev parent reply other threads:[~2011-03-23 21:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 21:00 [PATCH] leds: leds-regulator.c, fix handling already enabled regulators Antonio Ospite
2011-03-23 21:21 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110323212110.GA26862@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).