linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH resend] ARM: mx51_efika: fix build error due to new mfd changes
@ 2011-03-29  0:22 Andres Salomon
  2011-03-29  0:47 ` Fabio Estevam
  0 siblings, 1 reply; 3+ messages in thread
From: Andres Salomon @ 2011-03-29  0:22 UTC (permalink / raw)
  To: linux-arm-kernel


MFD changes in 4ec1b54c ('mfd: mfd_cell is now implicitly available
to mc13xxx drivers') changed the mc13xxx_platform_data struct layout.
At the time all users were changed, but this driver was introduced in
another tree at the same time.  This updates the mc13xxx_platform_data
user, fixing a build error.

Signed-off-by: Andres Salomon <dilinger@queued.net>
---
 arch/arm/mach-mx5/mx51_efika.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-mx5/mx51_efika.c b/arch/arm/mach-mx5/mx51_efika.c
index 51a67fc..868af8f 100644
--- a/arch/arm/mach-mx5/mx51_efika.c
+++ b/arch/arm/mach-mx5/mx51_efika.c
@@ -572,8 +572,10 @@ static struct mc13xxx_regulator_init_data mx51_efika_regulators[] = {
 
 static struct mc13xxx_platform_data mx51_efika_mc13892_data = {
 	.flags = MC13XXX_USE_RTC | MC13XXX_USE_REGULATOR,
-	.num_regulators = ARRAY_SIZE(mx51_efika_regulators),
-	.regulators = mx51_efika_regulators,
+	.regulators = {
+		.num_regulators = ARRAY_SIZE(mx51_efika_regulators),
+		.regulators = mx51_efika_regulators,
+	},
 };
 
 static struct spi_board_info mx51_efika_spi_board_info[] __initdata = {
-- 
1.7.2.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH resend] ARM: mx51_efika: fix build error due to new mfd changes
  2011-03-29  0:22 [PATCH resend] ARM: mx51_efika: fix build error due to new mfd changes Andres Salomon
@ 2011-03-29  0:47 ` Fabio Estevam
  2011-03-29  0:52   ` Andres Salomon
  0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2011-03-29  0:47 UTC (permalink / raw)
  To: linux-arm-kernel

Andres,

On Mon, Mar 28, 2011 at 9:22 PM, Andres Salomon <dilinger@queued.net> wrote:
>
> MFD changes in 4ec1b54c ('mfd: mfd_cell is now implicitly available
> to mc13xxx drivers') changed the mc13xxx_platform_data struct layout.
> At the time all users were changed, but this driver was introduced in
> another tree at the same time. ?This updates the mc13xxx_platform_data
> user, fixing a build error.
>
> Signed-off-by: Andres Salomon <dilinger@queued.net>
> ---
> ?arch/arm/mach-mx5/mx51_efika.c | ? ?6 ++++--
> ?1 files changed, 4 insertions(+), 2 deletions(-)

Your patch is in Sascha?s tree now:
http://git.pengutronix.de/?p=imx/linux-2.6.git;a=commitdiff;h=251290a6078cb88382344b3ee535ae8c6254c1b5

Regards,

Fabio Estevam

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH resend] ARM: mx51_efika: fix build error due to new mfd changes
  2011-03-29  0:47 ` Fabio Estevam
@ 2011-03-29  0:52   ` Andres Salomon
  0 siblings, 0 replies; 3+ messages in thread
From: Andres Salomon @ 2011-03-29  0:52 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, 28 Mar 2011 21:47:58 -0300
Fabio Estevam <festevam@gmail.com> wrote:

> Andres,
> 
> On Mon, Mar 28, 2011 at 9:22 PM, Andres Salomon <dilinger@queued.net>
> wrote:
> >
> > MFD changes in 4ec1b54c ('mfd: mfd_cell is now implicitly available
> > to mc13xxx drivers') changed the mc13xxx_platform_data struct
> > layout. At the time all users were changed, but this driver was
> > introduced in another tree at the same time. ?This updates the
> > mc13xxx_platform_data user, fixing a build error.
> >
> > Signed-off-by: Andres Salomon <dilinger@queued.net>
> > ---
> > ?arch/arm/mach-mx5/mx51_efika.c | ? ?6 ++++--
> > ?1 files changed, 4 insertions(+), 2 deletions(-)
> 
> Your patch is in Sascha?s tree now:
> http://git.pengutronix.de/?p=imx/linux-2.6.git;a=commitdiff;h=251290a6078cb88382344b3ee535ae8c6254c1b5
> 
> Regards,
> 
> Fabio Estevam

Ah, thanks, I hadn't heard anything about it.  Linus, feel free to
ignore my patch.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-03-29  0:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-29  0:22 [PATCH resend] ARM: mx51_efika: fix build error due to new mfd changes Andres Salomon
2011-03-29  0:47 ` Fabio Estevam
2011-03-29  0:52   ` Andres Salomon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).