From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] ARM: dmabounce: fix dmabounce may cause crash issue
Date: Mon, 28 Mar 2011 18:58:58 +0100 [thread overview]
Message-ID: <20110328175858.GA31457@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <65EE16ACC360FA4D99C96DC085B3F77214AB97@039-SN1MPN1-001.039d.mgd.msft.net>
On Mon, Mar 28, 2011 at 05:01:31AM +0000, Dong Aisheng-B29396 wrote:
> But dma_map_single allows the 'dev' passed in to be NULL, so, may it be
> better to also check it for dmabounce in case such a using?
Programmers are lazy. They often have a struct device laying around
but they think they'll not bother passing it into the DMA API and
end up just passing NULL as that seems to work for them.
That doesn't mean it'll always work. The best thing is to always pass
in a struct device if there is one available.
I'm not saying don't for the dmabounce code. I'm saying _also_ fix the
driver.
next prev parent reply other threads:[~2011-03-28 17:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 11:16 [PATCH 1/1] ARM: dmabounce: fix dmabounce may cause crash issue Aisheng.Dong
2011-03-24 13:56 ` Mikael Pettersson
2011-03-28 4:48 ` Dong Aisheng-B29396
2011-03-25 8:36 ` Russell King - ARM Linux
2011-03-28 5:01 ` Dong Aisheng-B29396
2011-03-28 17:58 ` Russell King - ARM Linux [this message]
2011-03-29 3:04 ` Dong Aisheng-B29396
2011-03-30 10:53 ` Dong Aisheng-B29396
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110328175858.GA31457@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).