[PATCH 1/4] arm: lpc32xx: add tsc-device

[w.sang@pengutronix.de (Wolfram Sang)]

On Tue, Mar 29, 2011 at 06:43:45PM +0200, Kevin Wells wrote:
> Hi Wolfram,
> 
> Thanks for submitting these. These all look good!
> 
> > +/* TSC (Touch Screen Controller) */
> > +
> > +static struct resource lpc32xx_tsc_resources[] = {
> > +	{
> > +		.start = LPC32XX_ADC_BASE,
> > +		.end = LPC32XX_ADC_BASE + SZ_16K - 1,
> 
> The LPC32xx user's guide spaces peripheral register sets 16K apart,
> but internally the register blocks are 4K or smaller. I'm not sure
> why these need to be setup as 16K instead of 4K. Hmm, maybe I'm
> missing something here?

Probably not. I just took the user's guide as a reference. If you know this is
wrong, I can respin the series. ADC is also 4K?

Thanks,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110329/2ff4b7a1/attachment.sig>