From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] msm: board-8960: Add support for pm8921-regulator
Date: Thu, 31 Mar 2011 09:10:17 +0900 [thread overview]
Message-ID: <20110331001016.GB21487@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1301523466-6054-1-git-send-email-collinsd@codeaurora.org>
On Wed, Mar 30, 2011 at 03:17:46PM -0700, David Collins wrote:
> +VREG_CONSUMERS(L1) = {
> + REGULATOR_SUPPLY("8921_l1", NULL),
> +};
All these supplies named after the regulator name should be removed.
Supplies define the mapping from the regulators on the board to the
supplies on the devices on the board, if any driver is requesting a
specific regulator name then there's an abstraction issue which means
that these should be redundant.
In general if you've got a supply that doesn't have a dev_name
associated with it something is wrong.
next prev parent reply other threads:[~2011-03-31 0:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 22:16 [PATCH 0/2] regulator: msm: Add PM8921 regulator driver David Collins
2011-03-30 22:17 ` [PATCH 1/2] regulator: pm8921-regulator: Add regulator driver for PM8921 David Collins
2011-03-30 23:46 ` Mark Brown
2011-03-31 1:37 ` David Collins
2011-03-31 23:44 ` Mark Brown
2011-04-01 23:28 ` David Collins
2011-04-02 2:50 ` Mark Brown
2011-04-04 17:13 ` David Collins
2011-04-04 23:19 ` Mark Brown
2011-03-30 22:17 ` [PATCH 2/2] msm: board-8960: Add support for pm8921-regulator David Collins
2011-03-31 0:10 ` Mark Brown [this message]
2011-04-29 23:07 ` [PATCH v2 0/2] regulator: msm: Add PM8921 regulator driver David Collins
2011-04-29 23:09 ` [PATCH v2 1/2] regulator: pm8921-regulator: Add regulator driver for PM8921 David Collins
2011-04-29 23:11 ` [PATCH v2 2/2] msm: board-8960: Add support for pm8921-regulator David Collins
2011-05-03 16:08 ` Mark Brown
2011-05-03 9:48 ` [PATCH v2 0/2] regulator: msm: Add PM8921 regulator driver Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110331001016.GB21487@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).