public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] EP93xx: Remove ep93xx_gpio_dbg_show function
Date: Wed, 30 Mar 2011 22:01:47 -0600	[thread overview]
Message-ID: <20110331040147.GG21226@ponder.secretlab.ca> (raw)
In-Reply-To: <4D9113AA.20404@bluewatersys.com>

On Tue, Mar 29, 2011 at 12:03:06PM +1300, Ryan Mallon wrote:
> Hartley pointed out that the patch I posted to remove the irq internals
> fiddling from ep93xx_gpio_dbg_show does not function as expected. It
> will print [interrupt] beside all pins which are capable of being
> interrupts, not just those which are currently configured as interrupts.
> 
> The best solution is just to remove the custom ep93xx gpio debugfs
> function all together. The generic gpiolib one is good enough.
> 
> Signed-off-by: Ryan Mallon <ryan@bluewatersys.com>

Applied, thanks.

g.

> ---
> 
> diff --git a/arch/arm/mach-ep93xx/gpio.c b/arch/arm/mach-ep93xx/gpio.c
> index 34e071d..c74adf9 100644
> --- a/arch/arm/mach-ep93xx/gpio.c
> +++ b/arch/arm/mach-ep93xx/gpio.c
> @@ -348,29 +348,6 @@ static int ep93xx_gpio_set_debounce(struct gpio_chip *chip,
>  	return 0;
>  }
>  
> -static void ep93xx_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
> -{
> -	struct ep93xx_gpio_chip *ep93xx_chip = to_ep93xx_gpio_chip(chip);
> -	u8 data_reg, data_dir_reg;
> -	int gpio, i;
> -
> -	data_reg = __raw_readb(ep93xx_chip->data_reg);
> -	data_dir_reg = __raw_readb(ep93xx_chip->data_dir_reg);
> -
> -	gpio = ep93xx_chip->chip.base;
> -	for (i = 0; i < chip->ngpio; i++, gpio++) {
> -		int is_out = data_dir_reg & (1 << i);
> -		int irq = gpio_to_irq(gpio);
> -
> -		seq_printf(s, " %s%d gpio-%-3d (%-12s) %s %s %s\n",
> -				chip->label, i, gpio,
> -				gpiochip_is_requested(chip, i) ? : "",
> -				is_out ? "out" : "in ",
> -				(data_reg & (1<<  i)) ? "hi" : "lo",
> -				(!is_out && irq>= 0) ? "(interrupt)" : "");
> -	}
> -}
> -
>  #define EP93XX_GPIO_BANK(name, dr, ddr, base_gpio)			\
>  	{								\
>  		.chip = {						\
> @@ -379,7 +356,6 @@ static void ep93xx_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
>  			.direction_output = ep93xx_gpio_direction_output, \
>  			.get		  = ep93xx_gpio_get,		\
>  			.set		  = ep93xx_gpio_set,		\
> -			.dbg_show	  = ep93xx_gpio_dbg_show,	\
>  			.base		  = base_gpio,			\
>  			.ngpio		  = 8,				\
>  		},							\
> 

  parent reply	other threads:[~2011-03-31  4:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-28 23:03 [PATCH] EP93xx: Remove ep93xx_gpio_dbg_show function Ryan Mallon
2011-03-28 23:53 ` H Hartley Sweeten
2011-03-31  4:01 ` Grant Likely [this message]
2011-03-31  4:03   ` Ryan Mallon
2011-03-31  4:04     ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110331040147.GG21226@ponder.secretlab.ca \
    --to=grant.likely@secretlab.ca \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox