From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: RFC, GIC based smp_cross_call cleanup suggestion
Date: Sat, 2 Apr 2011 09:51:33 +0100 [thread overview]
Message-ID: <20110402085133.GE8482@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <BANLkTimY+mRXqT7NwUQ86SxnfKw0HX-pTQ@mail.gmail.com>
On Fri, Apr 01, 2011 at 04:55:02PM -0600, Grant Likely wrote:
> On Fri, Apr 1, 2011 at 4:26 PM, John Linn <John.Linn@xilinx.com> wrote:
> > I?m getting ready to submit a patch to add SMP to Xilinx code. I notice that
> > smp_cross_call for all GIC based platforms is duplicated across each
> > platform in smp.h.
> >
> >
> >
> > I thought I?d try to jump in to help with some cleanup, although I realize
> > it?s minimal, I have to start somewhere.
> >
> >
> >
> > What about moving the smp_cross_call for GIC based designs into gic.h?
>
> Go for it. It's an obvious cleanup.
That assumes that all SMP implementations will always have a GIC. It
looks to me like this is conditional on shmobile, and so I don't think
its that trivial - maybe Paul or Magnus can first indicate why this is.
next prev parent reply other threads:[~2011-04-02 8:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-01 22:27 RFC, GIC based smp_cross_call cleanup suggestion John Linn
2011-04-01 22:55 ` Grant Likely
2011-04-02 8:51 ` Russell King - ARM Linux [this message]
2011-04-02 9:10 ` Colin Cross
2011-04-03 4:47 ` Grant Likely
2011-04-03 10:37 ` Russell King - ARM Linux
2011-04-03 10:53 ` Santosh Shilimkar
2011-04-03 11:46 ` Russell King - ARM Linux
2011-04-03 12:00 ` Santosh Shilimkar
2011-04-03 13:48 ` Russell King - ARM Linux
2011-04-04 8:20 ` Santosh Shilimkar
2011-04-04 8:25 ` Russell King - ARM Linux
2011-04-04 8:33 ` Santosh Shilimkar
2011-04-03 21:15 ` John Linn
2011-04-04 8:30 ` Russell King - ARM Linux
2011-04-03 6:23 ` Santosh Shilimkar
2011-04-03 6:36 ` Colin Cross
2011-04-03 3:37 ` Magnus Damm
2011-04-03 10:03 ` Russell King - ARM Linux
2011-04-02 9:03 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110402085133.GE8482@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).