From: rubini@unipv.it (Alessandro Rubini)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: nomadik: avoid assigning u32 to bool
Date: Sat, 2 Apr 2011 23:19:54 +0200 [thread overview]
Message-ID: <20110402211954.GA22545@mail.gnudd.com> (raw)
In-Reply-To: <BANLkTikAG4diz-A6qfFx4cODvyR0c4oQ6g@mail.gmail.com>
>> - enabled = nmk_chip->enabled & bitmask;
>> + enabled = !!(nmk_chip->enabled & bitmask);
>
> I've learned to live this way of casting stuff into boolean,
I use (and love) !! since I learnt C. What I really dislike is the
concept of boolean that doesn't fit in the C way of thinking, in my opinion.
But I'm not going to change that.
Acked-by: Alessandro Rubini <rubini@unipv.it>
/alessandro
next prev parent reply other threads:[~2011-04-02 21:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-01 21:51 [PATCH] arm: nomadik: avoid assigning u32 to bool Nicolas Kaiser
2011-04-02 21:02 ` Linus Walleij
2011-04-02 21:19 ` Alessandro Rubini [this message]
2011-04-03 3:58 ` Rabin Vincent
2011-04-03 10:26 ` Nicolas Kaiser
2011-04-03 10:52 ` Alessandro Rubini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110402211954.GA22545@mail.gnudd.com \
--to=rubini@unipv.it \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).