From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: RFC, GIC based smp_cross_call cleanup suggestion
Date: Sun, 3 Apr 2011 12:46:10 +0100 [thread overview]
Message-ID: <20110403114610.GC4213@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <4D9851B5.20100@ti.com>
On Sun, Apr 03, 2011 at 04:23:41PM +0530, Santosh Shilimkar wrote:
> Sure, it does break OMAP4. These functions are there because they
> are used/compiled only for SMP support.
If they're only used privately within the mach-omap2 code, then putting
them in a header file in arch/arm/mach-omap2 would've been the logical
thing to do, rather than telling the entire SMP kernel about the
functions.
Header files in arch/arm/*/include/mach included from
arch/arm/include/asm/*.h are there to provide necessary definitions for
either the rest of the kernel or the ARM specific parts. They shouldn't
be polluted with *any* platform private stuff which is not absolutely
necessary to satisfy the rest of the kernel. Those mach/ includes
being:
mach/barriers.h
mach/clkdev.h
mach/floppy.h
mach/gpio.h
mach/hardware.h
mach/io.h
mach/irqs.h
mach/isa-dma.h
mach/memory.h
mach/mtd-xip.h
mach/smp.h
mach/timex.h
mach/vmalloc.h
next prev parent reply other threads:[~2011-04-03 11:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-01 22:27 RFC, GIC based smp_cross_call cleanup suggestion John Linn
2011-04-01 22:55 ` Grant Likely
2011-04-02 8:51 ` Russell King - ARM Linux
2011-04-02 9:10 ` Colin Cross
2011-04-03 4:47 ` Grant Likely
2011-04-03 10:37 ` Russell King - ARM Linux
2011-04-03 10:53 ` Santosh Shilimkar
2011-04-03 11:46 ` Russell King - ARM Linux [this message]
2011-04-03 12:00 ` Santosh Shilimkar
2011-04-03 13:48 ` Russell King - ARM Linux
2011-04-04 8:20 ` Santosh Shilimkar
2011-04-04 8:25 ` Russell King - ARM Linux
2011-04-04 8:33 ` Santosh Shilimkar
2011-04-03 21:15 ` John Linn
2011-04-04 8:30 ` Russell King - ARM Linux
2011-04-03 6:23 ` Santosh Shilimkar
2011-04-03 6:36 ` Colin Cross
2011-04-03 3:37 ` Magnus Damm
2011-04-03 10:03 ` Russell King - ARM Linux
2011-04-02 9:03 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110403114610.GC4213@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).