From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] Use gpio_set_value_cansleep() in corgi_lcd.c
Date: Mon, 4 Apr 2011 13:06:34 +0100 [thread overview]
Message-ID: <20110404120633.GB26494@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <BANLkTimtLsF_fQQbfxRQZ6ToBWj5HvGm6A@mail.gmail.com>
On Mon, Apr 04, 2011 at 06:45:46PM +0800, Eric Miao wrote:
> Personally, I don't quite like the idea of an explicit _cansleep() version,
> which is just confusing. A programmer shouldn't be aware of which
> version to use.
When working in interrupt context you need to pay attention to this
stuff; personally I'd prefer an explict IRQ safe version but YMMV. The
only use the code makes of this is to generate warnings to make problems
easier to diagnose.
> David, you have any justification?
Sadly David passed away recently.
next prev parent reply other threads:[~2011-04-04 12:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-02 1:43 [PATCH 1/3] sound/spitz: Properly handle MIC GPIO Marek Vasut
2011-04-02 1:43 ` [PATCH 2/3] Use gpio_set_value_cansleep() in corgi_lcd.c Marek Vasut
2011-04-04 10:45 ` Eric Miao
2011-04-04 12:06 ` Mark Brown [this message]
2011-04-04 12:33 ` Eric Miao
2011-04-04 12:44 ` Marek Vasut
2011-04-04 12:49 ` Russell King - ARM Linux
2011-04-04 12:52 ` Marek Vasut
2011-04-04 12:59 ` Russell King - ARM Linux
2011-04-10 7:58 ` Pavel Machek
2011-04-02 1:43 ` [PATCH 3/3] PXA: Reorganise pxa2xx_base init() function Marek Vasut
2011-04-03 13:18 ` [PATCH 1/3] sound/spitz: Properly handle MIC GPIO Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110404120633.GB26494@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).