linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] ARM: mx5/mx53_smd: Add esdhc support
@ 2011-04-04 12:32 Fabio Estevam
  2011-04-04 12:40 ` Wolfram Sang
  2011-04-04 16:00 ` Uwe Kleine-König
  0 siblings, 2 replies; 4+ messages in thread
From: Fabio Estevam @ 2011-04-04 12:32 UTC (permalink / raw)
  To: linux-arm-kernel

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v1:
- Do not use CD and WP detecion via GPIO as it is not working for MX53 yet.

 arch/arm/mach-mx5/board-mx53_smd.c |   28 ++++++++++++++++++++++++++++
 1 files changed, 28 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-mx5/board-mx53_smd.c b/arch/arm/mach-mx5/board-mx53_smd.c
index 31e1732..e510c27 100644
--- a/arch/arm/mach-mx5/board-mx53_smd.c
+++ b/arch/arm/mach-mx5/board-mx53_smd.c
@@ -52,6 +52,31 @@ static iomux_v3_cfg_t mx53_smd_pads[] = {
 	/* I2C1 */
 	MX53_PAD_CSI0_DAT8__I2C1_SDA,
 	MX53_PAD_CSI0_DAT9__I2C1_SCL,
+	/* SD1 */
+	MX53_PAD_SD1_CMD__ESDHC1_CMD,
+	MX53_PAD_SD1_CLK__ESDHC1_CLK,
+	MX53_PAD_SD1_DATA0__ESDHC1_DAT0,
+	MX53_PAD_SD1_DATA1__ESDHC1_DAT1,
+	MX53_PAD_SD1_DATA2__ESDHC1_DAT2,
+	MX53_PAD_SD1_DATA3__ESDHC1_DAT3,
+	/* SD2 */
+	MX53_PAD_SD2_CMD__ESDHC2_CMD,
+	MX53_PAD_SD2_CLK__ESDHC2_CLK,
+	MX53_PAD_SD2_DATA0__ESDHC2_DAT0,
+	MX53_PAD_SD2_DATA1__ESDHC2_DAT1,
+	MX53_PAD_SD2_DATA2__ESDHC2_DAT2,
+	MX53_PAD_SD2_DATA3__ESDHC2_DAT3,
+	/* SD3 */
+	MX53_PAD_PATA_DATA8__ESDHC3_DAT0,
+	MX53_PAD_PATA_DATA9__ESDHC3_DAT1,
+	MX53_PAD_PATA_DATA10__ESDHC3_DAT2,
+	MX53_PAD_PATA_DATA11__ESDHC3_DAT3,
+	MX53_PAD_PATA_DATA0__ESDHC3_DAT4,
+	MX53_PAD_PATA_DATA1__ESDHC3_DAT5,
+	MX53_PAD_PATA_DATA2__ESDHC3_DAT6,
+	MX53_PAD_PATA_DATA3__ESDHC3_DAT7,
+	MX53_PAD_PATA_IORDY__ESDHC3_CLK,
+	MX53_PAD_PATA_RESET_B__ESDHC3_CMD,
 };
 
 static const struct imxuart_platform_data mx53_smd_uart_data __initconst = {
@@ -97,6 +122,9 @@ static void __init mx53_smd_board_init(void)
 	imx53_add_fec(&mx53_smd_fec_data);
 	imx53_add_imx2_wdt(0, NULL);
 	imx53_add_imx_i2c(0, &mx53_smd_i2c_data);
+	imx53_add_sdhci_esdhc_imx(0, NULL);
+	imx53_add_sdhci_esdhc_imx(1, NULL);
+	imx53_add_sdhci_esdhc_imx(2, NULL);
 }
 
 static void __init mx53_smd_timer_init(void)
-- 
1.6.0.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v2] ARM: mx5/mx53_smd: Add esdhc support
  2011-04-04 12:32 [PATCH v2] ARM: mx5/mx53_smd: Add esdhc support Fabio Estevam
@ 2011-04-04 12:40 ` Wolfram Sang
  2011-04-04 16:00 ` Uwe Kleine-König
  1 sibling, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2011-04-04 12:40 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Apr 04, 2011 at 09:32:55AM -0300, Fabio Estevam wrote:
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - Do not use CD and WP detecion via GPIO as it is not working for MX53 yet.

WP, too? I thought Richard had only issues with CD?

Otherwise:

Acked-by: Wolfram Sang <w.sang@pengutronix.de>

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110404/47f47efd/attachment.sig>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2] ARM: mx5/mx53_smd: Add esdhc support
  2011-04-04 12:32 [PATCH v2] ARM: mx5/mx53_smd: Add esdhc support Fabio Estevam
  2011-04-04 12:40 ` Wolfram Sang
@ 2011-04-04 16:00 ` Uwe Kleine-König
  2011-04-04 17:21   ` Fabio Estevam
  1 sibling, 1 reply; 4+ messages in thread
From: Uwe Kleine-König @ 2011-04-04 16:00 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Apr 04, 2011 at 09:32:55AM -0300, Fabio Estevam wrote:
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - Do not use CD and WP detecion via GPIO as it is not working for MX53 yet.
> 
>  arch/arm/mach-mx5/board-mx53_smd.c |   28 ++++++++++++++++++++++++++++
You need to let MACH_MX53_SMD select IMX_HAVE_PLATFORM_SDHCI_ESDHC_IMX.

Best regards
Uwe
>  1 files changed, 28 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-mx5/board-mx53_smd.c b/arch/arm/mach-mx5/board-mx53_smd.c
> index 31e1732..e510c27 100644
> --- a/arch/arm/mach-mx5/board-mx53_smd.c
> +++ b/arch/arm/mach-mx5/board-mx53_smd.c
> @@ -52,6 +52,31 @@ static iomux_v3_cfg_t mx53_smd_pads[] = {
>  	/* I2C1 */
>  	MX53_PAD_CSI0_DAT8__I2C1_SDA,
>  	MX53_PAD_CSI0_DAT9__I2C1_SCL,
> +	/* SD1 */
> +	MX53_PAD_SD1_CMD__ESDHC1_CMD,
> +	MX53_PAD_SD1_CLK__ESDHC1_CLK,
> +	MX53_PAD_SD1_DATA0__ESDHC1_DAT0,
> +	MX53_PAD_SD1_DATA1__ESDHC1_DAT1,
> +	MX53_PAD_SD1_DATA2__ESDHC1_DAT2,
> +	MX53_PAD_SD1_DATA3__ESDHC1_DAT3,
> +	/* SD2 */
> +	MX53_PAD_SD2_CMD__ESDHC2_CMD,
> +	MX53_PAD_SD2_CLK__ESDHC2_CLK,
> +	MX53_PAD_SD2_DATA0__ESDHC2_DAT0,
> +	MX53_PAD_SD2_DATA1__ESDHC2_DAT1,
> +	MX53_PAD_SD2_DATA2__ESDHC2_DAT2,
> +	MX53_PAD_SD2_DATA3__ESDHC2_DAT3,
> +	/* SD3 */
> +	MX53_PAD_PATA_DATA8__ESDHC3_DAT0,
> +	MX53_PAD_PATA_DATA9__ESDHC3_DAT1,
> +	MX53_PAD_PATA_DATA10__ESDHC3_DAT2,
> +	MX53_PAD_PATA_DATA11__ESDHC3_DAT3,
> +	MX53_PAD_PATA_DATA0__ESDHC3_DAT4,
> +	MX53_PAD_PATA_DATA1__ESDHC3_DAT5,
> +	MX53_PAD_PATA_DATA2__ESDHC3_DAT6,
> +	MX53_PAD_PATA_DATA3__ESDHC3_DAT7,
> +	MX53_PAD_PATA_IORDY__ESDHC3_CLK,
> +	MX53_PAD_PATA_RESET_B__ESDHC3_CMD,
>  };
>  
>  static const struct imxuart_platform_data mx53_smd_uart_data __initconst = {
> @@ -97,6 +122,9 @@ static void __init mx53_smd_board_init(void)
>  	imx53_add_fec(&mx53_smd_fec_data);
>  	imx53_add_imx2_wdt(0, NULL);
>  	imx53_add_imx_i2c(0, &mx53_smd_i2c_data);
> +	imx53_add_sdhci_esdhc_imx(0, NULL);
> +	imx53_add_sdhci_esdhc_imx(1, NULL);
> +	imx53_add_sdhci_esdhc_imx(2, NULL);
>  }
>  
>  static void __init mx53_smd_timer_init(void)
> -- 
> 1.6.0.4
> 
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v2] ARM: mx5/mx53_smd: Add esdhc support
  2011-04-04 16:00 ` Uwe Kleine-König
@ 2011-04-04 17:21   ` Fabio Estevam
  0 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2011-04-04 17:21 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Uwe,

2011/4/4 Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>:
> On Mon, Apr 04, 2011 at 09:32:55AM -0300, Fabio Estevam wrote:
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>> ---
>> Changes since v1:
>> - Do not use CD and WP detecion via GPIO as it is not working for MX53 yet.
>>
>> ?arch/arm/mach-mx5/board-mx53_smd.c | ? 28 ++++++++++++++++++++++++++++
> You need to let MACH_MX53_SMD select IMX_HAVE_PLATFORM_SDHCI_ESDHC_IMX.

Correct. I have already sent v3 that addresses this point.

Regards,

Fabio Estevam

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-04-04 17:21 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-04 12:32 [PATCH v2] ARM: mx5/mx53_smd: Add esdhc support Fabio Estevam
2011-04-04 12:40 ` Wolfram Sang
2011-04-04 16:00 ` Uwe Kleine-König
2011-04-04 17:21   ` Fabio Estevam

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).