* [PATCH] plat-mxc: Provide irq_chip name for GPIO IRQs
@ 2011-01-31 16:00 Alexander Stein
2011-03-01 7:38 ` Alexander Stein
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Stein @ 2011-01-31 16:00 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
---
arch/arm/plat-mxc/gpio.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-mxc/gpio.c b/arch/arm/plat-mxc/gpio.c
index d17b3c9..e396df8 100644
--- a/arch/arm/plat-mxc/gpio.c
+++ b/arch/arm/plat-mxc/gpio.c
@@ -233,6 +233,7 @@ static int gpio_set_wake_irq(struct irq_data *d, u32 enable)
}
static struct irq_chip gpio_irq_chip = {
+ .name = "GPIO",
.irq_ack = gpio_ack_irq,
.irq_mask = gpio_mask_irq,
.irq_unmask = gpio_unmask_irq,
--
1.7.3.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] plat-mxc: Provide irq_chip name for GPIO IRQs
2011-01-31 16:00 [PATCH] plat-mxc: Provide irq_chip name for GPIO IRQs Alexander Stein
@ 2011-03-01 7:38 ` Alexander Stein
2011-03-01 8:34 ` Wolfram Sang
0 siblings, 1 reply; 6+ messages in thread
From: Alexander Stein @ 2011-03-01 7:38 UTC (permalink / raw)
To: linux-arm-kernel
Hello,
On Monday 31 January 2011, 17:00:24 Alexander Stein wrote:
> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
> ---
> arch/arm/plat-mxc/gpio.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/plat-mxc/gpio.c b/arch/arm/plat-mxc/gpio.c
> index d17b3c9..e396df8 100644
> --- a/arch/arm/plat-mxc/gpio.c
> +++ b/arch/arm/plat-mxc/gpio.c
> @@ -233,6 +233,7 @@ static int gpio_set_wake_irq(struct irq_data *d, u32
> enable) }
>
> static struct irq_chip gpio_irq_chip = {
> + .name = "GPIO",
> .irq_ack = gpio_ack_irq,
> .irq_mask = gpio_mask_irq,
> .irq_unmask = gpio_unmask_irq,
Did this get overlooked?
Regards,
Alexander
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] plat-mxc: Provide irq_chip name for GPIO IRQs
2011-03-01 7:38 ` Alexander Stein
@ 2011-03-01 8:34 ` Wolfram Sang
2011-04-04 14:29 ` Uwe Kleine-König
0 siblings, 1 reply; 6+ messages in thread
From: Wolfram Sang @ 2011-03-01 8:34 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
> > static struct irq_chip gpio_irq_chip = {
> > + .name = "GPIO",
I'd suggest a more specific name, e.g. "i.MX GPIO"? You can then also
add my
Acked-by: Wolfram Sang <w.sang@pengutronix.de>
Regards,
Wolfram
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110301/dacba0d6/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] plat-mxc: Provide irq_chip name for GPIO IRQs
2011-03-01 8:34 ` Wolfram Sang
@ 2011-04-04 14:29 ` Uwe Kleine-König
2011-04-04 14:34 ` Russell King - ARM Linux
0 siblings, 1 reply; 6+ messages in thread
From: Uwe Kleine-König @ 2011-04-04 14:29 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Mar 01, 2011 at 09:34:15AM +0100, Wolfram Sang wrote:
> Hi,
>
> > > static struct irq_chip gpio_irq_chip = {
> > > + .name = "GPIO",
>
> I'd suggest a more specific name, e.g. "i.MX GPIO"? You can then also
> add my
>
> Acked-by: Wolfram Sang <w.sang@pengutronix.de>
This comment wasn't addressed. Does someone care to follow up?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] plat-mxc: Provide irq_chip name for GPIO IRQs
2011-04-04 14:29 ` Uwe Kleine-König
@ 2011-04-04 14:34 ` Russell King - ARM Linux
2011-04-04 15:21 ` Alexander Stein
0 siblings, 1 reply; 6+ messages in thread
From: Russell King - ARM Linux @ 2011-04-04 14:34 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Apr 04, 2011 at 04:29:36PM +0200, Uwe Kleine-K?nig wrote:
> On Tue, Mar 01, 2011 at 09:34:15AM +0100, Wolfram Sang wrote:
> > Hi,
> >
> > > > static struct irq_chip gpio_irq_chip = {
> > > > + .name = "GPIO",
> >
> > I'd suggest a more specific name, e.g. "i.MX GPIO"? You can then also
> > add my
> >
> > Acked-by: Wolfram Sang <w.sang@pengutronix.de>
> This comment wasn't addressed. Does someone care to follow up?
And if we consolidate the GPIO implementations (I hope *someone* is
working on that) then this doesn't matter one ounce because platforms
won't be identifying that its an 'i.MX GPIO'.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] plat-mxc: Provide irq_chip name for GPIO IRQs
2011-04-04 14:34 ` Russell King - ARM Linux
@ 2011-04-04 15:21 ` Alexander Stein
0 siblings, 0 replies; 6+ messages in thread
From: Alexander Stein @ 2011-04-04 15:21 UTC (permalink / raw)
To: linux-arm-kernel
On Monday 04 April 2011, 16:34:08 Russell King - ARM Linux wrote:
> On Mon, Apr 04, 2011 at 04:29:36PM +0200, Uwe Kleine-K?nig wrote:
> > On Tue, Mar 01, 2011 at 09:34:15AM +0100, Wolfram Sang wrote:
> > > Hi,
> > >
> > > > > static struct irq_chip gpio_irq_chip = {
> > > > >
> > > > > + .name = "GPIO",
> > >
> > > I'd suggest a more specific name, e.g. "i.MX GPIO"? You can then also
> > > add my
> > >
> > > Acked-by: Wolfram Sang <w.sang@pengutronix.de>
> >
> > This comment wasn't addressed. Does someone care to follow up?
>
> And if we consolidate the GPIO implementations (I hope *someone* is
> working on that) then this doesn't matter one ounce because platforms
> won't be identifying that its an 'i.MX GPIO'.
The benefit from this patch is that it gets shown at /proc/interrupts. But I
personally don't care if it's "GPIO" as in mainline now or "i.MX GPIO"
Alexander
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-04-04 15:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-31 16:00 [PATCH] plat-mxc: Provide irq_chip name for GPIO IRQs Alexander Stein
2011-03-01 7:38 ` Alexander Stein
2011-03-01 8:34 ` Wolfram Sang
2011-04-04 14:29 ` Uwe Kleine-König
2011-04-04 14:34 ` Russell King - ARM Linux
2011-04-04 15:21 ` Alexander Stein
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).