From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] plat-mxc: Provide irq_chip name for GPIO IRQs
Date: Mon, 4 Apr 2011 15:34:08 +0100 [thread overview]
Message-ID: <20110404143408.GD22480@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20110404142936.GF30938@pengutronix.de>
On Mon, Apr 04, 2011 at 04:29:36PM +0200, Uwe Kleine-K?nig wrote:
> On Tue, Mar 01, 2011 at 09:34:15AM +0100, Wolfram Sang wrote:
> > Hi,
> >
> > > > static struct irq_chip gpio_irq_chip = {
> > > > + .name = "GPIO",
> >
> > I'd suggest a more specific name, e.g. "i.MX GPIO"? You can then also
> > add my
> >
> > Acked-by: Wolfram Sang <w.sang@pengutronix.de>
> This comment wasn't addressed. Does someone care to follow up?
And if we consolidate the GPIO implementations (I hope *someone* is
working on that) then this doesn't matter one ounce because platforms
won't be identifying that its an 'i.MX GPIO'.
next prev parent reply other threads:[~2011-04-04 14:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-31 16:00 [PATCH] plat-mxc: Provide irq_chip name for GPIO IRQs Alexander Stein
2011-03-01 7:38 ` Alexander Stein
2011-03-01 8:34 ` Wolfram Sang
2011-04-04 14:29 ` Uwe Kleine-König
2011-04-04 14:34 ` Russell King - ARM Linux [this message]
2011-04-04 15:21 ` Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110404143408.GD22480@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).