From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] ARM: mxc: Introduce imx_add_gpio_leds
Date: Mon, 4 Apr 2011 18:52:40 +0100 [thread overview]
Message-ID: <20110404175240.GF22480@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20110404174244.GH13963@pengutronix.de>
On Mon, Apr 04, 2011 at 07:42:44PM +0200, Uwe Kleine-K?nig wrote:
> The mechanims could be made a bit more aggressive by something like
> that:
>
> struct gpio_led_platform_data *_pdata = *pdata;
> _pdata->leds = kmemdup(pdata->leds, pdata->num_leds * sizeof(*pdata->leds), GFP_KERNEL)
> if (!_pdata->leds)
> return ...
>
> ret = imx_add_platform_device("leds-gpio", -1, NULL, 0, _pdata, sizeof(_pdata));
> if (IS_ERR(ret))
> kfree(_pdata->leds);
>
> return PTR_RET(ret);
>
> This would allow to have the struct gpio_led array in init memory, too.
If you go to the effort of making it _that_ generic, then it shouldn't
even be in plat-mxc, but somewhere *everyone* can benefit from it. See
Linus' complaints in the OMAP pull request thread about the amount of
largely similar arch/arm code.
next prev parent reply other threads:[~2011-04-04 17:52 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 17:06 [PATCH v2 1/2] ARM: mxc: Introduce imx_add_gpio_leds Fabio Estevam
2011-04-04 17:06 ` [PATCH v2 2/2] ARM: mx5/mx53_evk.c: Add LED support Fabio Estevam
2011-04-04 17:19 ` [PATCH v2 1/2] ARM: mxc: Introduce imx_add_gpio_leds Sascha Hauer
2011-04-04 17:42 ` Uwe Kleine-König
2011-04-04 17:52 ` Russell King - ARM Linux [this message]
2011-04-04 18:06 ` H Hartley Sweeten
2011-04-04 18:17 ` Russell King - ARM Linux
2011-04-04 21:52 ` H Hartley Sweeten
2011-04-05 7:30 ` Uwe Kleine-König
2011-04-05 7:40 ` Russell King - ARM Linux
2011-04-05 7:43 ` Uwe Kleine-König
2011-04-05 7:47 ` Russell King - ARM Linux
2011-04-05 7:51 ` Uwe Kleine-König
2011-04-05 7:59 ` Russell King - ARM Linux
2011-04-05 8:32 ` Uwe Kleine-König
2011-04-05 8:43 ` Russell King - ARM Linux
2011-04-05 8:46 ` Uwe Kleine-König
2011-04-05 8:37 ` [PATCH] leds: provide helper to register "leds-gpio" devices Uwe Kleine-König
2011-04-05 16:13 ` Fabio Estevam
2011-04-05 16:29 ` Fabio Estevam
2011-04-05 18:12 ` H Hartley Sweeten
2011-04-05 16:33 ` Russell King - ARM Linux
2011-04-05 20:24 ` [PATCH v2] " Uwe Kleine-König
2011-04-06 11:45 ` Fabio Estevam
2011-04-06 11:52 ` Richard Purdie
2011-04-06 12:33 ` Uwe Kleine-König
2011-04-06 13:38 ` Richard Purdie
2011-04-11 20:35 ` [PATCH v3] " Uwe Kleine-König
2011-04-12 21:48 ` Russell King - ARM Linux
2011-04-13 6:23 ` Uwe Kleine-König
2011-05-06 21:03 ` Richard Purdie
2011-05-09 8:00 ` Uwe Kleine-König
2011-04-26 15:08 ` Uwe Kleine-König
2011-05-06 8:25 ` Uwe Kleine-König
2011-05-09 22:02 ` Andrew Morton
2011-05-09 22:17 ` Russell King - ARM Linux
2011-05-10 6:45 ` Uwe Kleine-König
2011-05-10 7:31 ` Uwe Kleine-König
2011-05-10 8:50 ` [PATCH v4] " Uwe Kleine-König
2011-05-10 8:50 ` [PATCH] [wip] ARM: imx: register "leds-gpio" device using new helper function Uwe Kleine-König
2011-05-10 22:26 ` H Hartley Sweeten
2011-05-11 6:22 ` Uwe Kleine-König
2011-05-10 23:02 ` H Hartley Sweeten
2011-04-19 23:19 ` [PATCH] leds: provide helper to register "leds-gpio" devices Andrew Morton
2011-04-19 23:24 ` Russell King - ARM Linux
2011-04-19 23:50 ` Andrew Morton
2011-04-05 16:41 ` [PATCH v2 1/2] ARM: mxc: Introduce imx_add_gpio_leds H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110404175240.GF22480@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).