From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm/dt: Add a make rule to build dtb for enabled boards
Date: Tue, 5 Apr 2011 08:50:28 -0600 [thread overview]
Message-ID: <20110405145028.GD30849@ponder.secretlab.ca> (raw)
In-Reply-To: <20110405070904.GB28171@S2100-06.ap.freescale.net>
On Tue, Apr 05, 2011 at 03:09:05PM +0800, Shawn Guo wrote:
> On Mon, Apr 04, 2011 at 10:48:27PM -0600, Grant Likely wrote:
> > On Mon, Apr 04, 2011 at 11:01:47PM +0800, Shawn Guo wrote:
> > > With 'make ARCH=arm dtb', it builds Device Tree Blobs for those boards
> > > enabled by build CONFIG.
> > >
> > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> > > ---
> > > It's based on commit fe8e6d0b0e601ca0a63fe768d4b812d5a45a9da7
> > > "arm/dt: Add dtb make rule" from Rob Herring. And it works against
> > > Linaro kernel tree. But it needs to go through mainline review
> > > before it gets applied.
> > >
> > > Changes since v1:
> > > * Take suggestion from Rob Herring to move .dts dection into machine
> > > sepcific Makefile.boot, so that arch/arm/boot/Makefile can be as
> > > clean as it is.
> >
> > Looks good, some minor comments below, but I've picked it up and asked
> > Nicolas to merge it.
> >
> > Cheers,
> > g.
> >
> > >
> > > arch/arm/Makefile | 3 +++
> > > arch/arm/boot/Makefile | 2 ++
> > > arch/arm/mach-exynos4/Makefile.boot | 2 ++
> > > arch/arm/mach-mx5/Makefile.boot | 5 +++++
> > > arch/arm/mach-omap2/Makefile.boot | 4 ++++
> > > arch/arm/mach-tegra/Makefile.boot | 2 ++
> > > arch/arm/mach-versatile/Makefile.boot | 2 ++
> > > 7 files changed, 20 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/arch/arm/Makefile b/arch/arm/Makefile
> > > index d51ab6c..7fd2af9 100644
> > > --- a/arch/arm/Makefile
> > > +++ b/arch/arm/Makefile
> > > @@ -292,6 +292,9 @@ zinstall uinstall install: vmlinux
> > > %.dtb:
> > > $(Q)$(MAKE) $(build)=$(boot) MACHINE=$(MACHINE) $(boot)/$@
> > >
> > > +dtb:
> > > + $(Q)$(MAKE) $(build)=$(boot) MACHINE=$(MACHINE) $(boot)/$@
> > > +
> >
> > Since the target is the same, I've merged this rule with the %.dtb
> > rule. I also renamed the target 'dtbs' because it will build more
> > than one .dtb file.
> >
> I started with 'dtbs' as target name, and later changed it to 'dtb'
> to align with $(dtb-y). And 'dtbs' looks truly fine for me, but you
> may want to change commit message accordingly, as there is
> 'make ARCH=arm dtb' in it.
Thanks, fixed in my devicetree/test tree and also added something to
the help text.
g.
prev parent reply other threads:[~2011-04-05 14:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 15:01 [PATCH v2] arm/dt: Add a make rule to build dtb for enabled boards Shawn Guo
2011-04-05 4:48 ` Grant Likely
2011-04-05 7:09 ` Shawn Guo
2011-04-05 14:50 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110405145028.GD30849@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).