From: mad_soft@inbox.ru (Dmitry Artamonow)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pxa/hx4700: bq24022 regulator needs to be enabled
Date: Tue, 19 Apr 2011 12:40:32 +0400 [thread overview]
Message-ID: <20110419084032.GA30743@rainbow> (raw)
In-Reply-To: <E1QAkBF-0003bF-A0@outmx04.plus.net>
On 14:39 Fri 15 Apr , Paul Parsons wrote:
> Add REGULATOR_CHANGE_STATUS flag to hx4700 bq24022 regulator. Without this flag the bq24022 cannot be enabled and the battery will not charge.
>
Ah, so that's why my hx4700 doesn't charges under linux! I noticed
that some time ago, but never found the time to investigate this.
Thanks for finding this out. Will test.
BTW, this should probably go through Eric Miao's PXA tree, so adding him
to CC list.
> Signed-off-by: Paul Parsons <lost.distance@yahoo.com>
> ---
> --- clean-2.6.38/arch/arm/mach-pxa/hx4700.c 2011-03-15 01:20:32.000000000 +0000
> +++ linux-2.6.38/arch/arm/mach-pxa/hx4700.c 2011-04-15 04:39:04.869989025 +0100
> @@ -711,7 +711,7 @@ static struct regulator_consumer_supply
> static struct regulator_init_data bq24022_init_data = {
> .constraints = {
> .max_uA = 500000,
> - .valid_ops_mask = REGULATOR_CHANGE_CURRENT,
> + .valid_ops_mask = REGULATOR_CHANGE_CURRENT|REGULATOR_CHANGE_STATUS,
> },
> .num_consumer_supplies = ARRAY_SIZE(bq24022_consumers),
> .consumer_supplies = bq24022_consumers,
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Best regards,
Dmitry "MAD" Artamonow
next prev parent reply other threads:[~2011-04-19 8:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 14:39 [PATCH] pxa/hx4700: bq24022 regulator needs to be enabled Paul Parsons
2011-04-19 8:40 ` Dmitry Artamonow [this message]
2011-04-19 10:25 ` Eric Miao
2011-04-19 11:32 ` Dmitry Artamonow
2011-04-19 13:03 ` Eric Miao
2011-04-20 13:40 ` Philipp Zabel
2011-04-20 13:41 ` [PATCH] pxa/magician: " Philipp Zabel
2011-04-20 13:48 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110419084032.GA30743@rainbow \
--to=mad_soft@inbox.ru \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).