* [PATCH] pxa/hx4700: bq24022 regulator needs to be enabled
@ 2011-04-15 14:39 Paul Parsons
2011-04-19 8:40 ` Dmitry Artamonow
0 siblings, 1 reply; 8+ messages in thread
From: Paul Parsons @ 2011-04-15 14:39 UTC (permalink / raw)
To: linux-arm-kernel
Add REGULATOR_CHANGE_STATUS flag to hx4700 bq24022 regulator. Without this flag the bq24022 cannot be enabled and the battery will not charge.
Signed-off-by: Paul Parsons <lost.distance@yahoo.com>
---
--- clean-2.6.38/arch/arm/mach-pxa/hx4700.c 2011-03-15 01:20:32.000000000 +0000
+++ linux-2.6.38/arch/arm/mach-pxa/hx4700.c 2011-04-15 04:39:04.869989025 +0100
@@ -711,7 +711,7 @@ static struct regulator_consumer_supply
static struct regulator_init_data bq24022_init_data = {
.constraints = {
.max_uA = 500000,
- .valid_ops_mask = REGULATOR_CHANGE_CURRENT,
+ .valid_ops_mask = REGULATOR_CHANGE_CURRENT|REGULATOR_CHANGE_STATUS,
},
.num_consumer_supplies = ARRAY_SIZE(bq24022_consumers),
.consumer_supplies = bq24022_consumers,
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH] pxa/hx4700: bq24022 regulator needs to be enabled
2011-04-15 14:39 [PATCH] pxa/hx4700: bq24022 regulator needs to be enabled Paul Parsons
@ 2011-04-19 8:40 ` Dmitry Artamonow
2011-04-19 10:25 ` Eric Miao
2011-04-19 11:32 ` Dmitry Artamonow
0 siblings, 2 replies; 8+ messages in thread
From: Dmitry Artamonow @ 2011-04-19 8:40 UTC (permalink / raw)
To: linux-arm-kernel
On 14:39 Fri 15 Apr , Paul Parsons wrote:
> Add REGULATOR_CHANGE_STATUS flag to hx4700 bq24022 regulator. Without this flag the bq24022 cannot be enabled and the battery will not charge.
>
Ah, so that's why my hx4700 doesn't charges under linux! I noticed
that some time ago, but never found the time to investigate this.
Thanks for finding this out. Will test.
BTW, this should probably go through Eric Miao's PXA tree, so adding him
to CC list.
> Signed-off-by: Paul Parsons <lost.distance@yahoo.com>
> ---
> --- clean-2.6.38/arch/arm/mach-pxa/hx4700.c 2011-03-15 01:20:32.000000000 +0000
> +++ linux-2.6.38/arch/arm/mach-pxa/hx4700.c 2011-04-15 04:39:04.869989025 +0100
> @@ -711,7 +711,7 @@ static struct regulator_consumer_supply
> static struct regulator_init_data bq24022_init_data = {
> .constraints = {
> .max_uA = 500000,
> - .valid_ops_mask = REGULATOR_CHANGE_CURRENT,
> + .valid_ops_mask = REGULATOR_CHANGE_CURRENT|REGULATOR_CHANGE_STATUS,
> },
> .num_consumer_supplies = ARRAY_SIZE(bq24022_consumers),
> .consumer_supplies = bq24022_consumers,
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Best regards,
Dmitry "MAD" Artamonow
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH] pxa/hx4700: bq24022 regulator needs to be enabled
2011-04-19 8:40 ` Dmitry Artamonow
@ 2011-04-19 10:25 ` Eric Miao
2011-04-19 11:32 ` Dmitry Artamonow
1 sibling, 0 replies; 8+ messages in thread
From: Eric Miao @ 2011-04-19 10:25 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Apr 19, 2011 at 4:40 PM, Dmitry Artamonow <mad_soft@inbox.ru> wrote:
> On 14:39 Fri 15 Apr ? ? , Paul Parsons wrote:
>> Add REGULATOR_CHANGE_STATUS flag to hx4700 bq24022 regulator. Without this flag the bq24022 cannot be enabled and the battery will not charge.
>>
> Ah, so that's why my hx4700 doesn't charges under linux! I noticed
> that some time ago, but never found the time to investigate this.
> Thanks for finding this out. Will test.
>
> BTW, this should probably go through Eric Miao's PXA tree, so adding him
> to CC list.
>
Applied to 'fix'.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] pxa/hx4700: bq24022 regulator needs to be enabled
2011-04-19 8:40 ` Dmitry Artamonow
2011-04-19 10:25 ` Eric Miao
@ 2011-04-19 11:32 ` Dmitry Artamonow
2011-04-19 13:03 ` Eric Miao
1 sibling, 1 reply; 8+ messages in thread
From: Dmitry Artamonow @ 2011-04-19 11:32 UTC (permalink / raw)
To: linux-arm-kernel
On 12:40 Tue 19 Apr , Dmitry Artamonow wrote:
> On 14:39 Fri 15 Apr , Paul Parsons wrote:
> > Add REGULATOR_CHANGE_STATUS flag to hx4700 bq24022 regulator. Without this flag the bq24022 cannot be enabled and the battery will not charge.
> >
> Ah, so that's why my hx4700 doesn't charges under linux! I noticed
> that some time ago, but never found the time to investigate this.
> Thanks for finding this out. Will test.
Yes, looks like it really works! After about an hour in linux-2.6.38 with
this patch applied, battery charged from about a half-empty to almost
full (I verified by rebooting into WinMobile). Good! And in dmesg there were
also "enabling charger" messages every time I plugged charger cable into
device.
So, get my
Tested-by: Dmitry Artamonow <mad_soft@inbox.ru>
--
Best regards,
Dmitry "MAD" Artamonow
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] pxa/hx4700: bq24022 regulator needs to be enabled
2011-04-19 11:32 ` Dmitry Artamonow
@ 2011-04-19 13:03 ` Eric Miao
2011-04-20 13:40 ` Philipp Zabel
2011-04-20 13:41 ` [PATCH] pxa/magician: " Philipp Zabel
0 siblings, 2 replies; 8+ messages in thread
From: Eric Miao @ 2011-04-19 13:03 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Apr 19, 2011 at 7:32 PM, Dmitry Artamonow <mad_soft@inbox.ru> wrote:
> On 12:40 Tue 19 Apr ? ? , Dmitry Artamonow wrote:
>> On 14:39 Fri 15 Apr ? ? , Paul Parsons wrote:
>> > Add REGULATOR_CHANGE_STATUS flag to hx4700 bq24022 regulator. Without this flag the bq24022 cannot be enabled and the battery will not charge.
>> >
>> Ah, so that's why my hx4700 doesn't charges under linux! I noticed
>> that some time ago, but never found the time to investigate this.
>> Thanks for finding this out. Will test.
>
> Yes, looks like it really works! After about an hour in linux-2.6.38 with
> this patch applied, battery charged from about a half-empty to almost
> full (I verified by rebooting into WinMobile). Good! And in dmesg there were
> also "enabling charger" messages every time I plugged charger cable into
> device.
>
> So, get my
> Tested-by: Dmitry Artamonow <mad_soft@inbox.ru>
Thanks. Updated and pushed. Will send out git-pull soon.
>
> --
> Best regards,
> Dmitry "MAD" Artamonow
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] pxa/hx4700: bq24022 regulator needs to be enabled
2011-04-19 13:03 ` Eric Miao
@ 2011-04-20 13:40 ` Philipp Zabel
2011-04-20 13:41 ` [PATCH] pxa/magician: " Philipp Zabel
1 sibling, 0 replies; 8+ messages in thread
From: Philipp Zabel @ 2011-04-20 13:40 UTC (permalink / raw)
To: linux-arm-kernel
Am Dienstag, den 19.04.2011, 21:03 +0800 schrieb Eric Miao:
> On Tue, Apr 19, 2011 at 7:32 PM, Dmitry Artamonow <mad_soft@inbox.ru> wrote:
> > On 12:40 Tue 19 Apr , Dmitry Artamonow wrote:
> >> On 14:39 Fri 15 Apr , Paul Parsons wrote:
> >> > Add REGULATOR_CHANGE_STATUS flag to hx4700 bq24022 regulator. Without this flag the bq24022 cannot be enabled and the battery will not charge.
> >> >
> >> Ah, so that's why my hx4700 doesn't charges under linux! I noticed
> >> that some time ago, but never found the time to investigate this.
> >> Thanks for finding this out. Will test.
> >
> > Yes, looks like it really works! After about an hour in linux-2.6.38 with
> > this patch applied, battery charged from about a half-empty to almost
> > full (I verified by rebooting into WinMobile). Good! And in dmesg there were
> > also "enabling charger" messages every time I plugged charger cable into
> > device.
Dito. Thank you, Paul!
> So, get my
> > Tested-by: Dmitry Artamonow <mad_soft@inbox.ru>
>
> Thanks. Updated and pushed. Will send out git-pull soon.
Eric, if it's not too late, could you also apply the same fix for
magician?
cheers
Philipp
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] pxa/magician: bq24022 regulator needs to be enabled
2011-04-19 13:03 ` Eric Miao
2011-04-20 13:40 ` Philipp Zabel
@ 2011-04-20 13:41 ` Philipp Zabel
2011-04-20 13:48 ` Eric Miao
1 sibling, 1 reply; 8+ messages in thread
From: Philipp Zabel @ 2011-04-20 13:41 UTC (permalink / raw)
To: linux-arm-kernel
Add REGULATOR_CHANGE_STATUS flag to magician bq24022 regulator to enable charging.
Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
---
arch/arm/mach-pxa/magician.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-pxa/magician.c b/arch/arm/mach-pxa/magician.c
index a72993d..9984ef7 100644
--- a/arch/arm/mach-pxa/magician.c
+++ b/arch/arm/mach-pxa/magician.c
@@ -599,7 +599,7 @@ static struct regulator_consumer_supply bq24022_consumers[] = {
static struct regulator_init_data bq24022_init_data = {
.constraints = {
.max_uA = 500000,
- .valid_ops_mask = REGULATOR_CHANGE_CURRENT,
+ .valid_ops_mask = REGULATOR_CHANGE_CURRENT | REGULATOR_CHANGE_STATUS,
},
.num_consumer_supplies = ARRAY_SIZE(bq24022_consumers),
.consumer_supplies = bq24022_consumers,
--
1.7.4.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH] pxa/magician: bq24022 regulator needs to be enabled
2011-04-20 13:41 ` [PATCH] pxa/magician: " Philipp Zabel
@ 2011-04-20 13:48 ` Eric Miao
0 siblings, 0 replies; 8+ messages in thread
From: Eric Miao @ 2011-04-20 13:48 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Apr 20, 2011 at 9:41 PM, Philipp Zabel <philipp.zabel@gmail.com> wrote:
> Add REGULATOR_CHANGE_STATUS flag to magician bq24022 regulator to enable charging.
>
> Signed-off-by: Philipp Zabel <philipp.zabel@gmail.com>
Applied to 'fix'. Thanks.
> ---
> ?arch/arm/mach-pxa/magician.c | ? ?2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/magician.c b/arch/arm/mach-pxa/magician.c
> index a72993d..9984ef7 100644
> --- a/arch/arm/mach-pxa/magician.c
> +++ b/arch/arm/mach-pxa/magician.c
> @@ -599,7 +599,7 @@ static struct regulator_consumer_supply bq24022_consumers[] = {
> ?static struct regulator_init_data bq24022_init_data = {
> ? ? ? ?.constraints = {
> ? ? ? ? ? ? ? ?.max_uA ? ? ? ? = 500000,
> - ? ? ? ? ? ? ? .valid_ops_mask = REGULATOR_CHANGE_CURRENT,
> + ? ? ? ? ? ? ? .valid_ops_mask = REGULATOR_CHANGE_CURRENT | REGULATOR_CHANGE_STATUS,
> ? ? ? ?},
> ? ? ? ?.num_consumer_supplies ?= ARRAY_SIZE(bq24022_consumers),
> ? ? ? ?.consumer_supplies ? ? ?= bq24022_consumers,
> --
> 1.7.4.4
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-04-20 13:48 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-15 14:39 [PATCH] pxa/hx4700: bq24022 regulator needs to be enabled Paul Parsons
2011-04-19 8:40 ` Dmitry Artamonow
2011-04-19 10:25 ` Eric Miao
2011-04-19 11:32 ` Dmitry Artamonow
2011-04-19 13:03 ` Eric Miao
2011-04-20 13:40 ` Philipp Zabel
2011-04-20 13:41 ` [PATCH] pxa/magician: " Philipp Zabel
2011-04-20 13:48 ` Eric Miao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).