From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Fix relocation if image end past uncompressed kernel end
Date: Fri, 22 Apr 2011 09:09:41 +0300 [thread overview]
Message-ID: <20110422060940.GA16892@atomide.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1104210919070.24613@xanadu.home>
* Nicolas Pitre <nicolas.pitre@linaro.org> [110421 16:18]:
> On Thu, 21 Apr 2011, Tony Lindgren wrote:
>
> > Otherwise we end up overwriting ourselves. This fixes booting
> > on n900 after commit 6d7d0ae51574943bf571d269da3243257a2d15db
> > (ARM: 6750/1: improvements to compressed/head.S).
> >
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
>
> I don't understand why this is needed. The copy loop is explicitly
> copying from the end going backward exactly to cope with this
> possibility.
>
> Hmmm...
Yeah that's what I'm wondering too.. This is probably not the
right fix.. I'm also wondering that it should be possible to
make uImage also not work by setting loadaddr just before the
uncompressed kernel end.
You would assume that only the running code would not survive
relocation if some of it gets overwritten. But that should be
only the beginning, no idea why the need to relocate all the
way after the whole image?
If stack was overlapping the zImage, I could see it corrupt
the zImage but there not much happening between relocating
and restarting of the bootloader.
Tony
next prev parent reply other threads:[~2011-04-22 6:09 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-20 4:15 [PATCH 0/3] fix some issues with the kernel decompressor Nicolas Pitre
2011-04-20 4:15 ` [PATCH 1/3] ARM: zImage: no need to get the decompressed size from the filesystem Nicolas Pitre
2011-04-21 12:47 ` Tony Lindgren
2011-04-20 4:15 ` [PATCH 2/3] ARM: compressed/misc.c: simplify decompress_kernel() Nicolas Pitre
2011-04-21 12:49 ` Tony Lindgren
2011-04-27 8:53 ` Russell King - ARM Linux
2011-04-27 14:48 ` Nicolas Pitre
2011-04-28 8:12 ` Russell King - ARM Linux
2011-04-28 8:17 ` Tony Lindgren
2011-04-28 18:20 ` Nicolas Pitre
2011-04-29 7:17 ` Tony Lindgren
2011-04-20 4:15 ` [PATCH 3/3] ARM: zImage: fix issues with missing GOT entries for some global variables Nicolas Pitre
2011-04-20 8:42 ` Uwe Kleine-König
2011-04-20 9:19 ` Shawn Guo
2011-04-20 12:28 ` Nicolas Pitre
2011-04-20 12:36 ` Uwe Kleine-König
2011-04-20 12:47 ` Nicolas Pitre
2011-04-27 8:58 ` Russell King - ARM Linux
2011-04-27 15:00 ` Nicolas Pitre
2011-04-20 12:52 ` Shawn Guo
2011-04-20 13:03 ` Nicolas Pitre
2011-04-20 13:17 ` Nicolas Pitre
2011-04-21 12:50 ` Tony Lindgren
2011-04-27 8:55 ` Russell King - ARM Linux
2011-04-27 14:55 ` Nicolas Pitre
2011-04-20 7:21 ` [PATCH 0/3] fix some issues with the kernel decompressor Tony Lindgren
2011-04-20 13:00 ` Nicolas Pitre
2011-04-20 16:55 ` Tony Lindgren
2011-04-20 17:19 ` Nicolas Pitre
2011-04-21 5:59 ` Tony Lindgren
2011-04-21 10:49 ` [PATCH] ARM: Fix relocation if image end past uncompressed kernel end Tony Lindgren
2011-04-21 13:22 ` Nicolas Pitre
2011-04-21 21:26 ` Nicolas Pitre
2011-04-22 3:23 ` Nicolas Pitre
2011-04-22 5:19 ` Shawn Guo
2011-04-22 5:36 ` Shawn Guo
2011-04-22 6:28 ` Tony Lindgren
2011-04-22 14:12 ` Nicolas Pitre
2011-04-26 8:57 ` Tony Lindgren
2011-04-26 12:37 ` [PATCH] ARM: Fix bad SP address after relocating kernel Tony Lindgren
2011-04-26 21:31 ` Nicolas Pitre
2011-04-27 7:48 ` Tony Lindgren
2011-04-22 6:09 ` Tony Lindgren [this message]
2011-04-27 12:47 ` [PATCH] ARM: Fix relocation if image end past uncompressed kernel end Tony Lindgren
2011-04-27 12:56 ` Tony Lindgren
2011-04-27 22:16 ` Nicolas Pitre
2011-04-28 6:38 ` Tony Lindgren
2011-04-28 8:12 ` Tony Lindgren
2011-04-20 11:16 ` [PATCH 0/3] fix some issues with the kernel decompressor Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110422060940.GA16892@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).