From mboxrd@z Thu Jan 1 00:00:00 1970 From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD) Date: Tue, 26 Apr 2011 06:32:31 +0200 Subject: [PATCH 14/14] at91: move clock subsystem init to soc generic init In-Reply-To: <4DB64ACD.7000507@bluewatersys.com> References: <20110425180847.GA12904@game.jcrosoft.org> <1303780300-2205-2-git-send-email-plagnioj@jcrosoft.com> <4DB63841.1060903@bluewatersys.com> <20110426041336.GC12904@game.jcrosoft.org> <4DB64ACD.7000507@bluewatersys.com> Message-ID: <20110426043231.GF12904@game.jcrosoft.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 16:32 Tue 26 Apr , Ryan Mallon wrote: > On 04/26/2011 04:13 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: > > On 15:13 Tue 26 Apr , Ryan Mallon wrote: > >> On 04/26/2011 01:11 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: > >>> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > >>> Cc: Nicolas Ferre > >>> Cc: Patrice Vilchez > >> > >> > >> > >>> /* -------------------------------------------------------------------- > >>> diff --git a/arch/arm/mach-at91/soc.c b/arch/arm/mach-at91/soc.c > >>> index c82d219..2d4e415 100644 > >>> --- a/arch/arm/mach-at91/soc.c > >>> +++ b/arch/arm/mach-at91/soc.c > >>> @@ -115,7 +115,10 @@ void __init at91_initialize(unsigned long main_clock) > >>> > >>> pr_info("AT91: detected soc: %s\n", current_soc.name); > >>> > >>> - current_soc.init(main_clock); > >>> + current_soc.init(); > >> > >> I think this patch should go near the beginning of the series so that > >> current_soc.init never needs to take an argument. > > no until you factorize the at91_init_clock you do need it > > That's my point. If you move this patch earlier so that at91_init_clock > is factorised early then current_soc.init won't ever need the argument. to do this I need to move the gpio and the cloock register and to do so I need to switch to clkdev and early device if I move the gpio I need do to much more changesets so keep the change less intrusive is better Best Regards, J.