From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] dmaengine/dw_dmac: Replace spin_lock_bh with irqsave variants
Date: Tue, 26 Apr 2011 21:30:44 +0100 [thread overview]
Message-ID: <20110426203044.GA17290@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <e52c8e679fbf3007cf7e5e4bcfc86ea208a09d7c.1303123511.git.viresh.kumar@st.com>
On Mon, Apr 18, 2011 at 04:19:59PM +0530, Viresh Kumar wrote:
> static struct dw_desc *dwc_desc_get(struct dw_dma_chan *dwc)
> {
> + struct dw_dma *dw = to_dw_dma(dwc->chan.device);
> struct dw_desc *desc, *_desc;
> struct dw_desc *ret = NULL;
> unsigned int i = 0;
>
> - spin_lock_bh(&dwc->lock);
> + spin_lock_irqsave(&dwc->lock, dw->flags);
It's a very bad idea to store the IRQ flags like this - it means that
another thread operating on this corrupts this threads interrupt flag
settings.
It should be a local variable.
prev parent reply other threads:[~2011-04-26 20:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-18 10:49 [PATCH 1/6] dmaengine/dw_dmac: Replace spin_lock_bh with irqsave variants Viresh Kumar
2011-04-18 10:50 ` [PATCH 2/6] dmaengine/dw_dmac: Enable resubmission from callback routine Viresh Kumar
2011-04-19 6:12 ` Koul, Vinod
2011-04-19 6:23 ` viresh kumar
2011-04-19 6:33 ` Koul, Vinod
2011-04-19 6:46 ` viresh kumar
2011-04-26 20:31 ` Russell King - ARM Linux
2011-04-18 10:50 ` [PATCH 3/6] dmaengine/dw_dmac: call dwc_descriptor_complete from dwc_control with lock held Viresh Kumar
2011-04-18 10:50 ` [PATCH 4/6] dmaengine/dw_dmac: don't call callback routine in case dmaengine_terminate_all() is called Viresh Kumar
2011-04-18 10:50 ` [PATCH 5/6] dmaengine/dw_dmac: set residue as total len in dwc_tx_status if status is !DMA_SUCCESS Viresh Kumar
2011-04-18 10:50 ` [PATCH 6/6] dmaengine/dw_dmac: Divide one sg to many desc, if sg len is greater than DWC_MAX_COUNT Viresh Kumar
2011-04-19 6:25 ` [PATCH 1/6] dmaengine/dw_dmac: Replace spin_lock_bh with irqsave variants viresh kumar
2011-04-26 20:33 ` Russell King - ARM Linux
2011-04-27 3:47 ` viresh kumar
2011-04-27 5:59 ` viresh kumar
2011-04-27 7:28 ` Russell King - ARM Linux
2011-04-26 20:30 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110426203044.GA17290@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).