linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] PXA: Fix typo in proc-xscale.S
@ 2011-04-28  1:46 Marek Vasut
  2011-04-28  6:48 ` Igor Grinberg
  0 siblings, 1 reply; 8+ messages in thread
From: Marek Vasut @ 2011-04-28  1:46 UTC (permalink / raw)
  To: linux-arm-kernel

Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
---
 arch/arm/mm/proc-xscale.S |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mm/proc-xscale.S b/arch/arm/mm/proc-xscale.S
index ce233bc..42af976 100644
--- a/arch/arm/mm/proc-xscale.S
+++ b/arch/arm/mm/proc-xscale.S
@@ -395,7 +395,7 @@ ENTRY(xscale_dma_a0_map_area)
 	teq	r2, #DMA_TO_DEVICE
 	beq	xscale_dma_clean_range
 	b	xscale_dma_flush_range
-ENDPROC(xscsale_dma_a0_map_area)
+ENDPROC(xscale_dma_a0_map_area)
 
 /*
  *	dma_unmap_area(start, size, dir)
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH] PXA: Fix typo in proc-xscale.S
  2011-04-28  1:46 [PATCH] PXA: Fix typo in proc-xscale.S Marek Vasut
@ 2011-04-28  6:48 ` Igor Grinberg
  2011-04-28  9:25   ` Marek Vasut
  2011-04-28  9:55   ` Russell King - ARM Linux
  0 siblings, 2 replies; 8+ messages in thread
From: Igor Grinberg @ 2011-04-28  6:48 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Marek,

On 04/28/11 04:46, Marek Vasut wrote:

> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> ---
>  arch/arm/mm/proc-xscale.S |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mm/proc-xscale.S b/arch/arm/mm/proc-xscale.S
> index ce233bc..42af976 100644
> --- a/arch/arm/mm/proc-xscale.S
> +++ b/arch/arm/mm/proc-xscale.S
> @@ -395,7 +395,7 @@ ENTRY(xscale_dma_a0_map_area)
>  	teq	r2, #DMA_TO_DEVICE
>  	beq	xscale_dma_clean_range
>  	b	xscale_dma_flush_range
> -ENDPROC(xscsale_dma_a0_map_area)
> +ENDPROC(xscale_dma_a0_map_area)
>  
>  /*
>   *	dma_unmap_area(start, size, dir)

Similar patch:
http://www.spinics.net/lists/arm-kernel/msg118258.html

has been sent to Russell quite a while ago,
but somehow got lost or something.

-- 
Regards,
Igor.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] PXA: Fix typo in proc-xscale.S
  2011-04-28  6:48 ` Igor Grinberg
@ 2011-04-28  9:25   ` Marek Vasut
  2011-04-28  9:57     ` Eric Miao
  2011-04-28  9:55   ` Russell King - ARM Linux
  1 sibling, 1 reply; 8+ messages in thread
From: Marek Vasut @ 2011-04-28  9:25 UTC (permalink / raw)
  To: linux-arm-kernel

On Thursday, April 28, 2011 08:48:56 AM Igor Grinberg wrote:
> Hi Marek,
> 
> On 04/28/11 04:46, Marek Vasut wrote:
> > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> > ---
> > 
> >  arch/arm/mm/proc-xscale.S |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/arch/arm/mm/proc-xscale.S b/arch/arm/mm/proc-xscale.S
> > index ce233bc..42af976 100644
> > --- a/arch/arm/mm/proc-xscale.S
> > +++ b/arch/arm/mm/proc-xscale.S
> > @@ -395,7 +395,7 @@ ENTRY(xscale_dma_a0_map_area)
> > 
> >  	teq	r2, #DMA_TO_DEVICE
> >  	beq	xscale_dma_clean_range
> >  	b	xscale_dma_flush_range
> > 
> > -ENDPROC(xscsale_dma_a0_map_area)
> > +ENDPROC(xscale_dma_a0_map_area)
> > 
> >  /*
> >  
> >   *	dma_unmap_area(start, size, dir)
> 
> Similar patch:
> http://www.spinics.net/lists/arm-kernel/msg118258.html
> 
> has been sent to Russell quite a while ago,
> but somehow got lost or something.

Hi,

I'm fine with the other one of course :) I didn't notice, thanks.

Eric, can you pick that one ?

Cheers

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] PXA: Fix typo in proc-xscale.S
  2011-04-28  6:48 ` Igor Grinberg
  2011-04-28  9:25   ` Marek Vasut
@ 2011-04-28  9:55   ` Russell King - ARM Linux
  2011-04-28 10:35     ` Igor Grinberg
  1 sibling, 1 reply; 8+ messages in thread
From: Russell King - ARM Linux @ 2011-04-28  9:55 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Apr 28, 2011 at 09:48:56AM +0300, Igor Grinberg wrote:
> Hi Marek,
> 
> On 04/28/11 04:46, Marek Vasut wrote:
> 
> > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> > ---
> >  arch/arm/mm/proc-xscale.S |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/mm/proc-xscale.S b/arch/arm/mm/proc-xscale.S
> > index ce233bc..42af976 100644
> > --- a/arch/arm/mm/proc-xscale.S
> > +++ b/arch/arm/mm/proc-xscale.S
> > @@ -395,7 +395,7 @@ ENTRY(xscale_dma_a0_map_area)
> >  	teq	r2, #DMA_TO_DEVICE
> >  	beq	xscale_dma_clean_range
> >  	b	xscale_dma_flush_range
> > -ENDPROC(xscsale_dma_a0_map_area)
> > +ENDPROC(xscale_dma_a0_map_area)
> >  
> >  /*
> >   *	dma_unmap_area(start, size, dir)
> 
> Similar patch:
> http://www.spinics.net/lists/arm-kernel/msg118258.html
> 
> has been sent to Russell quite a while ago,
> but somehow got lost or something.

As I keep saying, I'm useless dealing with patches sent only by email -
they tend to get quickly buried and forgotten, plus they need saving out,
sometimes editing and transferring between machines to be applied.

The patch system greatly simplifies that effort, and ensures that patches
don't get forgotten.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] PXA: Fix typo in proc-xscale.S
  2011-04-28  9:25   ` Marek Vasut
@ 2011-04-28  9:57     ` Eric Miao
  0 siblings, 0 replies; 8+ messages in thread
From: Eric Miao @ 2011-04-28  9:57 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Apr 28, 2011 at 5:25 PM, Marek Vasut <marek.vasut@gmail.com> wrote:
> On Thursday, April 28, 2011 08:48:56 AM Igor Grinberg wrote:
>> Hi Marek,
>>
>> On 04/28/11 04:46, Marek Vasut wrote:
>> > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
>> > ---
>> >
>> > ?arch/arm/mm/proc-xscale.S | ? ?2 +-
>> > ?1 files changed, 1 insertions(+), 1 deletions(-)
>> >
>> > diff --git a/arch/arm/mm/proc-xscale.S b/arch/arm/mm/proc-xscale.S
>> > index ce233bc..42af976 100644
>> > --- a/arch/arm/mm/proc-xscale.S
>> > +++ b/arch/arm/mm/proc-xscale.S
>> > @@ -395,7 +395,7 @@ ENTRY(xscale_dma_a0_map_area)
>> >
>> > ? ? teq ? ? r2, #DMA_TO_DEVICE
>> > ? ? beq ? ? xscale_dma_clean_range
>> > ? ? b ? ? ? xscale_dma_flush_range
>> >
>> > -ENDPROC(xscsale_dma_a0_map_area)
>> > +ENDPROC(xscale_dma_a0_map_area)
>> >
>> > ?/*
>> >
>> > ? * dma_unmap_area(start, size, dir)
>>
>> Similar patch:
>> http://www.spinics.net/lists/arm-kernel/msg118258.html
>>
>> has been sent to Russell quite a while ago,
>> but somehow got lost or something.
>
> Hi,
>
> I'm fine with the other one of course :) I didn't notice, thanks.
>
> Eric, can you pick that one ?
>

Picked, will send to Russell soon.

> Cheers
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] PXA: Fix typo in proc-xscale.S
  2011-04-28  9:55   ` Russell King - ARM Linux
@ 2011-04-28 10:35     ` Igor Grinberg
  2011-04-28 10:47       ` Uwe Kleine-König
  0 siblings, 1 reply; 8+ messages in thread
From: Igor Grinberg @ 2011-04-28 10:35 UTC (permalink / raw)
  To: linux-arm-kernel

On 04/28/11 12:55, Russell King - ARM Linux wrote:

> On Thu, Apr 28, 2011 at 09:48:56AM +0300, Igor Grinberg wrote:
>> Hi Marek,
>>
>> On 04/28/11 04:46, Marek Vasut wrote:
>>
>>> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
>>> ---
>>>  arch/arm/mm/proc-xscale.S |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/arch/arm/mm/proc-xscale.S b/arch/arm/mm/proc-xscale.S
>>> index ce233bc..42af976 100644
>>> --- a/arch/arm/mm/proc-xscale.S
>>> +++ b/arch/arm/mm/proc-xscale.S
>>> @@ -395,7 +395,7 @@ ENTRY(xscale_dma_a0_map_area)
>>>  	teq	r2, #DMA_TO_DEVICE
>>>  	beq	xscale_dma_clean_range
>>>  	b	xscale_dma_flush_range
>>> -ENDPROC(xscsale_dma_a0_map_area)
>>> +ENDPROC(xscale_dma_a0_map_area)
>>>  
>>>  /*
>>>   *	dma_unmap_area(start, size, dir)
>> Similar patch:
>> http://www.spinics.net/lists/arm-kernel/msg118258.html
>>
>> has been sent to Russell quite a while ago,
>> but somehow got lost or something.
> As I keep saying, I'm useless dealing with patches sent only by email -
> they tend to get quickly buried and forgotten, plus they need saving out,
> sometimes editing and transferring between machines to be applied.
>
> The patch system greatly simplifies that effort, and ensures that patches
> don't get forgotten.

Apparently, not many people read Documentation/arm/README :(
May be it would be helpful to add a note to the MAINTAINERS file
regarding the patch system and tweak scripts/get_maintainer.pl
to spit it out in appropriate cases?

-- 
Regards,
Igor.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] PXA: Fix typo in proc-xscale.S
  2011-04-28 10:35     ` Igor Grinberg
@ 2011-04-28 10:47       ` Uwe Kleine-König
  2011-04-28 11:22         ` Russell King - ARM Linux
  0 siblings, 1 reply; 8+ messages in thread
From: Uwe Kleine-König @ 2011-04-28 10:47 UTC (permalink / raw)
  To: linux-arm-kernel

Hello,

[adding Ben as the author of the linked patch to Cc:]

On Thu, Apr 28, 2011 at 01:35:31PM +0300, Igor Grinberg wrote:
> On 04/28/11 12:55, Russell King - ARM Linux wrote:
> 
> > On Thu, Apr 28, 2011 at 09:48:56AM +0300, Igor Grinberg wrote:
> >> Hi Marek,
> >>
> >> On 04/28/11 04:46, Marek Vasut wrote:
> >>
> >>> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> >>> ---
> >>>  arch/arm/mm/proc-xscale.S |    2 +-
> >>>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>>
> >>> diff --git a/arch/arm/mm/proc-xscale.S b/arch/arm/mm/proc-xscale.S
> >>> index ce233bc..42af976 100644
> >>> --- a/arch/arm/mm/proc-xscale.S
> >>> +++ b/arch/arm/mm/proc-xscale.S
> >>> @@ -395,7 +395,7 @@ ENTRY(xscale_dma_a0_map_area)
> >>>  	teq	r2, #DMA_TO_DEVICE
> >>>  	beq	xscale_dma_clean_range
> >>>  	b	xscale_dma_flush_range
> >>> -ENDPROC(xscsale_dma_a0_map_area)
> >>> +ENDPROC(xscale_dma_a0_map_area)
> >>>  
> >>>  /*
> >>>   *	dma_unmap_area(start, size, dir)
> >> Similar patch:
> >> http://www.spinics.net/lists/arm-kernel/msg118258.html
> >>
> >> has been sent to Russell quite a while ago,
> >> but somehow got lost or something.
> > As I keep saying, I'm useless dealing with patches sent only by email -
> > they tend to get quickly buried and forgotten, plus they need saving out,
> > sometimes editing and transferring between machines to be applied.
> >
> > The patch system greatly simplifies that effort, and ensures that patches
> > don't get forgotten.
> 
> Apparently, not many people read Documentation/arm/README :(
> May be it would be helpful to add a note to the MAINTAINERS file
> regarding the patch system and tweak scripts/get_maintainer.pl
> to spit it out in appropriate cases?
another problem is that the patch system is for reviewed patches only.
If the patch is forgotten before it gets some reply sending it to the
patch system is wrong (at least for non-trivial patches).

Patchwork comes to mind. That doesn't forget patches.
I think for that to be practical for lakml some automatic delegation
would be needed though.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] PXA: Fix typo in proc-xscale.S
  2011-04-28 10:47       ` Uwe Kleine-König
@ 2011-04-28 11:22         ` Russell King - ARM Linux
  0 siblings, 0 replies; 8+ messages in thread
From: Russell King - ARM Linux @ 2011-04-28 11:22 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Apr 28, 2011 at 12:47:32PM +0200, Uwe Kleine-K?nig wrote:
> another problem is that the patch system is for reviewed patches only.
> If the patch is forgotten before it gets some reply sending it to the
> patch system is wrong (at least for non-trivial patches).

That's where pester power comes in - if its still sitting around
unreviewed a week later (assuming there's no long holidays) then
it needs to be chased.

> Patchwork comes to mind. That doesn't forget patches.
> I think for that to be practical for lakml some automatic delegation
> would be needed though.

I'm not convinced that patchwork ultimately reduces the amount of work
required - I think it moves the workload from the patch submitter to
the folk reviewing patches and applying them, who are already overworked.

We have an army of patch submitters but relatively few people reviewing
and applying, so increasing their workload is not really fair.  We need
the workload for people up the chain of patches (who handle a greater
volume of patches) to be less than those down the chain of patches.

Eg, I'm currently struggling to catch up with the email from the last
six days.  Having spent about six hours over the last two days trying to
work through the backlog, I've made a fairly insignificant dent - about
1100 unread messages yesterday morning to 930 unread messages at around
this point in time.  I estimate at this rate I'll have caught up by end
of next week - probably less because I normally seem to drop 10% of email
on the floor unanswered irrespective of the volume.

I already feel like I need another holiday!

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2011-04-28 11:22 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-28  1:46 [PATCH] PXA: Fix typo in proc-xscale.S Marek Vasut
2011-04-28  6:48 ` Igor Grinberg
2011-04-28  9:25   ` Marek Vasut
2011-04-28  9:57     ` Eric Miao
2011-04-28  9:55   ` Russell King - ARM Linux
2011-04-28 10:35     ` Igor Grinberg
2011-04-28 10:47       ` Uwe Kleine-König
2011-04-28 11:22         ` Russell King - ARM Linux

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).