From: sebastian@breakpoint.cc (Sebastian Andrzej Siewior)
To: linux-arm-kernel@lists.infradead.org
Subject: AT91: Convert to fasteoi IRQ handler, and remove ARM irq_finish
Date: Fri, 29 Apr 2011 10:22:03 +0200 [thread overview]
Message-ID: <20110429082203.GA2223@Chamillionaire.breakpoint.cc> (raw)
In-Reply-To: <BANLkTikdnDtwZj1QgLxibRBiv=Ox8Y5PWg@mail.gmail.com>
* Andrew Victor | 2011-04-28 22:03:03 [+0200]:
>hi Sebastian,
Hi Andrew,
>>>> why does this handler mess with the parent irq chip ?
>>>> this looks pretty wrong to me.
>>>
>>>This is a chained-handler, and without that line the end-of-interrupt
>>>doesn't seem to be signalled.
>>
>> Most chain handler don't mess with other irq chips. Why is the parent
>> irq hanlder set level and not eoi? Wouldn't this make this superflous?
>
>This patch changes the parent from level to eoi.
Yes. So why does your gpio chip still call ->irq_eoi() of the parent
irq-chip? This is done by done the eoi-handler of the parent.
Sebastian
prev parent reply other threads:[~2011-04-29 8:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 13:09 AT91: Convert to fasteoi IRQ handler, and remove ARM irq_finish Andrew Victor
2011-04-28 9:33 ` Jean-Christophe PLAGNIOL-VILLARD
2011-04-28 15:18 ` torbenh
2011-04-28 17:12 ` Andrew Victor
2011-04-28 19:24 ` Sebastian Andrzej Siewior
2011-04-28 19:48 ` Thomas Gleixner
2011-04-28 20:20 ` Sebastian Andrzej Siewior
2011-04-28 20:03 ` Andrew Victor
2011-04-29 8:22 ` Sebastian Andrzej Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110429082203.GA2223@Chamillionaire.breakpoint.cc \
--to=sebastian@breakpoint.cc \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).