linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3] ARM:boot:device tree: Allow the device tree binary to be appended to zImage
Date: Wed, 4 May 2011 00:23:17 -0700	[thread overview]
Message-ID: <20110504072317.GU2092@atomide.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1104291509540.24613@xanadu.home>

* Nicolas Pitre <nico@fluxnic.net> [110429 12:11]:
> On Fri, 29 Apr 2011, Russell King - ARM Linux wrote:
> 
> > On Fri, Apr 29, 2011 at 09:16:39AM -0400, Nicolas Pitre wrote:
> > > On Fri, 29 Apr 2011, Tony Lindgren wrote:
> > > 
> > > > If the compressed image is smaller than BSS, then we end up
> > > > having DT data in the BSS area. In this case the compressed
> > > > image is about 2.3 MB for LZMA.
> > > > 
> > > > The uncompress code does not know about the kernel BSS,
> > > > and does not necessarily relocate anything depending on the
> > > > compressed image load address.
> > > > 
> > > > So in which code do we want to relocate the DT data?
> > > > 
> > > > We could do it based on estimated BSS size in uncompress code,
> > > > or based on the real BSS size in __mmap_switched before BSS
> > > > gets reset.
> > > 
> > > Estimations for that kind of thing is always bound to create problems 
> > > some day.
> > > 
> > > The DT data should probably be moved out of the way from 
> > > arch/arm/kernel/head.S before the .bss is cleared, and even before 
> > > enabling the MMU, like in __vet_atags.
> > 
> > Err, no.  Moving stuff around becomes quite expensive when the cache is
> > not on.  It's far better to work out where to place it first time around
> > so its not in the way.
> 
> I don't think the DT data is that huge, but that's a point in favor of 
> doing it in the zImage code.  We'll just need to feed the total size of 
> the uncompressed kernel .bss section to zImage when compiling it.

One more thing to consider though.. I don't think we want to copy the
DT data twice. It's not big right now, but could get large if we pass
all the clocks in it.

So this should be probably fixed in the original patch.. John got
any thoughts on that?

Regards,

Tony

  reply	other threads:[~2011-05-04  7:23 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-24 23:18 [PATCHv3] ARM:boot:device tree: Allow the device tree binary to be appended to zImage John Bonesio
2011-03-24 23:37 ` Nicolas Pitre
2011-03-28  9:13 ` Shawn Guo
2011-04-13 14:00   ` Tony Lindgren
2011-04-20  5:47     ` Shawn Guo
2011-04-20  7:34       ` Shawn Guo
2011-04-21  8:02         ` Tony Lindgren
2011-04-21 12:46           ` Tony Lindgren
2011-04-27 14:23             ` Tony Lindgren
2011-04-27 14:38               ` Tony Lindgren
2011-04-27 14:40               ` Nicolas Pitre
2011-04-27 14:43                 ` Tony Lindgren
2011-04-29 10:26                   ` Tony Lindgren
2011-04-29 13:02                     ` Grant Likely
2011-04-29 13:08                       ` Grant Likely
2011-04-29 13:09                       ` Tony Lindgren
2011-04-29 13:21                         ` Nicolas Pitre
2011-04-29 13:16                     ` Nicolas Pitre
2011-04-29 13:53                       ` Russell King - ARM Linux
2011-04-29 19:14                         ` Nicolas Pitre
2011-05-04  7:23                           ` Tony Lindgren [this message]
2011-05-04 13:12                             ` Tony Lindgren
2011-05-04 13:38                             ` Nicolas Pitre
2011-05-09 11:19                               ` [PATCH] ARM: Make sure appended device tree data won't overlap kernel BSS Tony Lindgren
2011-05-09 14:49                                 ` Tony Lindgren
2011-05-12 12:59                                   ` Tony Lindgren
2011-05-13  7:39                                     ` Nicolas Pitre
2011-05-13 11:21                                       ` Tony Lindgren
2011-05-13 13:09                                         ` Nicolas Pitre
2011-05-13 13:28                                           ` Tony Lindgren
2011-06-07 12:43                                             ` Tony Lindgren
2011-06-07 13:14                                               ` Nicolas Pitre
2011-06-07 13:22                                                 ` Tony Lindgren
2011-06-12  6:14                                         ` Nicolas Pitre
2011-06-13 10:49                                           ` Tony Lindgren
2011-05-09 11:23 ` [PATCHv3] ARM:boot:device tree: Allow the device tree binary to be appended to zImage Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110504072317.GU2092@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).