From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] drivers: create a pinmux subsystem
Date: Wed, 4 May 2011 02:16:20 -0700 [thread overview]
Message-ID: <20110504091619.GV2092@atomide.com> (raw)
In-Reply-To: <1304363786-30376-1-git-send-email-linus.walleij@stericsson.com>
* Linus Walleij <linus.walleij@stericsson.com> [110502 12:13]:
Good to see this, looks like this should work for omaps too.
The numbering solves the issue where we have multiple
pinmux domains (base + offset for each domain).
Then I would assume that for most cases the pin access can be
described with:
unsigned long pinmux_base; /* Can have multiple pinux domains */
u16 pinmux_reg_offset; /* Register offset from pinmux_base */
u16 flags; /* Register width etc */
Which can be accessed with read[bwl] and write[bwl], so we
can have default access functions in the pinux framework and
don't necessarily have to implement them for each platform.
Does this work for you? If so, then we can have the data in the
same format for all the architectures for devicetree.
And then we can have pin_get and pin_set functions, so platforms
can implement their custom flags like wake-up trigger etc with
just read[bwl] and write[bwl].
Also noticed one typo:
> +/* Plobal array of descriptors, one for each physical pin */
> +static DEFINE_SPINLOCK(pin_desc_lock);
> +static struct pin_desc pin_desc[MACH_NR_PINS];
s/Plobal/Global/
Regards,
Tony
next prev parent reply other threads:[~2011-05-04 9:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-02 19:16 [PATCH 1/4] drivers: create a pinmux subsystem Linus Walleij
2011-05-02 19:37 ` Joe Perches
2011-05-10 22:18 ` Linus Walleij
2011-05-10 22:37 ` Joe Perches
2011-05-10 22:52 ` Linus Walleij
2011-05-10 22:40 ` Mark Brown
2011-05-02 20:52 ` Stephen Warren
2011-05-02 21:30 ` Colin Cross
2011-05-04 9:22 ` Tony Lindgren
2011-05-07 19:06 ` Mike Rapoport
2011-05-09 15:25 ` Tony Lindgren
2011-05-03 1:45 ` Ben Nizette
2011-05-10 22:46 ` Linus Walleij
2011-05-03 1:47 ` Ben Nizette
2011-05-04 9:16 ` Tony Lindgren [this message]
2011-05-07 19:10 ` Mike Rapoport
2011-05-09 15:46 ` Tony Lindgren
2011-05-04 22:48 ` Rohit Vaswani
2011-05-05 18:16 ` Rohit Vaswani
2011-05-07 20:09 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110504091619.GV2092@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).