From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Sun, 8 May 2011 11:16:09 +0100 Subject: [PATCH][WAS:bcmai,axi] bcma: add Broadcom specific AMBA bus driver In-Reply-To: References: <1304632783-8781-1-git-send-email-zajec5@gmail.com> <201105061605.31625.arnd@arndb.de> <1304790665.13983.10.camel@dev.znau.edu.ua> <1304792795.13983.28.camel@dev.znau.edu.ua> Message-ID: <20110508101609.GF27807@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, May 07, 2011 at 08:48:10PM +0200, Rafa? Mi?ecki wrote: > Really, what's wrong with that? Does it kill anyone's pet we print > this? We also do: > pr_err("Scanning failed because of wrong CID\n"); > return -1; > While we could drop pr_err. Why to do this? Advanced used can always > check what -1 means. And why return -1 when we have a system of error codes? I _really_ wish people would stop returning -1 for "some random error occurred".