From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/13] clocksource: convert ARM 32-bit down counting clocksources
Date: Tue, 10 May 2011 09:07:52 +0100 [thread overview]
Message-ID: <20110510080752.GA29977@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20110510073930.GA19558@mail.gnudd.com>
On Tue, May 10, 2011 at 09:39:30AM +0200, Alessandro Rubini wrote:
> > Convert MXC, Nomadik and Orion 32-bit down-counting clocksources to
> > generic mmio clocksource infrastructure.
>
> Ok, but I think Linusw should ack this as there is the issue of
> dummy-read used initially, that I really didn't understand.
It was introduced for sched_clock() support - see 2a84751 (ARM: 6107/1:
plat-nomadik: use the MTU clocksrc for sched_clock). That has already
been revised so it doesn't use nmdk_clksrc.read - see 8fbb97a (ARM:
6488/1: nomadik: prevent sched_clock() wraparound).
The clocksource isn't registered, and there are no users of
nmdk_clksrc.read, so nothing is going to call the dummy read function.
> > + if (clocksource_mmio_init(mti_base + MTU_VAL(0), "mtu_0",
>
> Typo. That's "mtu_base", not "mti".
Fixed.
next prev parent reply other threads:[~2011-05-10 8:07 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 7:27 [PATCH 00/13] Consolidate simple ARM MMIO clock sources Russell King - ARM Linux
2011-05-10 7:27 ` [PATCH 01/13] Make clocksource name const Russell King - ARM Linux
2011-05-10 7:27 ` [PATCH 02/13] ARM: s5p: consolidate selection of timer register Russell King - ARM Linux
2011-05-12 7:01 ` Kukjin Kim
2011-05-10 7:28 ` [PATCH 03/13] ARM: omap1: delete useless interrupt handler Russell King - ARM Linux
2011-05-10 12:49 ` Kevin Hilman
2011-05-12 7:25 ` Tony Lindgren
2011-05-10 7:28 ` [PATCH 04/13] ARM: omap1: convert to using readl/writel instead of volatile struct Russell King - ARM Linux
2011-05-12 7:45 ` Tony Lindgren
2011-05-10 7:28 ` [PATCH 05/13] ARM: update sa1100 to reflect PXA updates Russell King - ARM Linux
2011-05-10 7:29 ` [PATCH 06/13] clocksource: add common mmio clocksource Russell King - ARM Linux
2011-05-10 8:38 ` Sascha Hauer
2011-05-10 8:46 ` Russell King - ARM Linux
2011-05-12 7:43 ` Tony Lindgren
2011-05-10 9:59 ` Russell King - ARM Linux
2011-05-11 8:15 ` viresh kumar
2011-05-11 8:35 ` [PATCH 06/13 v2] " Russell King - ARM Linux
2011-05-12 8:03 ` [PATCH 06/13] " Thomas Gleixner
2011-05-10 7:29 ` [PATCH 07/13] clocksource: convert ARM 32-bit up counting clocksources Russell King - ARM Linux
2011-05-10 21:10 ` Linus Walleij
2011-05-11 7:52 ` Russell King - ARM Linux
2011-05-11 0:16 ` Hans J. Koch
2011-05-11 7:52 ` Russell King - ARM Linux
2011-05-11 8:07 ` Hans J. Koch
2011-05-15 3:53 ` Colin Cross
2011-05-26 8:32 ` Richard Cochran
2011-05-10 7:31 ` [PATCH 08/13] clocksource: convert ARM 32-bit down " Russell King - ARM Linux
2011-05-10 12:39 ` Nicolas Pitre
2011-05-11 7:53 ` Russell King - ARM Linux
2011-05-11 13:45 ` Nicolas Pitre
2011-05-10 21:04 ` Linus Walleij
2011-05-11 7:53 ` Russell King - ARM Linux
2011-05-12 12:47 ` [PATCH 08/13 v2] " Russell King - ARM Linux
2011-05-13 14:30 ` Catalin Marinas
2011-05-10 7:31 ` [PATCH 09/13] clocksource: convert W90x900 24-bit down counting clocksource Russell King - ARM Linux
2011-05-10 7:31 ` [PATCH 10/13] clocksource: convert Integrator/AP 16-bit " Russell King - ARM Linux
2011-05-10 7:32 ` [PATCH 11/13] clocksource: convert SPEAr platforms 16-bit up " Russell King - ARM Linux
2011-05-11 3:31 ` viresh kumar
2011-05-11 7:53 ` Russell King - ARM Linux
2011-05-11 8:13 ` viresh kumar
2011-05-10 7:34 ` [PATCH 12/13] clocksource: convert MXS timrotv2 to 32-bit down " Russell King - ARM Linux
2011-05-16 14:31 ` Shawn Guo
2011-05-16 15:16 ` Shawn Guo
2011-05-16 17:18 ` Russell King - ARM Linux
2011-05-10 7:34 ` [PATCH 13/13] clocksource: convert OMAP1 " Russell King - ARM Linux
2011-05-12 7:46 ` Tony Lindgren
2011-05-10 7:39 ` [PATCH 08/13] clocksource: convert ARM 32-bit down counting clocksources Alessandro Rubini
2011-05-10 8:07 ` Russell King - ARM Linux [this message]
2011-05-12 13:49 ` [PATCH 14/13] clocksource: ARM sp804: allow clocksource name to be specified Russell King - ARM Linux
2011-05-13 14:32 ` Catalin Marinas
2011-05-12 13:51 ` [PATCH 15/13] clocksource: ARM sp804: obtain sp804 timer rate via clks Russell King - ARM Linux
2011-05-13 15:01 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110510080752.GA29977@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).