From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pxamci: remove an ifdef about CONFIG_REGULATOR
Date: Tue, 10 May 2011 22:36:30 +0200 [thread overview]
Message-ID: <20110510203629.GB8726@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110510220214.916621d1.ospite@studenti.unina.it>
On Tue, May 10, 2011 at 10:02:14PM +0200, Antonio Ospite wrote:
> So, I am going to remove the ifdefs anyway but use IS_ERR_OR_NULL();
> how does that sound? Am I still missing anything?
Looks good to me.
> Or changing the regulator_get() stub to return an error (-ENOSYS?) might
> be worth it?
No, the whole point of stubbing out the API is that it allows most
consumers which just do simple enables and disables to run without
needing to worry if the regulator API is compiled in or not.
next prev parent reply other threads:[~2011-05-10 20:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 20:11 [PATCH] pxamci: remove an ifdef about CONFIG_REGULATOR Antonio Ospite
2011-05-09 20:15 ` Mark Brown
2011-05-09 20:23 ` Russell King - ARM Linux
2011-05-09 20:36 ` Mark Brown
2011-05-10 20:02 ` Antonio Ospite
2011-05-10 20:32 ` Russell King - ARM Linux
2011-05-10 20:36 ` Mark Brown [this message]
2011-05-11 10:19 ` [PATCH v2 1/2] pxamci: remove the ifdef CONFIG_REGULATOR Antonio Ospite
2011-05-11 13:07 ` Mark Brown
2011-05-11 14:41 ` Chris Ball
2011-05-11 20:19 ` Antonio Ospite
2011-05-11 10:19 ` [PATCH 2/2] pxamci: fix coding style for multi statement conditionals Antonio Ospite
2011-05-11 10:26 ` [PATCH] pxamci: remove an ifdef about CONFIG_REGULATOR Antonio Ospite
2011-05-10 11:59 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110510203629.GB8726@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).